Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow setters in IndexLoadingConfig #14106

Open
Jackie-Jiang opened this issue Sep 27, 2024 · 2 comments
Open

Do not allow setters in IndexLoadingConfig #14106

Jackie-Jiang opened this issue Sep 27, 2024 · 2 comments

Comments

@Jackie-Jiang
Copy link
Contributor

IndexLoadingConfig should always be initialized by TableConfig and Schema, and all the index related config should be extracted from them. Right now we allow setters to internal fields such as _invertedIndexColumns, noDictionaryColumns etc which makes config management extremely hard, especially after introducing Index SPI. We have run into problems such as forward index config not picked up from table config.

We use this issue to track all effort of removing setters from IndexLoadingConfig.

Similarly, we should also remove all setters in SegmentGeneratorConfig

@Jackie-Jiang
Copy link
Contributor Author

Do not allow setting TableConfig in IndexLoadingConfig after construction: #14098

@deepthi912
Copy link
Collaborator

I can look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants