For consuming segment, avoid using setter in IndexLoadingConfig #14190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
fix_realtime_sorted
branch
from
f1396b1
to
c21a563
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14190 +/- ##
============================================
+ Coverage 61.75% 63.82% +2.07%
- Complexity 207 1536 +1329
============================================
Files 2436 2622 +186
Lines 133233 144372 +11139
Branches 20636 22092 +1456
============================================
+ Hits 82274 92151 +9877
- Misses 44911 45432 +521
- Partials 6048 6789 +741
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
approved these changes
Oct 9, 2024
Jackie-Jiang
force-pushed
the
fix_realtime_sorted
branch
from
c21a563
to
2d007f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-task of #14106
Currently in
RealtimeSegmentDataManagerwe rely on callingIndexLoadingConfig.addInvertedIndexColumns()to create inverted index for sorted column. It can cause inconsistent index loading config and table config.This PR avoids that and moves the handling logic into
RealtimeSegmentConfig.Added
LLCRealtimeClusterIntegrationTest.testSortedColumn()to ensure the expected behavior.