Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup setters in IndexLoadingConfig and do not initialize IndexConfig from it #14258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jackie-Jiang
Copy link
Contributor

Subtask of #14106

On top of #14256

After this PR, IndexConfig is always constructed from table config and schema to ensure consistent behavior

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 85.04673% with 16 lines in your changes missing coverage. Please review.

Project coverage is 55.44%. Comparing base (59551e4) to head (eff6237).
Report is 1214 commits behind head on master.

Files with missing lines Patch % Lines
...local/segment/index/loader/IndexLoadingConfig.java 83.78% 6 Missing and 6 partials ⚠️
...ment/local/segment/index/bloom/BloomIndexType.java 87.50% 1 Missing ⚠️
...ocal/segment/index/inverted/InvertedIndexType.java 85.71% 1 Missing ⚠️
...egment/local/segment/index/json/JsonIndexType.java 87.50% 0 Missing and 1 partial ⚠️
.../segment/local/segment/index/map/MapIndexType.java 83.33% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (eff6237). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (59551e4) HEAD (eff6237)
integration 7 5
integration2 3 1
temurin 12 8
java-21 7 5
skip-bytebuffers-true 3 2
skip-bytebuffers-false 7 4
unittests 5 3
java-11 5 3
unittests2 3 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14258      +/-   ##
============================================
- Coverage     61.75%   55.44%   -6.31%     
- Complexity      207      797     +590     
============================================
  Files          2436     2074     -362     
  Lines        133233   109354   -23879     
  Branches      20636    17314    -3322     
============================================
- Hits          82274    60636   -21638     
+ Misses        44911    43887    -1024     
+ Partials       6048     4831    -1217     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 55.37% <85.04%> (-6.34%) ⬇️
java-21 55.29% <85.04%> (-6.34%) ⬇️
skip-bytebuffers-false 55.40% <85.04%> (-6.35%) ⬇️
skip-bytebuffers-true 55.25% <85.04%> (+27.52%) ⬆️
temurin 55.44% <85.04%> (-6.31%) ⬇️
unittests 55.44% <85.04%> (-6.31%) ⬇️
unittests1 55.44% <85.04%> (+8.55%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang force-pushed the clean_index_config branch 2 times, most recently from d023db9 to 5edd1a5 Compare October 21, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants