Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ForwardIndexHandlerTest and avoid using setters for IndexLoadingConfig #14124

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

Sub-task of #14106

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (59551e4) to head (cc0f7ec).
Report is 1110 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14124      +/-   ##
============================================
+ Coverage     61.75%   64.09%   +2.33%     
- Complexity      207     1537    +1330     
============================================
  Files          2436     2600     +164     
  Lines        133233   143505   +10272     
  Branches      20636    21982    +1346     
============================================
+ Hits          82274    91975    +9701     
+ Misses        44911    44752     -159     
- Partials       6048     6778     +730     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 64.03% <ø> (+2.32%) ⬆️
java-21 63.98% <ø> (+2.35%) ⬆️
skip-bytebuffers-false 64.06% <ø> (+2.31%) ⬆️
skip-bytebuffers-true 63.95% <ø> (+36.23%) ⬆️
temurin 64.09% <ø> (+2.33%) ⬆️
unittests 64.08% <ø> (+2.34%) ⬆️
unittests1 55.79% <ø> (+8.90%) ⬆️
unittests2 34.53% <ø> (+6.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 50249f3 into apache:master Oct 1, 2024
21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_forward_index_handler_test branch October 1, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants