Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setters dependency of IndexLoadingConfig class in Test Classes #14201

Merged
merged 42 commits into from
Oct 10, 2024

Conversation

deepthi912
Copy link
Collaborator

@deepthi912 deepthi912 commented Oct 10, 2024

Subtask of #14106

Continuation to removing setters from IndexLoadingConfig

deepthi912 and others added 30 commits March 25, 2024 22:02
Enforce removeSegment flow with _enableDeletedKeysCompactionConsisten…
Reverse merge from master
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (59551e4) to head (5699477).
Report is 1170 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14201      +/-   ##
============================================
+ Coverage     61.75%   63.83%   +2.08%     
- Complexity      207     1536    +1329     
============================================
  Files          2436     2622     +186     
  Lines        133233   144396   +11163     
  Branches      20636    22104    +1468     
============================================
+ Hits          82274    92178    +9904     
- Misses        44911    45432     +521     
- Partials       6048     6786     +738     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.79% <ø> (+2.08%) ⬆️
java-21 63.72% <ø> (+2.09%) ⬆️
skip-bytebuffers-false 63.80% <ø> (+2.06%) ⬆️
skip-bytebuffers-true 63.69% <ø> (+35.97%) ⬆️
temurin 63.83% <ø> (+2.08%) ⬆️
unittests 63.83% <ø> (+2.08%) ⬆️
unittests1 55.50% <ø> (+8.61%) ⬆️
unittests2 34.36% <ø> (+6.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 9ef4bea into apache:master Oct 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants