-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setters dependency of IndexLoadingConfig class in Test Classes #14201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverse merge
reverse merge
reverse merge
reverse merge
reverse merge
reverse merge
reverse merge
Enforce removeSegment flow with _enableDeletedKeysCompactionConsisten…
reverse merge
Reverse merge from master
reverse merge
reverse merge
merge master
merge master into JsonProperty
…to JsonProperty
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14201 +/- ##
============================================
+ Coverage 61.75% 63.83% +2.08%
- Complexity 207 1536 +1329
============================================
Files 2436 2622 +186
Lines 133233 144396 +11163
Branches 20636 22104 +1468
============================================
+ Hits 82274 92178 +9904
- Misses 44911 45432 +521
- Partials 6048 6786 +738
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtask of #14106
Continuation to removing setters from IndexLoadingConfig