FOR REVIEW ONLY - js-algorand-sdk v1.13.0 #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding dryrun function, untested * export dryrun in main * Add ABI interaction support (#466) * Move multisig code out of main * Implement JSON description objects * Fix multisig export * Implement atomic txn composer and fix variable shadow issues * Actually copy transactions * Implement JSON description cucumber tests * Fix lots of bugs and pass JSON cucumber tests * Implement payment txn encoding test * Implement composer tests * Add missing export to main * Fix step implementation * Fix remaining integration tests * Fix for firefox * Final fixes for firefox * appID -> appId * Actually finally fix firefox tests * Check for unpaired parenthesis when parsing method sig * Also allow generic `txn` type * Handle null method args * Throw error when building a group with 0 txns * PR feedback * bump up to v1.13.0-beta.1 and add to changelog * Update integrity hash * adding dryrun function, untested * export dryrun in main * actually push promises into array, use argument object * Adding magic app id * encode the address since we're expecting a string * decode programs in accounts * adding app addr to accounts Co-authored-by: John Lee <john.lee@algorand.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
* Document Algodv2 methods * Link to relevant methods on Algodv2 doc * Replace algoexplorer api with sandbox api * Clean up pendingTxns examples * Show setIntEncoding method on docs
* Add docs for indexer * Add docs for Indexer LookupAssetBalances
algobarb
requested review from
ahangsu,
algochoi,
algojack,
barnjamin,
bricerisingalgorand,
egieseke,
jasonpaulos and
onetechnical
Contributor
|
Do we want to squash the changelogs for 1.13.0-beta.1 and -beta.2 into 1.13.0? I'm not sure what the best practice is for this. |
Contributor
Author
I took the description from #493, but I think you're right. It makes sense to squash the beta notes under 1.13.0 as well. |
Contributor
Author
|
I added 1.13.0-beta.1 and -beta.2 notes into 1.13.0 in the changelog, while leaving 1.13.0-beta.1 and -beta.2 changelogs alone for binary reference. I think it might be useful to keep the beta release changelog notes too, but I'm not sure. What do you prefer to see? @onetechnical @jasonpaulos |
jasonpaulos
approved these changes
Jan 13, 2022
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
This looks good to me
onetechnical
approved these changes
Jan 13, 2022
barnjamin
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.13.0
Added:
Changed:
Fixed:
foreignAssetstype #472)