Add wait for confirmation function #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
reviewed
Nov 10, 2021
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Nice addition to the JS SDK 🎉
I'm also curious to whether this should be kept with algod or transactions (I believe the Python SDK binds this method to the latter).
| await this.v2Client.statusAfterBlock(sp.firstRound + 2).do(); | ||
| const fundingConfirmation = await this.acl.transactionById( | ||
| fundingResponse.txId | ||
| const info = await algosdk.waitForConfirmation( |
Contributor
There was a problem hiding this comment.
Nice -- also what is this.acl? Is that the v1 client?
Contributor
Author
There was a problem hiding this comment.
Yes that's the v1 algod client
Contributor
There was a problem hiding this comment.
ahangsu
reviewed
Nov 10, 2021
Contributor
ahangsu
left a comment
ahangsu
left a comment
There was a problem hiding this comment.
I don't have general comments here. Just curious, why there are 2 alike implementation for WaitForConfirmation in JS-SDK?
Contributor
Author
|
My bad, I originally forgot to delete the file in the algod client folder. |
algochoi
approved these changes
Nov 10, 2021
aldur
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Added waitForConfirmation to v2 API * Renamed timeout to waitRounds * Move to waitForConfirmation function * Change eslint settings * Use in cucumber tests * Delete file from algod folder Co-authored-by: Damian Barabonkov <damianb@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wait for confirmation function for verifying transaction confirmation.