Add ABI interaction support #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
force-pushed
the
feature/abi-interaction
branch
from
3d89b25 to
508e38c
Compare
jasonpaulos
force-pushed
the
feature/abi-interaction
branch
from
1015a57 to
228a56f
Compare
algochoi
reviewed
Nov 18, 2021
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Nice and clean implementation -- just minor comments
algochoi
reviewed
Nov 19, 2021
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Looks good! I think we can merge this after one more pair of eyes looks at it.
algochoi
approved these changes
Nov 20, 2021
ahangsu
reviewed
Nov 22, 2021
ahangsu
reviewed
Nov 22, 2021
jasonpaulos
added a commit
that referenced
this pull request
Jan 10, 2022
* adding dryrun function, untested * export dryrun in main * Add ABI interaction support (#466) * Move multisig code out of main * Implement JSON description objects * Fix multisig export * Implement atomic txn composer and fix variable shadow issues * Actually copy transactions * Implement JSON description cucumber tests * Fix lots of bugs and pass JSON cucumber tests * Implement payment txn encoding test * Implement composer tests * Add missing export to main * Fix step implementation * Fix remaining integration tests * Fix for firefox * Final fixes for firefox * appID -> appId * Actually finally fix firefox tests * Check for unpaired parenthesis when parsing method sig * Also allow generic `txn` type * Handle null method args * Throw error when building a group with 0 txns * PR feedback * bump up to v1.13.0-beta.1 and add to changelog * Update integrity hash * adding dryrun function, untested * export dryrun in main * actually push promises into array, use argument object * Adding magic app id * encode the address since we're expecting a string * decode programs in accounts * adding app addr to accounts Co-authored-by: John Lee <john.lee@algorand.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
jasonpaulos
added a commit
that referenced
this pull request
Jan 19, 2022
* adding dryrun function, untested * export dryrun in main * Add ABI interaction support (#466) * Move multisig code out of main * Implement JSON description objects * Fix multisig export * Implement atomic txn composer and fix variable shadow issues * Actually copy transactions * Implement JSON description cucumber tests * Fix lots of bugs and pass JSON cucumber tests * Implement payment txn encoding test * Implement composer tests * Add missing export to main * Fix step implementation * Fix remaining integration tests * Fix for firefox * Final fixes for firefox * appID -> appId * Actually finally fix firefox tests * Check for unpaired parenthesis when parsing method sig * Also allow generic `txn` type * Handle null method args * Throw error when building a group with 0 txns * PR feedback * bump up to v1.13.0-beta.1 and add to changelog * Update integrity hash * adding dryrun function, untested * export dryrun in main * actually push promises into array, use argument object * Adding magic app id * encode the address since we're expecting a string * decode programs in accounts * adding app addr to accounts * adding accts for creator of app and app addr * remove redundant app address Co-authored-by: John Lee <john.lee@algorand.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com> Co-authored-by: egieseke <eric_gieseke@yahoo.com> Co-authored-by: Barbara Poon <barbara.poon@algorand.com>
aldur
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Move multisig code out of main * Implement JSON description objects * Fix multisig export * Implement atomic txn composer and fix variable shadow issues * Actually copy transactions * Implement JSON description cucumber tests * Fix lots of bugs and pass JSON cucumber tests * Implement payment txn encoding test * Implement composer tests * Add missing export to main * Fix step implementation * Fix remaining integration tests * Fix for firefox * Final fixes for firefox * appID -> appId * Actually finally fix firefox tests * Check for unpaired parenthesis when parsing method sig * Also allow generic `txn` type * Handle null method args * Throw error when building a group with 0 txns * PR feedback
aldur
pushed a commit
that referenced
this pull request
Jan 20, 2022
* adding dryrun function, untested * export dryrun in main * Add ABI interaction support (#466) * Move multisig code out of main * Implement JSON description objects * Fix multisig export * Implement atomic txn composer and fix variable shadow issues * Actually copy transactions * Implement JSON description cucumber tests * Fix lots of bugs and pass JSON cucumber tests * Implement payment txn encoding test * Implement composer tests * Add missing export to main * Fix step implementation * Fix remaining integration tests * Fix for firefox * Final fixes for firefox * appID -> appId * Actually finally fix firefox tests * Check for unpaired parenthesis when parsing method sig * Also allow generic `txn` type * Handle null method args * Throw error when building a group with 0 txns * PR feedback * bump up to v1.13.0-beta.1 and add to changelog * Update integrity hash * adding dryrun function, untested * export dryrun in main * actually push promises into array, use argument object * Adding magic app id * encode the address since we're expecting a string * decode programs in accounts * adding app addr to accounts Co-authored-by: John Lee <john.lee@algorand.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
AtomicTransactionComposerAtomicTransactionComposercucumber testsCloses #457