Create dryrun #478
Merged
Create dryrun #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move multisig code out of main * Implement JSON description objects * Fix multisig export * Implement atomic txn composer and fix variable shadow issues * Actually copy transactions * Implement JSON description cucumber tests * Fix lots of bugs and pass JSON cucumber tests * Implement payment txn encoding test * Implement composer tests * Add missing export to main * Fix step implementation * Fix remaining integration tests * Fix for firefox * Final fixes for firefox * appID -> appId * Actually finally fix firefox tests * Check for unpaired parenthesis when parsing method sig * Also allow generic `txn` type * Handle null method args * Throw error when building a group with 0 txns * PR feedback
…into create-dryrun
barnjamin
requested review from
ahangsu and
algochoi
and removed request for
jdtzmn
jasonpaulos
reviewed
Dec 6, 2021
ahangsu
reviewed
Dec 6, 2021
Contributor
Author
|
While testing the output as msgpack, tealdbg uses the applications in the The latest commit includes logic to decode the approval/clear-state programs after we get them back from the rest calls but before adding them to the info arrays. I'm not happy with how its done here, please offer a better way if you've got one |
jasonpaulos
approved these changes
Jan 10, 2022
aldur
pushed a commit
that referenced
this pull request
Jan 20, 2022
* adding dryrun function, untested * export dryrun in main * Add ABI interaction support (#466) * Move multisig code out of main * Implement JSON description objects * Fix multisig export * Implement atomic txn composer and fix variable shadow issues * Actually copy transactions * Implement JSON description cucumber tests * Fix lots of bugs and pass JSON cucumber tests * Implement payment txn encoding test * Implement composer tests * Add missing export to main * Fix step implementation * Fix remaining integration tests * Fix for firefox * Final fixes for firefox * appID -> appId * Actually finally fix firefox tests * Check for unpaired parenthesis when parsing method sig * Also allow generic `txn` type * Handle null method args * Throw error when building a group with 0 txns * PR feedback * bump up to v1.13.0-beta.1 and add to changelog * Update integrity hash * adding dryrun function, untested * export dryrun in main * actually push promises into array, use argument object * Adding magic app id * encode the address since we're expecting a string * decode programs in accounts * adding app addr to accounts Co-authored-by: John Lee <john.lee@algorand.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding method createDryrun to construct DryrunRequest from client and array of SignedTransaction objects