Support ABI reference types and other improvements #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
changed the title
ahangsu
reviewed
Dec 13, 2021
algochoi
reviewed
Dec 23, 2021
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
I like the new type checks! Overall looks good -- just had a few questions about resolving foreign objects in the composer.
algochoi
reviewed
Dec 23, 2021
ahangsu
reviewed
Dec 27, 2021
ahangsu
reviewed
Dec 27, 2021
ahangsu
reviewed
Dec 27, 2021
ahangsu
reviewed
Dec 27, 2021
Contributor
ahangsu
left a comment
ahangsu
left a comment
There was a problem hiding this comment.
Looks largely good to me, just some minor polishing here and there
algochoi
approved these changes
Dec 27, 2021
This was referenced Dec 28, 2021
aldur
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Support ABI reference types * Use new `ABIContract.networks` field * Document `populateForeignArray` * Change `equal` to `equals` * Temporarily change algorand-sdk-testing branch * Fix firefox step * Implement testing support for multiple methods in one atomic group * Support ABI app creation & update * Only check last log for return value * Add description fields for Interface and Contract * Fix return bug * Set status to submitted during execution * Switch back to master branch of cucumber repo * Remove magic constants 15 and 14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABIType.encodeand.equalABIContractclassalgorand-sdk-testingbranch back tomasterafter Additional ABI testing algorand-sdk-testing#153 is mergedCloses #468, closes #483