ToggleGroupControl: Make unselected item color consistent across all variants#75737
Merged
ToggleGroupControl: Make unselected item color consistent across all variants#75737
ToggleGroupControl: Make unselected item color consistent across all variants#75737Conversation
ciampo
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
commented
Feb 19, 2026
|
|
||
| &:hover { | ||
| color: ${ COLORS.theme.gray[ 900 ] }; | ||
| color: ${ COLORS.theme.foreground }; |
Contributor
Author
There was a problem hiding this comment.
This is effectively the same color, but the change fixes a deprecation warning.
|
Size Change: +14 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
Contributor
|
Nice, thanks for doing this! At a glance, this looks good, what's the hex code color? I had some problem with my env trying to test this, just want to make sure the gray color is at least the equivalent of gray 600 or around 700, either of those is fine. |
mirka
approved these changes
Feb 19, 2026
Member
mirka
left a comment
mirka
left a comment
There was a problem hiding this comment.
While I still have concerns about differentiation between disabled and unselected, I'd say the changes in this PR are just consistency improvements 👍
Also I noticed a bug. It's subtle, but there's a hover effect on disabled items:
CleanShot.2026-02-20.at.04-39-39.mp4
Probably pre-existing, so your call on whether a fix can be sneaked in here 😄
ciampo
changed the title
ToggleGroupControl: tweak deselected item colorToggleGroupControl: Make unselected item color consistent across all variants
ciampo
force-pushed
the
feat/components/tgc-color
branch
from
b008c15 to
dab82cd
Compare
Contributor
Author
Yup, it's
I agree that disabled and unselected items don't look very different, and I also agree that it's something that we should iterate on separately.
👀 🧹 🐛 ❌ I included a fix for that, too. |
|
Flaky tests detected in 3dccb64. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22214636685
|
ciampo
added
the
Backport to WP 7.0 Beta/RC
github-actions
bot
removed
the
Backport to WP 7.0 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Feb 20, 2026
…l variants (#75737) * `ToggleGroupControl`: Remove color override for icon and pressed items * Don't use deprecated variables * CHANGELOG * Edit CHANGELOG * Do not apply hover styles to disabled items * Add hover color bug fix to CHANGELOG --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 430c8b6 |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 20, 2026
CI run: #10988. See #64595. --- I've included a log of the Gutenberg changes with the following command: ``` git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy ``` - Remove experimental property from Icon block (WordPress/gutenberg#75742) - Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740) - Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709) - Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752) - Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758) - Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751) - Query: Remove content role from block (WordPress/gutenberg#75760) - `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737) - Icon-block: fix global-styles selectors (WordPress/gutenberg#75724) - RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708) - Core Data: Create icons entity (WordPress/gutenberg#75773) git-svn-id: https://develop.svn.wordpress.org/trunk@61705 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 20, 2026
CI run: WordPress/wordpress-develop#10988. See #64595. --- I've included a log of the Gutenberg changes with the following command: ``` git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy ``` - Remove experimental property from Icon block (WordPress/gutenberg#75742) - Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740) - Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709) - Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752) - Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758) - Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751) - Query: Remove content role from block (WordPress/gutenberg#75760) - `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737) - Icon-block: fix global-styles selectors (WordPress/gutenberg#75724) - RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708) - Core Data: Create icons entity (WordPress/gutenberg#75773) Built from https://develop.svn.wordpress.org/trunk@61705 git-svn-id: http://core.svn.wordpress.org/trunk@61013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
scruffian
pushed a commit
that referenced
this pull request
Feb 23, 2026
…l variants (#75737) * `ToggleGroupControl`: Remove color override for icon and pressed items * Don't use deprecated variables * CHANGELOG * Edit CHANGELOG * Do not apply hover styles to disabled items * Add hover color bug fix to CHANGELOG --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Tweak the color of the
ToggleGroupControlitems as per the instructions in #75138 (comment)Why?
Visual polish
How?
Removed dedicated color overrides for icon and deselecteable internal item variants.
These variants now align with the standard, non-icons, non-deselectable version of
ToggleGroupControl.These changes also exposed a little bug about the hover color of disabled items, for which a fix is also included in this PR.
Testing Instructions
Screenshots or screencast