Skip to content

RTC: Add cap check for single taxonomy term entities#75708

Merged
chriszarate merged 2 commits intotrunkfrom
hotfix/sync-taxonomy-term-cap-check
Feb 19, 2026
Merged

RTC: Add cap check for single taxonomy term entities#75708
chriszarate merged 2 commits intotrunkfrom
hotfix/sync-taxonomy-term-cap-check

Conversation

@chriszarate
Copy link
Contributor

What?

Add cap check in the default sync provider for single taxonomy term entities.

Why?

@ingeniumed observed that a singular category entity (specifically the Uncategorized category) was being loaded during the pre-publish step. Prior to v22.6.0-RC1, we did not observe this entity being loaded and there is no capability check for singular taxonomy term entities in the default sync provider.

As a result, the sync request fails the permission_callback and results in a disconnection dialog:

Bug.mp4

Adding a capability check resolves this issue. In the future, we can explore handling permission errors like these more gracefully.

How?

  • Add cap check to default sync provider input.
  • This fix has already been added to the backport PR.

Testing Instructions

  1. Check out this PR.
  2. Settings > Writing > Enable real-time collaboration.
  3. Open a post for editing and publish.
  4. Repeat for editor and author roles.

@chriszarate chriszarate added [Type] Bug An existing feature does not function as intended [Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) Backported to WP Core Pull request that has been successfully merged into WP Core labels Feb 19, 2026
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: chriszarate <czarate@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@chriszarate chriszarate enabled auto-merge (squash) February 19, 2026 04:24
@github-actions
Copy link

Flaky tests detected in f0993d8.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22168033823
📝 Reported issues:

@chriszarate
Copy link
Contributor Author

This is not critical to get into a Gutenberg RC release since (1) the fix is included in the backport PR and (2) RTC is not enabled by default in Gutenberg. But if there is another RC release, it's good to include this.

@chriszarate chriszarate merged commit a6c6a9b into trunk Feb 19, 2026
40 checks passed
@chriszarate chriszarate deleted the hotfix/sync-taxonomy-term-cap-check branch February 19, 2026 04:48
@github-actions github-actions bot added this to the Gutenberg 22.7 milestone Feb 19, 2026
adamsilverstein pushed a commit that referenced this pull request Feb 19, 2026
Co-authored-by: chriszarate <czarate@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>
adamsilverstein pushed a commit that referenced this pull request Feb 19, 2026
Co-authored-by: chriszarate <czarate@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>
@ellatrix ellatrix added Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta and removed Backported to WP Core Pull request that has been successfully merged into WP Core labels Feb 20, 2026
@github-actions github-actions bot removed the Backport to WP 7.0 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 20, 2026
gutenbergplugin pushed a commit that referenced this pull request Feb 20, 2026
Co-authored-by: chriszarate <czarate@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>
@github-actions github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Feb 20, 2026
@github-actions
Copy link

I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: f97a9e4

pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Feb 20, 2026
CI run: #10988.

See #64595.

---

I've included a log of the Gutenberg changes with the following command:

```
git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy
```

- Remove experimental property from Icon block (WordPress/gutenberg#75742)
- Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740)
- Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709)
- Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752)
- Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758)
- Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751)
- Query: Remove content role from block (WordPress/gutenberg#75760)
- `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737)
- Icon-block: fix global-styles selectors (WordPress/gutenberg#75724)
- RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708)
- Core Data: Create icons entity (WordPress/gutenberg#75773)


git-svn-id: https://develop.svn.wordpress.org/trunk@61705 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Feb 20, 2026
CI run: WordPress/wordpress-develop#10988.

See #64595.

---

I've included a log of the Gutenberg changes with the following command:

```
git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy
```

- Remove experimental property from Icon block (WordPress/gutenberg#75742)
- Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740)
- Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709)
- Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752)
- Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758)
- Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751)
- Query: Remove content role from block (WordPress/gutenberg#75760)
- `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737)
- Icon-block: fix global-styles selectors (WordPress/gutenberg#75724)
- RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708)
- Core Data: Create icons entity (WordPress/gutenberg#75773)

Built from https://develop.svn.wordpress.org/trunk@61705


git-svn-id: http://core.svn.wordpress.org/trunk@61013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
ockham pushed a commit that referenced this pull request Feb 23, 2026
Co-authored-by: chriszarate <czarate@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>
@ockham
Copy link
Contributor

ockham commented Feb 23, 2026

I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: c1219ed

@ockham ockham removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Feb 23, 2026
scruffian pushed a commit that referenced this pull request Feb 23, 2026
Co-authored-by: chriszarate <czarate@git.wordpress.org>
Co-authored-by: ingeniumed <ingeniumed@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants