Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2481a43 to
87e2f44
Compare
|
Just clarifying (sorry didn't have the time to test this locally.) With this change is it still possible to change all of the query parameters such as filters etc of the query block even when it is deeply nested inside a pattern? Because I thought that was why the contentRole was added to this block in the first place. |
87e2f44 to
f563fed
Compare
Do you have a link to a PR or issue that discusses that? It didn't show those controls before and it doesn't after. |
|
Flaky tests detected in f563fed. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22214432500
|
|
@talldan okay I did some more digging. This actually is not working like I remembered in 6.9 when you use CleanShot.2026-02-20.at.08.16.16.mp4I realize this is not the core experience and so it makes sense to iterate on it. I guess I just got lucky that the current state of it with the contentRole added does make this exact use case possible. It does mean however that I think we should look at finding a way to make the query block selectable in the contentOnly mode regardless because like I said before, the query properties are content. |
|
But does the "change design" also still appear when the query is nested in a larger pattern? Right now the testing examples all seem to only show it when the query is the top level pattern block 🤔 Because that is why the role was actually added in the first place: #71686 |
|
@fabiankaegy It doesn't do that in trunk either: I'd suggest making an issue if it's a bug. |
I really need to know where this was discussed and implemented. None of the attributes have a I'll move ahead and merge the PR, because it doesn't seem to regress anything in trunk and it does fix an issue. If there are further query block bugs, lets track them in issues and aim to get them fixed for 7.0. 👍 |
Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: ed9fbde |
CI run: #10988. See #64595. --- I've included a log of the Gutenberg changes with the following command: ``` git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy ``` - Remove experimental property from Icon block (WordPress/gutenberg#75742) - Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740) - Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709) - Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752) - Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758) - Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751) - Query: Remove content role from block (WordPress/gutenberg#75760) - `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737) - Icon-block: fix global-styles selectors (WordPress/gutenberg#75724) - RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708) - Core Data: Create icons entity (WordPress/gutenberg#75773) git-svn-id: https://develop.svn.wordpress.org/trunk@61705 602fd350-edb4-49c9-b593-d223f7449a82
CI run: WordPress/wordpress-develop#10988. See #64595. --- I've included a log of the Gutenberg changes with the following command: ``` git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy ``` - Remove experimental property from Icon block (WordPress/gutenberg#75742) - Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740) - Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709) - Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752) - Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758) - Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751) - Query: Remove content role from block (WordPress/gutenberg#75760) - `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737) - Icon-block: fix global-styles selectors (WordPress/gutenberg#75724) - RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708) - Core Data: Create icons entity (WordPress/gutenberg#75773) Built from https://develop.svn.wordpress.org/trunk@61705 git-svn-id: http://core.svn.wordpress.org/trunk@61013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
|
I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: ae22a41 |
Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>




What?
Fixes an issue for the Query block where in patterns it allowed content to be inserted at the root of a query block.
Why?
The query block has a very specific internal structure with Post Template, No Results and Pagination, so allowing content blocks to be inserted in ContentOnly mode at the root level doesn't really work so well.
When used in a pattern the block prioritises allowing the user to switch between different patterns instead, which continues to work in this PR.
For deeper changes the user can 'Edit pattern' or detach/disconnect, which is still available after this change.
How?
Remove
contentRole: trueproperty from block supportsTesting Instructions
+appender at the end of the pattern in this PR, while there is in trunkScreenshots
Before
(with the query pattern selected, there's an appender that allows adding blocks at the root of a query)
After
(no appender with the query pattern selected)