Vips and worker-threads packages: remove private flag so that packages can be published to npm#75752
Conversation
…s can be published to npm
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jakebailey. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 6.84 MB ℹ️ View Unchanged
|
ramonjd
left a comment
There was a problem hiding this comment.
I guess the only way to really test is to merge?
Thanks for taking a quick look! Yes, I believe that's the case. The e2es failing on this PR are the same that are failing on all PRs right now. Given that this PR is required in order to unblock publishing packages (and the issue flagged in #75718) I'm going to merge without waiting for requirements to be met. |
|
I think we also need to update this line to use a relative path. Line 63 in 5cca19c |
Dang, good catch. I'll throw up a quick PR. |
…s can be published to npm (#75752) * Vips and worker-threads packages: remove private flag so that packages can be published to npm * Update docs Unlinked contributors: jakebailey. Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: up1512001 <up1512001@git.wordpress.org> Co-authored-by: joshualip-plaudit <joshualipstone@git.wordpress.org> Co-authored-by: Hug0-Drelon <hugod@git.wordpress.org>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 95a8df1 |
CI run: #10988. See #64595. --- I've included a log of the Gutenberg changes with the following command: ``` git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy ``` - Remove experimental property from Icon block (WordPress/gutenberg#75742) - Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740) - Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709) - Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752) - Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758) - Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751) - Query: Remove content role from block (WordPress/gutenberg#75760) - `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737) - Icon-block: fix global-styles selectors (WordPress/gutenberg#75724) - RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708) - Core Data: Create icons entity (WordPress/gutenberg#75773) git-svn-id: https://develop.svn.wordpress.org/trunk@61705 602fd350-edb4-49c9-b593-d223f7449a82
CI run: WordPress/wordpress-develop#10988. See #64595. --- I've included a log of the Gutenberg changes with the following command: ``` git log --reverse --format="- %s" b441348bb7e05af351c250b74283f253acaf9138..23b566c72e9c4a36219ef5d6e62890f05551f6cb | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy ``` - Remove experimental property from Icon block (WordPress/gutenberg#75742) - Real-time collab editing: Fix undo E2E test (WordPress/gutenberg#75740) - Snackbar: Fix scaling issue with snackbars that update their content via a common id (WordPress/gutenberg#75709) - Vips and worker-threads packages: remove private flag so that packages can be published to npm (WordPress/gutenberg#75752) - Update wordpress/vips in root package.json to use a relative path (WordPress/gutenberg#75758) - Fix change-detection and new-post E2E tests after RTC enabled by default (WordPress/gutenberg#75751) - Query: Remove content role from block (WordPress/gutenberg#75760) - `ToggleGroupControl`: Make unselected item color consistent across all variants (WordPress/gutenberg#75737) - Icon-block: fix global-styles selectors (WordPress/gutenberg#75724) - RTC: Add cap check for single taxonomy term entities (WordPress/gutenberg#75708) - Core Data: Create icons entity (WordPress/gutenberg#75773) Built from https://develop.svn.wordpress.org/trunk@61705 git-svn-id: http://core.svn.wordpress.org/trunk@61013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
Guys, how long would it take to publish hotfix or new version to NPM? Our production sites with |
…s can be published to npm (#75752) * Vips and worker-threads packages: remove private flag so that packages can be published to npm * Update docs Unlinked contributors: jakebailey. Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: up1512001 <up1512001@git.wordpress.org> Co-authored-by: joshualip-plaudit <joshualipstone@git.wordpress.org> Co-authored-by: Hug0-Drelon <hugod@git.wordpress.org>
|
I just cherry-picked this PR to the release/22.6 branch to get it included in the next release: d17a37e |
…s can be published to npm (#75752) * Vips and worker-threads packages: remove private flag so that packages can be published to npm * Update docs Unlinked contributors: jakebailey. Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: up1512001 <up1512001@git.wordpress.org> Co-authored-by: joshualip-plaudit <joshualipstone@git.wordpress.org> Co-authored-by: Hug0-Drelon <hugod@git.wordpress.org>
|
I just cherry-picked this PR to the wp/latest branch to get it included in the next release of npm packages: 8420cc9 |
|
@NumberOneBot This should be fixed now, per #75718 (comment). Can you try and see if it works for you? |
|
@ockham Yes, it works now, thanks. |
|
Thank you so much, it works! |
…s can be published to npm (#75752) * Vips and worker-threads packages: remove private flag so that packages can be published to npm * Update docs Unlinked contributors: jakebailey. Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: up1512001 <up1512001@git.wordpress.org> Co-authored-by: joshualip-plaudit <joshualipstone@git.wordpress.org> Co-authored-by: Hug0-Drelon <hugod@git.wordpress.org>
What? Why? How?
Hopefully fixes #75718
The
@wordpress/vipsand@wordpress/worker-threadspackages aren't available on npm, which appears to be the cause of failures reported in #75718.In order to allow these packages to be installed, remove the
privateflag for these packages. This should hopefully unblock publishing to npm, and then once published, 🤞 #75718 should be resolved.Testing Instructions
Shouldn't change anything in Gutenberg, but if you'd like, smoke test that uploading media in Gutenberg works as expected.