ToggleGroupControl: add visual emphasis to selected item #75138
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -10 B (0%) Total Size: 3 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
feat/toggle-group-control-polish
branch
from
0c52227 to
e10d05c
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
changed the title
Member
|
Is there any discussion or context to share with this? Noting since the design was the subject of much discussion in #74036. Though personally, to my untrained eye this feels like an improvement, as the "Before" as introduced in #74036 was quite subtle and perhaps an overcorrection from the earlier design. |
Contributor
Author
It was discussed with folks from @WordPress/gutenberg-design , although I don't believe there is a dedicated issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tweak the background color of the selected item in the
ToggleGroupControlcomponentWhy?
Add visual emphasis to the selected item
How?
Changed the background color from white to
gray-100Testing Instructions
Screenshots or screencast