fix: NetworkList to call INetworkSerializable's NetworkSerialize() method properly #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
changed the title
|
This PR can't be merged until 59e8874 is backported into develop, as it depends on code from that commit. |
0xFA11
reviewed
Feb 14, 2022
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed: NetworkList now properly calls INetworkSerializable's NetworkSerialize() method (#1682) |
There was a problem hiding this comment.
Suggested change
| - Fixed: NetworkList now properly calls INetworkSerializable's NetworkSerialize() method (#1682) | |
| - Fixed NetworkList to call INetworkSerializable's NetworkSerialize() method properly (#1682) |
0xFA11
changed the title
0xFA11
approved these changes
Feb 14, 2022
|
#1487 for tracking |
0xFA11
force-pushed
the
fix/INetworkSerializable_in_NetworkList_develop
branch
from
26b4f35 to
0af4957
Compare
0xFA11
force-pushed
the
fix/INetworkSerializable_in_NetworkList_develop
branch
from
4a9caa0 to
b8f1de8
Compare
WhippetsAintDogs
added a commit
to fikaproductions/multiplayer-community-contributions
that referenced
this pull request
Apr 12, 2022
…e() method properly Analogous to Unity-Technologies/com.unity.netcode.gameobjects#1682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-1687
#1396
Changelog
com.unity.netcode.gameobjects
Testing and Documentation