fix: Fixed an exception when EnsureNetworkVariableLengthSafety is enabled #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
changed the title
0xFA11
reviewed
Dec 6, 2021
com.unity.netcode.gameobjects/Runtime/Messaging/Messages/NetworkVariableDeltaMessage.cs
Outdated
Show resolved
Hide resolved
0xFA11
approved these changes
Dec 6, 2021
…rkVariableDeltaMessage.cs Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
…ety_enabled # Conflicts: # com.unity.netcode.gameobjects/CHANGELOG.md
…ength_safety_enabled' into fix/error_when_networkvariable_length_safety_enabled
ShadauxCat
deleted the
fix/error_when_networkvariable_length_safety_enabled
branch
ShadauxCat
requested review from
NoelStephensUnity,
alex-gubernsky and
0xFA11
and removed request for
alex-gubernsky,
mattwalsh-unity,
NoelStephensUnity and
0xFA11
|
Sorry to those who just got added to this already closed review by my cat walking on my keyboard. |
|
apparently, #1653 got this backported to develop already. |
0xFA11
added
stat:backported-release-1.0.0
and removed
type:backport-release-1.0.0
labels
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…bled (Unity-Technologies#1487) * Fix: Fixed an exception when EnsureNetworkVariableLengthSafety is enabled * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-1845
fixes #1428
Changelog
com.unity.netcode.gameobjects
Testing and Documentation