fix: Unity.Netcode.RuntimeTests Failing on Console - v1.1.0 #1653

NoelStephensUnity · 2022-02-04T03:52:33Z

This should fix the issues when running Unity.Netcode.RuntimeTests in a stand alone test runner build. These changes should get all console platforms passing for this assembly.
MTT-2288

These updates are based off of #1628 but required additional changes.

Testing and Documentation

No tests have been added.
No documentation changes or additions were necessary.

commit 36c52d7 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 22:39:30 2022 -0600 style arrg!!!!!! white space commit 861ef54 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 19:51:09 2022 -0600 fix and update fixed issue with WhenListContainsManyLargeValues_OverflowExceptionIsNotThrown count comparison value. Updated removed FixedString32Test by removing yield return that was not needed. commit 3e70580 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 19:41:57 2022 -0600 update Reviewing the updated methods and making some minor adjustments. commit ba3e09d Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 19:19:15 2022 -0600 style removing a using statement for a namespace that was not being used. commit 3088309 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 19:16:51 2022 -0600 fix The AllNetworkVariableTypes was not properly creating the NetworkManager based on the value of useHost commit 0f9d8ca Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 18:56:08 2022 -0600 update removing more MultiInstanceHelpers.Run calls commit 38ec0fe Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 18:48:47 2022 -0600 update removing MultiInstanceHelpers.Run calls from NetworkTransform as they are not needed. commit f8fd60c Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 18:32:53 2022 -0600 test update and style removing some of the Run calls and beginning to convert over some of the problematic tests to just yield return the conditional check itself to avoid potential timing issues when checking the condition and yielding to the current test group's newly created coroutine. commit 71a4d4e Merge: 994d459 27e8498 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 17:56:21 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit 994d459 Merge: 35b47a5 74df5b2 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 17:29:17 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit 35b47a5 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Wed Feb 2 17:29:07 2022 -0600 test refactor This update collapses all of the time out code into the BaseMultiInstanceTest with an added method WaitForConditionOrTimeOut that leverages from an added TimeOutHelper class. commit 73340d6 Merge: feb9e47 096f614 Author: Noel Stephens <noel.stephens@unity3d.com> Date: Wed Feb 2 02:59:21 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit feb9e47 Merge: a66d4f3 e07450f Author: Noel Stephens <noel.stephens@unity3d.com> Date: Tue Feb 1 16:14:06 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit a66d4f3 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Tue Feb 1 16:13:53 2022 -0600 style removing whitespace. commit 02e4681 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Tue Feb 1 13:50:30 2022 -0600 style making sure NetworkTransform was exactly as it was before, removing a LF/CR commit 33e6601 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Tue Feb 1 13:49:13 2022 -0600 refactor Came up with what I hope is a much better fix to get NetworkTransformTests passing on all consoles. Passes on a windows stand alone test runner build...will need to run this on the consoles to verify the fix. commit 91d8f31 Merge: 72d3d49 ef257a9 Author: Noel Stephens <noel.stephens@unity3d.com> Date: Tue Feb 1 09:29:42 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit 72d3d49 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Mon Jan 31 12:46:02 2022 -0600 refactor removing the timeout code to reduce confusion on the changes to NetworkVariableTests. commit 82d243f Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Mon Jan 31 11:38:44 2022 -0600 revert re-applying readonly to the m_TestWithClientNetworkTransform and m_TestWithHost properties as that was changed during troubleshooting. commit 3a90687 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Mon Jan 31 11:34:56 2022 -0600 refactor moving the HasTimedOut check to the end of each while loop to assure that any possible edge case scenario where it finishes just as it would be timing out is not missed. An example would be the condition being checked is validated but it lands right on the timeout period. The test would have been a success, but timedOut would have been set too. commit 71ae813 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Mon Jan 31 11:23:24 2022 -0600 refactor using the bool as opposed to direct method call for the while loops. commit 96b62b4 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Mon Jan 31 10:37:07 2022 -0600 update Applied suggestion by Fatih to use deltaTime with normal Update selected and fixedDeltaTime for FixedUpdate selected. commit 90b9ed9 Merge: d509fca c17f5b8 Author: Noel Stephens <noel.stephens@unity3d.com> Date: Sat Jan 29 15:09:31 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit d509fca Merge: 8244627 58f194d Author: Noel Stephens <noel.stephens@unity3d.com> Date: Fri Jan 28 17:17:15 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit 8244627 Merge: 43e9382 402210e Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Fri Jan 28 13:18:33 2022 -0600 Merge branch 'fix/console-tests-failing' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/console-tests-failing commit 43e9382 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Fri Jan 28 13:18:12 2022 -0600 update Removing the auto-assignment of the NetworkTransformTests's constructor's properties that were left over from troubleshooting. commit 402210e Merge: 554bf0d e4108e5 Author: Noel Stephens <noel.stephens@unity3d.com> Date: Fri Jan 28 13:14:11 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit 554bf0d Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Fri Jan 28 09:06:52 2022 -0600 style removing a portion of the comment as it was a copy-paste of code used in other fixes. commit 7766f27 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Fri Jan 28 02:37:06 2022 -0600 fix delta read was failing. commit 041e10d Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Fri Jan 28 01:39:59 2022 -0600 fix This includes updates to the NetworkObjectOnSpawnTests in order to get it passing in stand alone test runner builds in order to get it to pass on consoles. commit 26d2335 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Fri Jan 28 01:16:37 2022 -0600 style white space missing. commit 5b6146a Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Fri Jan 28 01:16:08 2022 -0600 fix This includes the fixes for getting NetworkVarBufferCopyTest to run on a stand alone test runner build. commit 0e4435b Merge: 9628212 5032214 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Thu Jan 27 20:41:58 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit 9628212 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Thu Jan 27 20:41:44 2022 -0600 style Removed unused using statement. commit c022e08 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Thu Jan 27 20:15:02 2022 -0600 fix - partial This is a "quasi-fix" where I had to add the ability to run NetworkTransform in the FixedUpdate in order to get the NetworkTransform tests all passing when running in a stand alone test runner build. commit ae1c750 Merge: 859d88c 1704918 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Thu Jan 27 14:50:38 2022 -0600 Merge branch 'develop' into fix/console-tests-failing commit 859d88c Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Thu Jan 27 14:45:56 2022 -0600 style Just added some additional comments. commit 4b40c04 Author: NoelStephensUnity <73188597+NoelStephensUnity@users.noreply.github.com> Date: Thu Jan 27 14:31:20 2022 -0600 fix This should fix the timing issues on consoles for the NetworkVariableTests.

Fixes and minor modifications due to some differences between develop and v1.1.0

weird merge issue fix

fixing a few more tests that failed on some of the console platforms.

Still running into timing issues during transport tests. Bumped the wait up to 2s and had to adjust FilledSendQueueMultipleSends to wait for the packet to be received before proceeding to send the next (this could probably be handled better but just putting a place holder fix in place for transport issues so I can confirm this the NGO runtime tests are all passing and for desktop server to see what I had to do to get it passing on some of the platforms under v1.1.0). Also had to update the rest of the NetworkVariable tests to use the newer WaitForConditionOrTimeOut method.

Putting System.Linq reference back as even though it shows it is not used...it is.

Realized the fixes for this were not backported to v1.0.0. This is a temporary back port for my branch to get past the SendMaximumPayloadSize failures

This fixes the issue with the standards checking of data.ToArray().

Finally looked at the very top of the TransportTests and realized they should be disabled for consoles.

fixes a mistake I made in the IndexOf test

indent

Added the ConditionalPredicateBase implementation of the IConditionalPredicate and implemented an overloaded version of WaitForConditionOrTimeOut. Changed the original WaitForConditionOrTimeOut to just return true as all use cases of these UnityTest attribute decorated methods had access to the values and were relatively simple conditions. I used the NetworkVariableTests as an example of how to use the a ConditionalPredicateBase derived class to simplify the scenario where you might be re-using the same code or conditional checks in many integration tests.

Condensed the overloaded version of WaitForConditionOrTimeOut that accepts an IConditionalPredicate implementation. Updates and added comments.

Migrating a fix for and issue that was seen when testing both test project and runtime tests together. The update takes into consideration the rounding error that can occur when calculating tick from time (which was an earlier fix for the tick system).

Noticed on short was not switched to ushort.

NoelStephensUnity · 2022-02-07T18:26:59Z

com.unity.netcode.gameobjects/Runtime/Messaging/Messages/NetworkVariableDeltaMessage.cs

@@ -69,7 +69,12 @@ public void Serialize(FastBufferWriter writer)
                        var tmpWriter = new FastBufferWriter(MessagingSystem.NON_FRAGMENTED_MESSAGE_MAX_SIZE, Allocator.Temp, short.MaxValue);
                        NetworkBehaviour.NetworkVariableFields[k].WriteDelta(tmpWriter);

-                        writer.WriteValueSafe((ushort)tmpWriter.Length);
+                        if (!writer.TryBeginWrite(FastBufferWriter.GetWriteSize<ushort>() + tmpWriter.Length))


While this does not fix the issue with NetworkLists that exceed the MessagingSystem.NON_FRAGMENTED_MESSAGE_MAX_SIZE, I put this in place as it was missed in the back port.
This will not actually fix the issue until MTT-2434 is resolved but should handle this particular issue within NetworkVariableDeltaMessage.

com.unity.netcode.adapter.utp/Tests/Runtime/TransportTests.cs

NoelStephensUnity · 2022-02-07T18:30:36Z

com.unity.netcode.adapter.utp/Tests/Runtime/Helpers/RuntimeTestsHelpers.cs

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
-
 namespace Unity.Netcode.UTP.RuntimeTests


All of these changes are part of a backport, approved by Simon

NoelStephensUnity · 2022-02-07T18:33:10Z

com.unity.netcode.gameobjects/Tests/Runtime/BaseMultiInstanceTest.cs

+        //    return true;
+        //}
+
+        /// <summary>


All of this section (above and below) will be resolved when MTT-2429 is complete.

…l-console-platforms-v1.1.0

…ole-platforms-v1.1.0

Rosme

LGTM

…ole-platforms-v1.1.0

NoelStephensUnity added 9 commits February 3, 2022 18:44

fix and merge updates

5c040a6

Fixes and minor modifications due to some differences between develop and v1.1.0

update

5bffb1c

weird merge issue fix

test fix

06f518c

fixing a few more tests that failed on some of the console platforms.

refactor

22a9588

Putting System.Linq reference back as even though it shows it is not used...it is.

temp backport of #1638

356b1b8

Realized the fixes for this were not backported to v1.0.0. This is a temporary back port for my branch to get past the SendMaximumPayloadSize failures

test backport temp

10ea0e6

This fixes the issue with the standards checking of data.ToArray().

test full backport of TransportTests

b6d44ec

Finally looked at the very top of the TransportTests and realized they should be disabled for consoles.

This was referenced Feb 5, 2022

fix: Clear adapter send queues on client disconnection #1649

Merged

fix: TestProject.RuntimeTests do not run in stand alone test runner builds and fail on consoles - v1.1.0 #1655

Closed

NoelStephensUnity and others added 3 commits February 5, 2022 16:02

fix

80fc011

fixes a mistake I made in the IndexOf test

style

b06cc5c

indent

simon-lemay-unity approved these changes Feb 7, 2022

View reviewed changes

update and style

900e96b

Condensed the overloaded version of WaitForConditionOrTimeOut that accepts an IConditionalPredicate implementation. Updates and added comments.

NoelStephensUnity marked this pull request as ready for review February 7, 2022 17:20

NoelStephensUnity added 2 commits February 7, 2022 11:33

update

cd31bc8

Migrating a fix for and issue that was seen when testing both test project and runtime tests together. The update takes into consideration the rounding error that can occur when calculating tick from time (which was an earlier fix for the tick system).

fix

8d7fb9d

Noticed on short was not switched to ushort.

NoelStephensUnity commented Feb 7, 2022

View reviewed changes

com.unity.netcode.adapter.utp/Tests/Runtime/TransportTests.cs Show resolved Hide resolved

NoelStephensUnity commented Feb 7, 2022

View reviewed changes

Merge branch 'release/1.1.0' into fix/runtime-tests-not-passing-on-al…

e0e8b48

…l-console-platforms-v1.1.0

NoelStephensUnity mentioned this pull request Feb 8, 2022

fix: testproject runtimetests fails on console platforms v1.1.0 #1664

Merged

NoelStephensUnity requested a review from 0xFA11 February 8, 2022 16:21

Merge branch 'release/1.1.0' into fix/runtime-tests-not-passing-on-al…

1905b6f

…l-console-platforms-v1.1.0

NoelStephensUnity requested a review from SamuelBellomo February 10, 2022 15:11

Merge branch 'develop' into fix/runtime-tests-not-passing-on-all-cons…

ed0c17f

…ole-platforms-v1.1.0

NoelStephensUnity requested a review from TwoTenPvP February 10, 2022 15:33

NoelStephensUnity requested a review from LukeStampfli February 10, 2022 15:33

Merge branch 'develop' into fix/runtime-tests-not-passing-on-all-cons…

bde1e90

…ole-platforms-v1.1.0

Rosme approved these changes Feb 10, 2022

View reviewed changes

NoelStephensUnity added 2 commits February 10, 2022 14:47

Merge branch 'develop' into fix/runtime-tests-not-passing-on-all-cons…

73ee4fb

…ole-platforms-v1.1.0

Merge branch 'develop' into fix/runtime-tests-not-passing-on-all-cons…

f6b693f

…ole-platforms-v1.1.0

NoelStephensUnity enabled auto-merge (squash) February 10, 2022 21:05

NoelStephensUnity merged commit 0b23d7b into develop Feb 10, 2022

NoelStephensUnity deleted the fix/runtime-tests-not-passing-on-all-console-platforms-v1.1.0 branch February 10, 2022 21:20

NoelStephensUnity mentioned this pull request Feb 12, 2022

fix: unet removed from unity trunk v1.0.0 #1684

Merged

NoelStephensUnity added type:backport-release-1.0.0 and removed type:backport-release-1.0.0 labels Feb 12, 2022

This was referenced Feb 17, 2022

fix: Fixed an exception when EnsureNetworkVariableLengthSafety is enabled #1487

Merged

fix: NetworkList to call INetworkSerializable's NetworkSerialize() method properly #1682

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Unity.Netcode.RuntimeTests Failing on Console - v1.1.0 #1653

fix: Unity.Netcode.RuntimeTests Failing on Console - v1.1.0 #1653

Uh oh!

NoelStephensUnity commented Feb 4, 2022 •

edited

Loading

Uh oh!

NoelStephensUnity Feb 7, 2022

Uh oh!

Uh oh!

NoelStephensUnity Feb 7, 2022

Uh oh!

NoelStephensUnity Feb 7, 2022

Uh oh!

Rosme left a comment

Uh oh!

Uh oh!

fix: Unity.Netcode.RuntimeTests Failing on Console - v1.1.0 #1653

fix: Unity.Netcode.RuntimeTests Failing on Console - v1.1.0 #1653

Uh oh!

Conversation

NoelStephensUnity commented Feb 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing and Documentation

Uh oh!

NoelStephensUnity Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NoelStephensUnity Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

NoelStephensUnity Feb 7, 2022

Choose a reason for hiding this comment

Uh oh!

Rosme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NoelStephensUnity commented Feb 4, 2022 •

edited

Loading