fix: Unity.Netcode.RuntimeTests Failing on Console #1628

NoelStephensUnity · 2022-01-27T20:46:13Z

This should fix the issues when running Unity.Netcode.RuntimeTests in a stand alone test runner build. These changes should get all console platforms passing for this assembly.
MTT-2288

With the fixes in place all consoles are passing Unity.Netcode.RuntimeTests:

Testing and Documentation

No tests have been added.
No documentation changes or additions were necessary.

This should fix the timing issues on consoles for the NetworkVariableTests.

Just added some additional comments.

This is a "quasi-fix" where I had to add the ability to run NetworkTransform in the FixedUpdate in order to get the NetworkTransform tests all passing when running in a stand alone test runner build.

Removed unused using statement.

This includes the fixes for getting NetworkVarBufferCopyTest to run on a stand alone test runner build.

white space missing.

This includes updates to the NetworkObjectOnSpawnTests in order to get it passing in stand alone test runner builds in order to get it to pass on consoles.

delta read was failing.

com.unity.netcode.gameobjects/Components/NetworkTransform.cs

removing a portion of the comment as it was a copy-paste of code used in other fixes.

Removing the auto-assignment of the NetworkTransformTests's constructor's properties that were left over from troubleshooting.

…Technologies/com.unity.netcode.gameobjects into fix/console-tests-failing

Applied suggestion by Fatih to use deltaTime with normal Update selected and fixedDeltaTime for FixedUpdate selected.

using the bool as opposed to direct method call for the while loops.

moving the HasTimedOut check to the end of each while loop to assure that any possible edge case scenario where it finishes just as it would be timing out is not missed. An example would be the condition being checked is validated but it lands right on the timeout period. The test would have been a success, but timedOut would have been set too.

re-applying readonly to the m_TestWithClientNetworkTransform and m_TestWithHost properties as that was changed during troubleshooting.

removing the timeout code to reduce confusion on the changes to NetworkVariableTests.

Came up with what I hope is a much better fix to get NetworkTransformTests passing on all consoles. Passes on a windows stand alone test runner build...will need to run this on the consoles to verify the fix.

making sure NetworkTransform was exactly as it was before, removing a LF/CR

removing whitespace.

This update collapses all of the time out code into the BaseMultiInstanceTest with an added method WaitForConditionOrTimeOut that leverages from an added TimeOutHelper class.

removing some of the Run calls and beginning to convert over some of the problematic tests to just yield return the conditional check itself to avoid potential timing issues when checking the condition and yielding to the current test group's newly created coroutine.

removing MultiInstanceHelpers.Run calls from NetworkTransform as they are not needed.

removing more MultiInstanceHelpers.Run calls

The AllNetworkVariableTypes was not properly creating the NetworkManager based on the value of useHost

removing a using statement for a namespace that was not being used.

Reviewing the updated methods and making some minor adjustments.

fixed issue with WhenListContainsManyLargeValues_OverflowExceptionIsNotThrown count comparison value. Updated removed FixedString32Test by removing yield return that was not needed.

arrg!!!!!! white space

this fixes an issue I discovered in the IndexOf test.

NoelStephensUnity added 10 commits January 27, 2022 14:31

fix

4b40c04

This should fix the timing issues on consoles for the NetworkVariableTests.

style

859d88c

Just added some additional comments.

Merge branch 'develop' into fix/console-tests-failing

ae1c750

fix - partial

c022e08

This is a "quasi-fix" where I had to add the ability to run NetworkTransform in the FixedUpdate in order to get the NetworkTransform tests all passing when running in a stand alone test runner build.

style

9628212

Removed unused using statement.

Merge branch 'develop' into fix/console-tests-failing

0e4435b

fix

5b6146a

This includes the fixes for getting NetworkVarBufferCopyTest to run on a stand alone test runner build.

style

26d2335

white space missing.

fix

041e10d

This includes updates to the NetworkObjectOnSpawnTests in order to get it passing in stand alone test runner builds in order to get it to pass on consoles.

fix

7766f27

delta read was failing.

NoelStephensUnity requested review from SamuelBellomo and mattwalsh-unity January 28, 2022 10:20

NoelStephensUnity marked this pull request as ready for review January 28, 2022 10:22

Cosmin-B reviewed Jan 28, 2022

View reviewed changes

com.unity.netcode.gameobjects/Components/NetworkTransform.cs Outdated Show resolved Hide resolved

NoelStephensUnity and others added 6 commits January 28, 2022 09:06

style

554bf0d

removing a portion of the comment as it was a copy-paste of code used in other fixes.

Merge branch 'develop' into fix/console-tests-failing

402210e

update

43e9382

Removing the auto-assignment of the NetworkTransformTests's constructor's properties that were left over from troubleshooting.

Merge branch 'fix/console-tests-failing' of https://github.com/Unity-…

8244627

…Technologies/com.unity.netcode.gameobjects into fix/console-tests-failing

Merge branch 'develop' into fix/console-tests-failing

d509fca

Merge branch 'develop' into fix/console-tests-failing

90b9ed9

NoelStephensUnity requested a review from JesseOlmer January 30, 2022 00:32

0xFA11 self-requested a review January 31, 2022 16:14

NoelStephensUnity added 5 commits January 31, 2022 10:37

update

96b62b4

Applied suggestion by Fatih to use deltaTime with normal Update selected and fixedDeltaTime for FixedUpdate selected.

refactor

71ae813

using the bool as opposed to direct method call for the while loops.

revert

82d243f

re-applying readonly to the m_TestWithClientNetworkTransform and m_TestWithHost properties as that was changed during troubleshooting.

refactor

72d3d49

removing the timeout code to reduce confusion on the changes to NetworkVariableTests.

0xFA11 removed their request for review January 31, 2022 22:01

NoelStephensUnity and others added 2 commits February 1, 2022 09:29

Merge branch 'develop' into fix/console-tests-failing

91d8f31

refactor

33e6601

Came up with what I hope is a much better fix to get NetworkTransformTests passing on all consoles. Passes on a windows stand alone test runner build...will need to run this on the consoles to verify the fix.

style

02e4681

making sure NetworkTransform was exactly as it was before, removing a LF/CR

NoelStephensUnity requested review from Cosmin-B and jeffreyrainy February 1, 2022 20:12

NoelStephensUnity and others added 14 commits February 1, 2022 16:13

style

a66d4f3

removing whitespace.

Merge branch 'develop' into fix/console-tests-failing

feb9e47

Merge branch 'develop' into fix/console-tests-failing

73340d6

test refactor

35b47a5

This update collapses all of the time out code into the BaseMultiInstanceTest with an added method WaitForConditionOrTimeOut that leverages from an added TimeOutHelper class.

Merge branch 'develop' into fix/console-tests-failing

994d459

Merge branch 'develop' into fix/console-tests-failing

71a4d4e

update

38ec0fe

removing MultiInstanceHelpers.Run calls from NetworkTransform as they are not needed.

update

0f9d8ca

removing more MultiInstanceHelpers.Run calls

fix

3088309

The AllNetworkVariableTypes was not properly creating the NetworkManager based on the value of useHost

style

ba3e09d

removing a using statement for a namespace that was not being used.

update

3e70580

Reviewing the updated methods and making some minor adjustments.

fix and update

861ef54

fixed issue with WhenListContainsManyLargeValues_OverflowExceptionIsNotThrown count comparison value. Updated removed FixedString32Test by removing yield return that was not needed.

style

36c52d7

arrg!!!!!! white space

NoelStephensUnity changed the base branch from develop to release/1.1.0 February 3, 2022 17:45

NoelStephensUnity requested a review from a team as a code owner February 3, 2022 17:45

NoelStephensUnity changed the base branch from release/1.1.0 to develop February 3, 2022 17:50

NoelStephensUnity marked this pull request as draft February 3, 2022 17:57

NoelStephensUnity mentioned this pull request Feb 3, 2022

test: all runtime tests passing on consoles #1647

Closed

NoelStephensUnity changed the title ~~fix: console tests failing~~ fix: Unity.Netcode.RuntimeTests Failing on Console Feb 3, 2022

NoelStephensUnity mentioned this pull request Feb 4, 2022

fix: Unity.Netcode.RuntimeTests Failing on Console - v1.1.0 #1653

Merged

fix

3350c2d

this fixes an issue I discovered in the IndexOf test.

NoelStephensUnity closed this Feb 10, 2022

NoelStephensUnity deleted the fix/console-tests-failing branch March 22, 2022 22:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Unity.Netcode.RuntimeTests Failing on Console #1628

fix: Unity.Netcode.RuntimeTests Failing on Console #1628

Uh oh!

NoelStephensUnity commented Jan 27, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix: Unity.Netcode.RuntimeTests Failing on Console #1628

fix: Unity.Netcode.RuntimeTests Failing on Console #1628

Uh oh!

Conversation

NoelStephensUnity commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing and Documentation

Uh oh!

Uh oh!

Uh oh!

NoelStephensUnity commented Jan 27, 2022 •

edited

Loading