Skip to content

fix: Unity.Netcode.RuntimeTests Failing on Console #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
4b40c04
fix
NoelStephensUnity Jan 27, 2022
859d88c
style
NoelStephensUnity Jan 27, 2022
ae1c750
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Jan 27, 2022
c022e08
fix - partial
NoelStephensUnity Jan 28, 2022
9628212
style
NoelStephensUnity Jan 28, 2022
0e4435b
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Jan 28, 2022
5b6146a
fix
NoelStephensUnity Jan 28, 2022
26d2335
style
NoelStephensUnity Jan 28, 2022
041e10d
fix
NoelStephensUnity Jan 28, 2022
7766f27
fix
NoelStephensUnity Jan 28, 2022
554bf0d
style
NoelStephensUnity Jan 28, 2022
402210e
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Jan 28, 2022
43e9382
update
NoelStephensUnity Jan 28, 2022
8244627
Merge branch 'fix/console-tests-failing' of https://github.com/Unity-…
NoelStephensUnity Jan 28, 2022
d509fca
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Jan 28, 2022
90b9ed9
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Jan 29, 2022
96b62b4
update
NoelStephensUnity Jan 31, 2022
71ae813
refactor
NoelStephensUnity Jan 31, 2022
3a90687
refactor
NoelStephensUnity Jan 31, 2022
82d243f
revert
NoelStephensUnity Jan 31, 2022
72d3d49
refactor
NoelStephensUnity Jan 31, 2022
91d8f31
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Feb 1, 2022
33e6601
refactor
NoelStephensUnity Feb 1, 2022
02e4681
style
NoelStephensUnity Feb 1, 2022
a66d4f3
style
NoelStephensUnity Feb 1, 2022
feb9e47
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Feb 1, 2022
73340d6
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Feb 2, 2022
35b47a5
test refactor
NoelStephensUnity Feb 2, 2022
994d459
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Feb 2, 2022
71a4d4e
Merge branch 'develop' into fix/console-tests-failing
NoelStephensUnity Feb 2, 2022
f8fd60c
test update and style
NoelStephensUnity Feb 3, 2022
38ec0fe
update
NoelStephensUnity Feb 3, 2022
0f9d8ca
update
NoelStephensUnity Feb 3, 2022
3088309
fix
NoelStephensUnity Feb 3, 2022
ba3e09d
style
NoelStephensUnity Feb 3, 2022
3e70580
update
NoelStephensUnity Feb 3, 2022
861ef54
fix and update
NoelStephensUnity Feb 3, 2022
36c52d7
style
NoelStephensUnity Feb 3, 2022
3350c2d
fix
NoelStephensUnity Feb 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
The AllNetworkVariableTypes was not properly creating the NetworkManager based on the value of useHost
  • Loading branch information
NoelStephensUnity committed Feb 3, 2022
commit 3088309affb7f19ed8fcd7ca27af033e05b37dd5
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,14 @@ private IEnumerator InitializeServerAndClients(bool useHost)
[UnityTest]
public IEnumerator AllNetworkVariableTypes([Values(true, false)] bool useHost)
{
NetworkManager server;
// Create, instantiate, and host
// This would normally go in Setup, but since every other test but this one
// uses MultiInstanceHelper, and it does its own NetworkManager setup / teardown,
// for now we put this within this one test until we migrate it to MIH
Assert.IsTrue(NetworkManagerHelper.StartNetworkManager(out _));
Assert.IsTrue(NetworkManagerHelper.StartNetworkManager(out server, useHost ? NetworkManagerHelper.NetworkManagerOperatingMode.Host : NetworkManagerHelper.NetworkManagerOperatingMode.Server));

Assert.IsTrue(server.IsHost == useHost, $"{nameof(useHost)} does not match the server.IsHost value!");

Guid gameObjectId = NetworkManagerHelper.AddGameNetworkObject("NetworkVariableTestComponent");

Expand Down