Skip to content

Cleaning up FPTL early out for ps4 and PC #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2022
Merged

Cleaning up FPTL early out for ps4 and PC #6882

merged 2 commits into from
Jan 27, 2022

Conversation

kecho
Copy link
Contributor

@kecho kecho commented Jan 27, 2022 •
edited
Loading

Purpose of this PR

Early out of FPTL doing it per wave (on wave intrinsic path) and not per thread.
Slight questionable perf improvement in PS4 (which could fall around noise tbh). Seams like the compiler is already optimizing this but doing the change to just to be safe.

Testing status

  • Regressed FPTL bug (case 1386436)
  • Measured perf on ps4, improvement of 0.01 ms, which is questionable (could be just noise)
  • Code is cleaner and the intent is more readable.
  • Running yamato on console

@kecho kecho added the HDRP label Jan 27, 2022
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde merged commit b7d2cac into master Jan 27, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/CleaningFPTLEarlyOut branch January 27, 2022 15:52
sebastienlagarde added a commit that referenced this pull request Feb 1, 2022
@kecho @sebastienlagarde
Cleaning up FPTL early out for ps4 and PC (#6882)
9904c41 
* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@sebastienlagarde sebastienlagarde mentioned this pull request Feb 1, 2022
Merged
sebastienlagarde added a commit that referenced this pull request Feb 1, 2022
@sebastienlagarde @emilybrown1
@FrancescoC-unity @anisunity @JulienIgnace-Unity @kecho @alelievr @alex-vazquez @eturquin @remi-chapelain
[HDRP 21.2] Backport various PRs (#6926)
3179cc5 
* fixed typo and made style guide fixes (#6749)

* style guide fixes (#6750)

* Added menu trail to change atlas resolution (#6755)

* Clarified how to find hdrp in package manager (#6756)

* made style guide fixes (#6762)

* added new instructions for photoshop colour channels (#6769)

* made naming of AO consistent (#6771)

* Removed reference to 3d with extras project (#6781)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Added default value (#6770)

* Added default value

* Fixed merge issue

* undo wrong fix

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Merge Hd/bugfix #6791

* Fix warning on baking set renaming #6808

* Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801

* Refresh baking set scene list when one baking set is removed. #6811

* clarified how to change mode (#6871)

* fixed screenshot annotation colour (#6872)

* fixed formatting (#6873)

* fixed name of Game view (#6874)

* fixed note formatting (#6875)

* new screenshot and fixed table formatting (#6889)

* minor style guide changes (#6904)

* remove italics, note formatting (#6906)

* fixed typo "on following GPUs" > on the following GPUs (#6909)

* Post Process can now be edited in the default frame settings. #6816

* Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820

* Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822

* [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826

* Fixed an issue where forced sky update would not update ambient probe. #6831

* Fixed a null ref exception in Volume Explorer #6834

* Cleaning up FPTL early out for ps4 and PC (#6882)

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [HDRP] Fix static sky lighting update when render textures are updated #6863

* Quality update of custom post process (#6856)

* Disable the clouds in the indoor sample scenes (normal and DXR) #6908

* Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903

* Update VolumeParameter.cs

* Replaced view lighting tool with light anchor (#6829)

* Replaced view lighting tool with light anchor

* Update View-Lighting-Tool.md

* Apply formatting changes

* revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802

* [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632

* More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254

* [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901)

* Proper Indoors scene template volume

* Update 004-CloudsFlaresDecals.png

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Feb 1, 2022
@sebastienlagarde @emilybrown1
@FrancescoC-unity @anisunity @JulienIgnace-Unity @kecho @alelievr @alex-vazquez @eturquin @remi-chapelain
[HDRP 21.2] Backport various PRs (#6926)
e9dcd7a 
* fixed typo and made style guide fixes (#6749)

* style guide fixes (#6750)

* Added menu trail to change atlas resolution (#6755)

* Clarified how to find hdrp in package manager (#6756)

* made style guide fixes (#6762)

* added new instructions for photoshop colour channels (#6769)

* made naming of AO consistent (#6771)

* Removed reference to 3d with extras project (#6781)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Added default value (#6770)

* Added default value

* Fixed merge issue

* undo wrong fix

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Merge Hd/bugfix #6791

* Fix warning on baking set renaming #6808

* Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801

* Refresh baking set scene list when one baking set is removed. #6811

* clarified how to change mode (#6871)

* fixed screenshot annotation colour (#6872)

* fixed formatting (#6873)

* fixed name of Game view (#6874)

* fixed note formatting (#6875)

* new screenshot and fixed table formatting (#6889)

* minor style guide changes (#6904)

* remove italics, note formatting (#6906)

* fixed typo "on following GPUs" > on the following GPUs (#6909)

* Post Process can now be edited in the default frame settings. #6816

* Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820

* Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822

* [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826

* Fixed an issue where forced sky update would not update ambient probe. #6831

* Fixed a null ref exception in Volume Explorer #6834

* Cleaning up FPTL early out for ps4 and PC (#6882)

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [HDRP] Fix static sky lighting update when render textures are updated #6863

* Quality update of custom post process (#6856)

* Disable the clouds in the indoor sample scenes (normal and DXR) #6908

* Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903

* Update VolumeParameter.cs

* Replaced view lighting tool with light anchor (#6829)

* Replaced view lighting tool with light anchor

* Update View-Lighting-Tool.md

* Apply formatting changes

* revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802

* [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632

* More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254

* [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901)

* Proper Indoors scene template volume

* Update 004-CloudsFlaresDecals.png

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>
sebastienlagarde added a commit that referenced this pull request Feb 1, 2022
@sebastienlagarde @emilybrown1
@FrancescoC-unity @anisunity @JulienIgnace-Unity @kecho @alelievr @alex-vazquez @eturquin @remi-chapelain
[HDRP 22.1] Backport various PRs (#6946)
4356b6e 
* [HDRP 21.2] Backport various PRs (#6926)

* fixed typo and made style guide fixes (#6749)

* style guide fixes (#6750)

* Added menu trail to change atlas resolution (#6755)

* Clarified how to find hdrp in package manager (#6756)

* made style guide fixes (#6762)

* added new instructions for photoshop colour channels (#6769)

* made naming of AO consistent (#6771)

* Removed reference to 3d with extras project (#6781)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Added default value (#6770)

* Added default value

* Fixed merge issue

* undo wrong fix

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Merge Hd/bugfix #6791

* Fix warning on baking set renaming #6808

* Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801

* Refresh baking set scene list when one baking set is removed. #6811

* clarified how to change mode (#6871)

* fixed screenshot annotation colour (#6872)

* fixed formatting (#6873)

* fixed name of Game view (#6874)

* fixed note formatting (#6875)

* new screenshot and fixed table formatting (#6889)

* minor style guide changes (#6904)

* remove italics, note formatting (#6906)

* fixed typo "on following GPUs" > on the following GPUs (#6909)

* Post Process can now be edited in the default frame settings. #6816

* Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820

* Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822

* [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826

* Fixed an issue where forced sky update would not update ambient probe. #6831

* Fixed a null ref exception in Volume Explorer #6834

* Cleaning up FPTL early out for ps4 and PC (#6882)

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [HDRP] Fix static sky lighting update when render textures are updated #6863

* Quality update of custom post process (#6856)

* Disable the clouds in the indoor sample scenes (normal and DXR) #6908

* Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903

* Update VolumeParameter.cs

* Replaced view lighting tool with light anchor (#6829)

* Replaced view lighting tool with light anchor

* Update View-Lighting-Tool.md

* Apply formatting changes

* revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802

* [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632

* More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254

* [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901)

* Proper Indoors scene template volume

* Update 004-CloudsFlaresDecals.png

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>

* Fixed missing capital and UI bolding (#6876)

* [RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799

* Disabled the "Reflect Sky" feature in the case of transparent screenspace reflections for the water system. #6725

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backported-2021.2 backported-2022.1 HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kecho @sebastienlagarde