Post Process can now be edited in the default frame settings. #6816

JulienIgnace-Unity · 2022-01-24T16:42:04Z

Purpose of this PR

Post Process can now be edited in the default frame settings.
https://fogbugz.unity3d.com/f/cases/1390354/

The reason this was disabled is probably to avoid people making mistakes in the default frame settings and enable post process for reflection cameras. Given that user can still enable them in the reflection probe objects, and in order to keep things more consistency, we've decided to revert this behavior and make it editable again.
If we ever decide to prevent users from enabling post process completely for reflections then we can do it consistently everywhere.

Testing status

Tested that post process can now be enabled in the default frame settings.

* Fix AxF debug output in certain configurations. * Update comment

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…4599)" This reverts commit 2325e3f.

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…positor (#4599)"" This reverts commit 30fffd5.

… the Graphi

…ing only the RTSSS Data (case 1332904). (#4626) * Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904). * Add test scene Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

… into hd/bugfix # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

github-actions · 2022-01-24T16:42:20Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

github-actions · 2022-01-24T16:42:31Z

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

remi-chapelain

Change has already been discussed with with developper.
Completely agree with it ✔️

* fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>

* [HDRP 21.2] Backport various PRs (#6926) * fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com> * Fixed missing capital and UI bolding (#6876) * [RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799 * Disabled the "Reflect Sky" feature in the case of transparent screenspace reflections for the water system. #6725 Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>

pmavridis and others added 30 commits May 26, 2021 19:23

[HDRP] Fix AxF debug output in certain configurations (#4641)

5945333

* Fix AxF debug output in certain configurations. * Update comment

Fix SSR accumulation white flash (#4648)

64a6c13

* Fix white flash * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Display Info Box when MSAA + ray tracing is onr (#4627)

f49b710

* Show info box when ray tracing is enabled. * Changelog * Move below MSAA Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix distortion when resizing the window in player builds with the Gra…

05cc16a

…phics Compositor enabled (#4593) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Add support for the camera bridge in the graphics compositor (#4599)

2325e3f

Merge branch 'master' into hd/bugfix

c09379f

Fix Jittered Project Matrix Infinite Far Clip Plane (#4638)

b5962c9

* Reconstruct jittered projection matrix far plane (for Infinite ) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed a memory leak related to not disposing of the RTAS at the end H…

77b6b7f

…DRP's lifecycle. (#4688) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix custom pass utils Blur + Copy overdraw. (#4623)

bf941a9

* Fix overdraw in custom pass utils blur function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix draw procedural invalid pass idx 1 on first template load (#4632)

806dfbe

* Fix * changelog * Force sync compilation for TAA Co-authored-by: CifaCia <f.cifariellociardi@gmail.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Changed light reset to preserve type (#4624)

88779ea

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Add support for the camera bridge in the graphics compositor (#…

30fffd5

…4599)" This reverts commit 2325e3f.

AxF carpaint: Fix a compilation issue on Vulkan until the cpp HLSLcc …

aabbb4b

…side is updated. (case 1335737, related to 1314040) (#4691) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Revert "Revert "Add support for the camera bridge in the graphics com…

dfdb311

…positor (#4599)"" This reverts commit 30fffd5.

revert: Fix distortion when resizing the window in player builds with…

891fda0

… the Graphi

Merge branch 'master' into hd/bugfix

7b17e06

Merge branch 'master' into hd/bugfix

32df1bf

Fix for discrepancies in saturation and intensity between screen spac…

0032b9c

…e refraction and probe refraction (#4653) * Delete the second transmittance mul * Changelog Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

Fix a Divide-by-Zero Warning for some Anisotropic Models (Fabric, Lit) (

41716f0

#4636) * Initialize the shading normal to a non-zero value for anisotropy * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP] Fix VfX lit particle AOV output color space (#4646)

333c800

* Fix VfX lit particle aov output color space * Update comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

[HDRP][Path Tracing] Fixed transparent unlit (#4605)

809316c

* Fixed issue with transparent unlit. * Updated changelog. * Reverted accidental change to default mtl. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

7b1ad29

Fix distortion with MSAA (#4711)

08a578d

Fix contact shadow debug views (#4720)

3c418c0

* Fix * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Update Decal-Projector.md (#4695)

352f65d

[HDRP] Fixed nullref when deleting the texture asset assigned in a lo…

acc5073

…cal volumetric fog volume (#4728) * Fixed nullref when deleting the 3D mask of a density volume (case 1339330) * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

fd54a00

Fix decal layer enum (#4753)

1672dc6

Fix typo

c40c5c5

sebastienlagarde and others added 6 commits November 27, 2021 09:12

Update CHANGELOG.md

ddd647b

Merge branch 'master' of https://github.com/Unity-Technologies/Graphics…

3018bb8

… into hd/bugfix # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md

Fixed Normal Map assiignation when importing FBX Materials (#6491)

d9c12ff

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fix sky jittering (#6678)

8e89800

Merge branch 'master' into hd/bugfix

0914c40

Post Process can now be edited in the default frame settings.

e9ab5ca

JulienIgnace-Unity added HDRP needs-backport-10.x needs-backport-2021.2 needs-backport-2022.1 labels Jan 24, 2022

JulienIgnace-Unity requested review from sebastienlagarde and a team January 24, 2022 16:42

remi-chapelain approved these changes Jan 24, 2022

View reviewed changes

sebastienlagarde changed the base branch from hd/bugfix to master February 1, 2022 09:22

Merge branch 'master' into hd/fix-global-setting-pp

6ae463e

sebastienlagarde approved these changes Feb 1, 2022

View reviewed changes

sebastienlagarde merged commit dc0c22a into master Feb 1, 2022

sebastienlagarde deleted the hd/fix-global-setting-pp branch February 1, 2022 09:23

sebastienlagarde added backported-2021.2 and removed needs-backport-10.x needs-backport-2021.2 labels Feb 1, 2022

sebastienlagarde pushed a commit that referenced this pull request Feb 1, 2022

Post Process can now be edited in the default frame settings. #6816

fcc3c9e

sebastienlagarde mentioned this pull request Feb 1, 2022

[HDRP 21.2] Backport various PRs #6926

Merged

sebastienlagarde added backported-2022.1 and removed needs-backport-2022.1 labels Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Post Process can now be edited in the default frame settings. #6816

Post Process can now be edited in the default frame settings. #6816

Uh oh!

JulienIgnace-Unity commented Jan 24, 2022

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

remi-chapelain left a comment

Uh oh!

Uh oh!

Post Process can now be edited in the default frame settings. #6816

Post Process can now be edited in the default frame settings. #6816

Uh oh!

Conversation

JulienIgnace-Unity commented Jan 24, 2022

Purpose of this PR

Testing status

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

remi-chapelain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!