Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801

anisunity · 2022-01-24T12:07:20Z

https://fogbugz.unity3d.com/f/cases/1392530/
Pretty straight forward rename

Testing status:
Made sure it appears properly in the volume components

…rrides (case 1392530).

github-actions · 2022-01-24T12:07:35Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

remi-chapelain · 2022-01-24T12:40:47Z

com.unity.render-pipelines.high-definition/Editor/Sky/SkySettingsEditor.cs

@@ -25,6 +25,7 @@ protected enum SkySettingsUIElement
        }

        GUIContent m_SkyIntensityModeLabel = new UnityEngine.GUIContent("Intensity Mode");
+        GUIContent m_ExposureCompensationLabel = new GUIContent("Exposure Compensaiton", "Sets the exposure compensation of the sky in EV.");


Quick typo here, "Compensaiton"

remi-chapelain

Only quick typo otherwise, looks good to me.

remi-chapelain

LGTM ✔️

…rrides (case 1392530). #6801

* fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>

* [HDRP 21.2] Backport various PRs (#6926) * fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com> * Fixed missing capital and UI bolding (#6876) * [RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799 * Disabled the "Reflect Sky" feature in the case of transparent screenspace reflections for the water system. #6725 Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>

Renamed the Exposure field to Exposure Compensation in sky volume ove…

d750543

…rrides (case 1392530).

anisunity added the HDRP label Jan 24, 2022

anisunity requested review from sebastienlagarde and a team January 24, 2022 12:07

anisunity self-assigned this Jan 24, 2022

anisunity marked this pull request as ready for review January 24, 2022 12:27

remi-chapelain reviewed Jan 24, 2022

View reviewed changes

remi-chapelain requested changes Jan 24, 2022

View reviewed changes

Fix typo

bbfd1ea

remi-chapelain self-requested a review January 24, 2022 12:46

remi-chapelain approved these changes Jan 24, 2022

View reviewed changes

Merge branch 'master' into HDRP/fix-1392530

3390b4e

anisunity merged commit 3f31781 into master Jan 27, 2022

anisunity deleted the HDRP/fix-1392530 branch January 27, 2022 13:51

sebastienlagarde added needs-backport-2021.2 needs-backport-2022.1 backported-2021.2 and removed needs-backport-2021.2 labels Jan 28, 2022

sebastienlagarde pushed a commit that referenced this pull request Feb 1, 2022

Renamed the Exposure field to Exposure Compensation in sky volume ove…

c0756f8

…rrides (case 1392530). #6801

sebastienlagarde added backported-2022.1 and removed needs-backport-2022.1 labels Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801

Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801

Uh oh!

anisunity commented Jan 24, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

remi-chapelain Jan 24, 2022 •

edited

Loading

Uh oh!

anisunity Jan 24, 2022

Uh oh!

remi-chapelain left a comment

Uh oh!

remi-chapelain left a comment

Uh oh!

Uh oh!

Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801

Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801

Uh oh!

Conversation

anisunity commented Jan 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

remi-chapelain Jan 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anisunity Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

remi-chapelain left a comment

Choose a reason for hiding this comment

Uh oh!

remi-chapelain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anisunity commented Jan 24, 2022 •

edited

Loading

remi-chapelain Jan 24, 2022 •

edited

Loading