[RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799

alex-vazquez · 2022-01-24T10:52:29Z

Purpose of this PR

The OnEnable method was being called, before the inspector was being set. The OnEnable is being called manually by the VolumeComponentListEditor

Testing status

Check the DiffusionProfile editor works as expected.

…h the Volume Profile

github-actions · 2022-01-24T10:52:42Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

alex-vazquez · 2022-01-24T11:12:34Z

@Unity-Technologies/gfx-qa-hdrp , could you please open a Volume, with a DiffusionProfile added? both through the VolumeProfileInspector and from the VolumeInspector. Many thanks

remi-chapelain · 2022-01-24T11:23:41Z

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -81,6 +81,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixing missing doc API for RTAS Debug display.
 - Fixed AO dissapearing when DRS would be turned off through a camera, while hardware drs is active in DX12 or Vulkan (case 1383093).
 - Fixed misc shader warnings.
+- Fixed crash opeing Volume Component with Diffusion Profile.


minor typo here

remi-chapelain

Quickly checked to see if no issues arised, LGTM ✔️

com.unity.render-pipelines.high-definition/CHANGELOG.md

adrien-de-tocqueville · 2022-01-24T14:35:52Z

com.unity.render-pipelines.high-definition/CHANGELOG.md

@@ -81,6 +81,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixing missing doc API for RTAS Debug display.
 - Fixed AO dissapearing when DRS would be turned off through a camera, while hardware drs is active in DX12 or Vulkan (case 1383093).
 - Fixed misc shader warnings.
+- Fixed NullReferenceException when opeining a Volume Component with a Diffusion Profile with any inspector.


lol minor typo here

alex-vazquez · 2022-01-25T09:34:21Z

Safety Net failing because : RenderSettingsConverter.cs(264,22): error CS0618: 'RenderingPath.DeferredLighting' is obsolete: 'DeferredLighting has been removed. Use DeferredShading, Forward or HDRP/URP instead. Merging.

…#6799

* [HDRP 21.2] Backport various PRs (#6926) * fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com> * Fixed missing capital and UI bolding (#6876) * [RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799 * Disabled the "Reflect Sky" feature in the case of transparent screenspace reflections for the water system. #6725 Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>

…ened wit #6799

[RPW]Fix Diffusion Profile Volume Component inspector when opened wit…

f65cd85

…h the Volume Profile

alex-vazquez added the needs-backport-2022.1 label Jan 24, 2022

alex-vazquez requested a review from adrien-de-tocqueville January 24, 2022 10:52

alex-vazquez self-assigned this Jan 24, 2022

github-actions bot added HDRP SRP labels Jan 24, 2022

Changelog

934a145

adrien-de-tocqueville approved these changes Jan 24, 2022

View reviewed changes

alex-vazquez requested a review from a team January 24, 2022 11:11

alex-vazquez marked this pull request as ready for review January 24, 2022 11:11

remi-chapelain reviewed Jan 24, 2022

View reviewed changes

remi-chapelain approved these changes Jan 24, 2022

View reviewed changes

alex-vazquez commented Jan 24, 2022

View reviewed changes

com.unity.render-pipelines.high-definition/CHANGELOG.md Outdated Show resolved Hide resolved

Update com.unity.render-pipelines.high-definition/CHANGELOG.md

99cc2e3

adrien-de-tocqueville reviewed Jan 24, 2022

View reviewed changes

adrien-de-tocqueville and others added 3 commits January 24, 2022 15:37

Update CHANGELOG.md

08dc0ef

Merge branch 'master' into rpw/fix-diffusion-profile-editor-crash

4372ebd

Update CHANGELOG.md

6d1e3e0

alex-vazquez merged commit 66a46e5 into master Jan 25, 2022

alex-vazquez deleted the rpw/fix-diffusion-profile-editor-crash branch January 25, 2022 09:34

sebastienlagarde added backported-2022.1 and removed needs-backport-2022.1 labels Feb 1, 2022

sebastienlagarde pushed a commit that referenced this pull request Feb 1, 2022

[RPW]Fix Diffusion Profile Volume Component inspector when opened wit… …

f242529

…#6799

sebastienlagarde added needs-backport-2022.1 and removed backported-2022.1 labels Feb 1, 2022

sebastienlagarde added a commit that referenced this pull request Feb 1, 2022

Revert: [RPW]Fix Diffusion Profile Volume Component inspector when op…

701be2e

…ened wit #6799

alex-vazquez mentioned this pull request Feb 2, 2022

[Backport][RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6964

Merged

sebastienlagarde added backported-2022.1 and removed needs-backport-2022.1 labels Feb 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799

[RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799

Uh oh!

alex-vazquez commented Jan 24, 2022

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

alex-vazquez commented Jan 24, 2022

Uh oh!

remi-chapelain Jan 24, 2022

Uh oh!

remi-chapelain left a comment

Uh oh!

Uh oh!

adrien-de-tocqueville Jan 24, 2022

Uh oh!

alex-vazquez commented Jan 25, 2022

Uh oh!

Uh oh!

[RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799

[RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799

Uh oh!

Conversation

alex-vazquez commented Jan 24, 2022

Purpose of this PR

Testing status

Uh oh!

github-actions bot commented Jan 24, 2022

Uh oh!

alex-vazquez commented Jan 24, 2022

Uh oh!

remi-chapelain Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

remi-chapelain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adrien-de-tocqueville Jan 24, 2022

Choose a reason for hiding this comment

Uh oh!

alex-vazquez commented Jan 25, 2022

Uh oh!

Uh oh!