-
Notifications
You must be signed in to change notification settings - Fork 844
Fix urp udate custom revision jobs #3107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Remove unity downloader command from test * Re-add unity downloader command and change path of unity_revision.txt * Fix xcopy command * Change xcopy command - Use copy * Apply changes to custom revision jobs only
* backport #3034 * backport #3168 * backport 650775a * remove win dx12 playmode editor from ci due to 1308059 * Fix urp udate custom revision jobs (#3107) * backport #3129 * fix nightlies * backport #2954 Co-authored-by: Théo Penavaire <theo-pnv@users.noreply.github.com> Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
Note about the backports: EDIT: The job has passed so I believe the code from this PR was correctly incorporated into the yaml generator refactor. There is no need to backport anything since the python code is now the same for all branches. |
Purpose of this PR
Copy the
unity_revision.txt
file inside the URPUpdate folder, where it can be picked up by unity-downloader-cli.This only affects CUSTOM-REVISION tests.
Testing status
Without this PR: The job is stuck because it can't find the unity_revision.txt file: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Furpupdate_top_asset_store-win-dx11.yml%2523URPUpdate_Top_Asset_Store_Win_DX11_playmode_mono_Linear_CUSTOM-REVISION/4885113/job/(log:Execution)
With this PR: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Ffix-urpudate-tests/.yamato%252Furpupdate_top_asset_store-win-dx11.yml%2523URPUpdate_Top_Asset_Store_Win_DX11_playmode_mono_Linear_CUSTOM-REVISION/4887085/job
The tests are failing but the failure is also happening on master.