Skip to content

Fix urp udate custom revision jobs #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 14, 2021
Merged

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Jan 14, 2021

Purpose of this PR

Copy the unity_revision.txt file inside the URPUpdate folder, where it can be picked up by unity-downloader-cli.
This only affects CUSTOM-REVISION tests.


Testing status

Without this PR: The job is stuck because it can't find the unity_revision.txt file: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Furpupdate_top_asset_store-win-dx11.yml%2523URPUpdate_Top_Asset_Store_Win_DX11_playmode_mono_Linear_CUSTOM-REVISION/4885113/job/(log:Execution)

With this PR: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Ffix-urpudate-tests/.yamato%252Furpupdate_top_asset_store-win-dx11.yml%2523URPUpdate_Top_Asset_Store_Win_DX11_playmode_mono_Linear_CUSTOM-REVISION/4887085/job

The tests are failing but the failure is also happening on master.

@theopnv theopnv marked this pull request as ready for review January 14, 2021 13:05
@theopnv theopnv requested a review from a team as a code owner January 14, 2021 13:05
@theopnv theopnv changed the title Remove unity downloader command from test Fix urp udate custom revision jobs Jan 14, 2021
@theopnv theopnv merged commit e0344b1 into master Jan 14, 2021
@theopnv theopnv deleted the yamato/fix-urpudate-tests branch January 14, 2021 14:14
@theopnv
Copy link
Contributor Author

theopnv commented Jan 20, 2021

To backport this on 10.x.x:
Depends on #3170 and #3175 to be backported first.

To backport this on 2021.1:
Depends on #3175

sophiaaar pushed a commit that referenced this pull request Jan 21, 2021
* Remove unity downloader command from test

* Re-add unity downloader command and change path of unity_revision.txt

* Fix xcopy command

* Change xcopy command - Use copy

* Apply changes to custom revision jobs only
sophiaaar added a commit that referenced this pull request Jan 21, 2021
* backport #3034

* backport #3168

* backport 650775a

* remove win dx12 playmode editor from ci due to 1308059

* Fix urp udate custom revision jobs (#3107)
* backport #3129

* fix nightlies

* backport #2954

Co-authored-by: Théo Penavaire <theo-pnv@users.noreply.github.com>
Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
@theopnv
Copy link
Contributor Author

theopnv commented Mar 1, 2021

Note about the backports:
I think on master this PR was reverted inadvertently since moving the yml files generator to the set repo because I can't find the piece of code it added https://github.com/Unity-Technologies/Graphics/blob/master/.yamato/urpupdate-win-dx11.yml#L89.
I'm running https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Furpupdate_top_asset_store-win-dx11.yml%2523URPUpdate_Top_Asset_Store_Win_DX11_playmode_mono_Linear_CUSTOM-REVISION/5570699/job on master to see if it's broken or not and will file a bug report if it is.
In that case, and since the code has changed I will remove the needs-10.xbackport label, to create the PR from scratch directly on 10.x.x.

EDIT: The job has passed so I believe the code from this PR was correctly incorporated into the yaml generator refactor. There is no need to backport anything since the python code is now the same for all branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants