Skip to content

[10.x.x][Yamato] Yml backports #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 26, 2021
Merged

[10.x.x][Yamato] Yml backports #3170

merged 20 commits into from
Jan 26, 2021

Conversation

sophiaaar
Copy link
Contributor

@sophiaaar sophiaaar commented Jan 19, 2021 •
edited
Loading

Purpose of this PR

Testing status

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/10.x.x%252Fyamato%252Fyml-refactor

Comments to reviewers

  • Need to turn off the status checks and allow merging from anyone
  • Failures match master
  • Number of files changed is large mostly due to meta files and pngs from reference images
    Screenshot 2021-01-25 at 16 29 12

@theopnv theopnv mentioned this pull request Jan 20, 2021
Merged
@sophiaaar sophiaaar changed the title 10.x.x/yamato/yml refactor [10.x.x][Yamato] Yml backports Jan 26, 2021
theopnv
theopnv suggested changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@theopnv theopnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this big backport! 💪

@sophiaaar sophiaaar requested a review from theopnv January 26, 2021 13:45
kivistikliis
kivistikliis reviewed Jan 26, 2021
View reviewed changes
kivistikliis
kivistikliis reviewed Jan 26, 2021
View reviewed changes
@sophiaaar sophiaaar marked this pull request as ready for review January 26, 2021 14:56
@sophiaaar sophiaaar requested a review from a team as a code owner January 26, 2021 14:56
@github-actions github-actions bot added the HDRP label Jan 26, 2021
@sophiaaar sophiaaar merged commit d81260a into 10.x.x/release Jan 26, 2021
@sophiaaar sophiaaar deleted the 10.x.x/yamato/yml-refactor branch January 26, 2021 16:14
pastasfuture pushed a commit that referenced this pull request Mar 15, 2021
@sophiaaar @pastasfuture
[10.x.x][Yamato] Yml backports (#3170)
f340645 
* backport #2843

* backport #2883

* backport #3002

* shadergraph osx editor images

* move shadergraph linux vulkan images

* pdate vfx images

* update shadergraph ios images

* remove linux vulkan standalone from urp ci

* backport #3130

* backport #3175

* backport f61eaa4

* edit pr job and nightly

* part 2

* change timeout for standalone cache

* update hdrp images

* fix expression trigger branch

* backport #3254

* remove trigger from custom revision jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kivistikliis kivistikliis kivistikliis left review comments

@theopnv theopnv theopnv approved these changes

Assignees
No one assigned
Labels
HDRP Shader Graph testing vfx yamato
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophiaaar @kivistikliis @theopnv