[Yamato] Succeed on no tests found by testfilter #2954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theopnv
reviewed
Dec 22, 2020
| @@ -62,6 +62,9 @@ Nightly_HDRP_trunk: | |||
| rerun: on-new-revision | |||
| - path: .yamato/hdrp-linux-vulkan.yml#HDRP_Linux_Vulkan_editmode_mono_Linear_trunk | |||
| rerun: on-new-revision | |||
| variables: | |||
| UTR_VERSION: "current" | |||
There was a problem hiding this comment.
The "current" variable everywhere is just because we forgot to add it in all the jobs when making the PR about this feature, right? It is technically not related to the test filter?
There was a problem hiding this comment.
Yep correct, forgot to mention that, sorry!
theopnv
approved these changes
Dec 22, 2020
sophiaaar
added a commit
that referenced
this pull request
Jan 21, 2021
* backport #3034 * backport #3168 * backport 650775a * remove win dx12 playmode editor from ci due to 1308059 * Fix urp udate custom revision jobs (#3107) * backport #3129 * fix nightlies * backport #2954 Co-authored-by: Théo Penavaire <theo-pnv@users.noreply.github.com> Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Returns successful exit code when no test are found for a specified testfilter.
Testing status
Shadergraph PR Job without testfilter https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fsucceed-on-no-tests/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk/4662044/job
Shadergraph PR Job with testfilter https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fsucceed-on-no-tests/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk/4662062/job (check iPhone job)
Comments to reviewers
Notes for the reviewers you have assigned.