Fixed an issue with the frame count management for the volumetric fog (case 1299251). #2947

anisunity · 2020-12-18T10:23:30Z

https://fogbugz.unity3d.com/f/cases/1299251/
After a recent change related to the frame count management. The Frame count was not updated properly anymore in the scene view editor. Which lead to a various set of issues related to the volumetrics. By using the camera frame count we guarantee that the frame count is incremented at every render with that camera.

Testing status
The issue doesn't repro locally anymore.
Local tests are green, except for 9402 AlphaToMask which doesn't have to do anything with the code changed...

* Fix coat normal space * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

…hadows with unconventional aspect ratio) (#2776) * Fixed volume component tooltips using the same parameter name (#2754) * Use the proper history info for Bicubic resampling in TAA (#2759) * Use proper info for previous buffer info * changelog * Fixed lookdev movement (#2757) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix issue with saving some quality settings in volume overrides (#2758) * Fix issue with saving some quality settings volume overrides * Fix typo in changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fixed NullReferenceException in HDRenderPipeline.UpgradeResourcesIfNeeded (case 1292524) (#2765) * fix issue with confusing text (#2766) * Fix * Fix white dots * Changelog * Rename the sunrise icon to fix typo, causing issue with 2x resolution loading. (#2809) * [HDRP] Rename HDRP to HD Render Pipeline in menu item (#2819) * [HDRP] Update HDRP menu in shader graph * Update CHANGELOG.md * HDRP/Fix package version showing package after the last "verified" package (#2783) * Fix typo * Remove last version checker from wizard and add link to package manager instead * Update CHANGELOG.md * Update documentation * Update Render-Pipeline-Wizard.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Revert bad changelog merge * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com>

* Fixed invalid loop length for probe baking (case 1289680) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* fix volumetric fog with XR single-pass rendering * update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix first frame exposure, depth pyramid / AO * Update changelog * Comment * Typo * Add missing RenderGraphBuilder.ReadTexture call * Move ComputePackedMipChainInfo at the beginning of ExecuteWithRenderGraph Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

This reverts commit 2653b9c.

* Fix AOV api in rendergraph # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs * Update changelog

…iders (#2924)

…bled (#2925) * Fix * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Move EndCameraRendering callback out of the profiling scope * added a comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…case 1296203). (#2915) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…ing (case 1287355). (#2916)

* Fixed default eye shader blocks * Fix missing emission block in hair shader * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…in the light cluster depending on its baking status. (#2932) * - Fixed using the wrong method to define if a light should be included in the light cluster depending on its baking status. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…ed (#2930) * Changed the behavior of custom passes when the Custom Pass Volume component is disabled * Updated changelog

…ing Quality Levels (#2921) * Fixed display of LOD Bias and maximum level in frame settings when using Quality Levels * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…ev is not supported. (#2929) * Fixed an issue when trying to open a look dev env library when Look Dev is not supported. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…4694). (#2933) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

…d to (case 1299617). (#2926) * Fixed the planar depth texture not being properly created and rendered to (case 1299617). * adding comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

… (case 1299251).

sebastienlagarde · 2020-12-18T10:56:10Z

...y.render-pipelines.high-definition/Runtime/Lighting/VolumetricLighting/VolumetricLighting.cs

+        static uint VolumetricFrameIndex(HDCamera hdCamera)
+        {
+            // Here we do modulo 14 because we need the enable to detect a change every frame, but the accumulation is done on 7 frames (7x2=14)
+            return hdCamera.GetCameraFrameCount() % 14;


don't we have any constant value somewhere with this 7 ? Afraid to have hardcoded value hidden in a function like this.

right now, no when the thing is accumulation frame index is computed its explicitely written frameIndex % 7

adrien-de-tocqueville

looks good, but the frame count management in HDRenderPipeline is still broken, so we probably still have problem with other effects using accumulation like TAA

TomasKiniulis

Tested repro project and template scene with Always Refresh toggled On/Off, and various Scene/Game view layouts in Playmode and edit mode. Seems to be working correctly now

…tric fog (case 1299251). #2947

* Fix random warnings (#2972) * Fix FreeCamera speed boost controls (#2967) Two issues: 1. Holding Shift key during mouse-look with right mouse button would only boost speed for a single frame because it was checking GetKeyDown. Fixed by checking GetKey. 2. The Shift key only gives a speed boost when mouse-looking with RMB, but the Fire input (LMB by default) should always work. However, there was an issue where Fire would not boost the camera if the RMB was held down. This change fixes that so Fire will always boost and Shift will still only boost during mouse-look. * Fixed an issue with the frame count management for the volumetric fog (case 1299251). (#2947) * [HDRP] Fix coat normal space (#2888) * Fix coat normal space * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Avoid issues causing faulty transitions in shadows (resulting in no shadows with unconventional aspect ratio) (#2776) * Fixed volume component tooltips using the same parameter name (#2754) * Use the proper history info for Bicubic resampling in TAA (#2759) * Use proper info for previous buffer info * changelog * Fixed lookdev movement (#2757) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix issue with saving some quality settings in volume overrides (#2758) * Fix issue with saving some quality settings volume overrides * Fix typo in changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fixed NullReferenceException in HDRenderPipeline.UpgradeResourcesIfNeeded (case 1292524) (#2765) * fix issue with confusing text (#2766) * Fix * Fix white dots * Changelog * Rename the sunrise icon to fix typo, causing issue with 2x resolution loading. (#2809) * [HDRP] Rename HDRP to HD Render Pipeline in menu item (#2819) * [HDRP] Update HDRP menu in shader graph * Update CHANGELOG.md * HDRP/Fix package version showing package after the last "verified" package (#2783) * Fix typo * Remove last version checker from wizard and add link to package manager instead * Update CHANGELOG.md * Update documentation * Update Render-Pipeline-Wizard.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Revert bad changelog merge * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> * Fixed invalid loop length for probe baking (case 1289680) (#2830) * Fixed invalid loop length for probe baking (case 1289680) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix volumetric fog with XR single-pass (#2823) * fix volumetric fog with XR single-pass rendering * update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix rendering issues for the first frame (#2836) * Fix first frame exposure, depth pyramid / AO * Update changelog * Comment * Typo * Add missing RenderGraphBuilder.ReadTexture call * Move ComputePackedMipChainInfo at the beginning of ExecuteWithRenderGraph Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 5001_Fog_FogFallback.png * Revert "Update 5001_Fog_FogFallback.png" This reverts commit 2653b9c. * Update 5001_Fog_FogFallback.unity * Fix AOV API for render graph (#2909) * Fix AOV api in rendergraph # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs * Update changelog * Fix a small discrepancy in the marker placement in light intensity sliders (#2924) * Update CHANGELOG.md * Fix issue with VT spewing errors when transparent and opaque are disabled (#2925) * Fix * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a bug in the sphere-aabb light cluster (case 1294767). (#2920) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Move EndCameraRendering callback out of the profiling scope (#2917) * Move EndCameraRendering callback out of the profiling scope * added a comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed baked light being included into the ray tracing light cluster (case 1296203). (#2915) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Handle all enums the same way for UI (#2913) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Changed the message when the graphics device doesn't support ray tracing (case 1287355). (#2916) * [HDRP] Fix default blocks for Hair and Eye shader graphs (#2919) * Fixed default eye shader blocks * Fix missing emission block in hair shader * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Init scene camera debug framesettings (#2931) * Fixed using the wrong method to define if a light should be included in the light cluster depending on its baking status. (#2932) * - Fixed using the wrong method to define if a light should be included in the light cluster depending on its baking status. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Change the behavior of custom passes when the volume is disabled (#2930) * Changed the behavior of custom passes when the Custom Pass Volume component is disabled * Updated changelog * Fixed display of LOD Bias and maximum level in frame settings when using Quality Levels (#2921) * Fixed display of LOD Bias and maximum level in frame settings when using Quality Levels * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue when trying to open a look dev env library when Look Dev is not supported. (#2929) * Fixed an issue when trying to open a look dev env library when Look Dev is not supported. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable Reflector for Spotlight by default * - Fixed shader graph not supporting indirectdxr multibounce (case 1294694). (#2933) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed the planar depth texture not being properly created and rendered to (case 1299617). (#2926) * Fixed the planar depth texture not being properly created and rendered to (case 1299617). * adding comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue with the frame count management for the volumetric fog (case 1299251). * Update CHANGELOG.md Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Frédéric Vauchelles <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * - Changed the convergance time of ssgi to 16 frames. (#2912) - Changed the preset values for ssgi. - Fixed an issue with half res ssgi upscale. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix BakeCloudShadows warning * Cleanup CubeToPanoMaterial not used * Revert: Fixed an issue with the frame count management for the volumetric fog (case 1299251). #2947 Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Alex Kerfoot <alexk@unity3d.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Frédéric Vauchelles <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>

* Fix random warnings (#2972) * Fix FreeCamera speed boost controls (#2967) Two issues: 1. Holding Shift key during mouse-look with right mouse button would only boost speed for a single frame because it was checking GetKeyDown. Fixed by checking GetKey. 2. The Shift key only gives a speed boost when mouse-looking with RMB, but the Fire input (LMB by default) should always work. However, there was an issue where Fire would not boost the camera if the RMB was held down. This change fixes that so Fire will always boost and Shift will still only boost during mouse-look. * Fixed an issue with the frame count management for the volumetric fog (case 1299251). (#2947) * [HDRP] Fix coat normal space (#2888) * Fix coat normal space * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Avoid issues causing faulty transitions in shadows (resulting in no shadows with unconventional aspect ratio) (#2776) * Fixed volume component tooltips using the same parameter name (#2754) * Use the proper history info for Bicubic resampling in TAA (#2759) * Use proper info for previous buffer info * changelog * Fixed lookdev movement (#2757) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix issue with saving some quality settings in volume overrides (#2758) * Fix issue with saving some quality settings volume overrides * Fix typo in changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fixed NullReferenceException in HDRenderPipeline.UpgradeResourcesIfNeeded (case 1292524) (#2765) * fix issue with confusing text (#2766) * Fix * Fix white dots * Changelog * Rename the sunrise icon to fix typo, causing issue with 2x resolution loading. (#2809) * [HDRP] Rename HDRP to HD Render Pipeline in menu item (#2819) * [HDRP] Update HDRP menu in shader graph * Update CHANGELOG.md * HDRP/Fix package version showing package after the last "verified" package (#2783) * Fix typo * Remove last version checker from wizard and add link to package manager instead * Update CHANGELOG.md * Update documentation * Update Render-Pipeline-Wizard.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Revert bad changelog merge * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> * Fixed invalid loop length for probe baking (case 1289680) (#2830) * Fixed invalid loop length for probe baking (case 1289680) # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix volumetric fog with XR single-pass (#2823) * fix volumetric fog with XR single-pass rendering * update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix rendering issues for the first frame (#2836) * Fix first frame exposure, depth pyramid / AO * Update changelog * Comment * Typo * Add missing RenderGraphBuilder.ReadTexture call * Move ComputePackedMipChainInfo at the beginning of ExecuteWithRenderGraph Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 5001_Fog_FogFallback.png * Revert "Update 5001_Fog_FogFallback.png" This reverts commit 2653b9c. * Update 5001_Fog_FogFallback.unity * Fix AOV API for render graph (#2909) * Fix AOV api in rendergraph # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs * Update changelog * Fix a small discrepancy in the marker placement in light intensity sliders (#2924) * Update CHANGELOG.md * Fix issue with VT spewing errors when transparent and opaque are disabled (#2925) * Fix * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a bug in the sphere-aabb light cluster (case 1294767). (#2920) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Move EndCameraRendering callback out of the profiling scope (#2917) * Move EndCameraRendering callback out of the profiling scope * added a comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed baked light being included into the ray tracing light cluster (case 1296203). (#2915) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Handle all enums the same way for UI (#2913) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Changed the message when the graphics device doesn't support ray tracing (case 1287355). (#2916) * [HDRP] Fix default blocks for Hair and Eye shader graphs (#2919) * Fixed default eye shader blocks * Fix missing emission block in hair shader * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Init scene camera debug framesettings (#2931) * Fixed using the wrong method to define if a light should be included in the light cluster depending on its baking status. (#2932) * - Fixed using the wrong method to define if a light should be included in the light cluster depending on its baking status. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Change the behavior of custom passes when the volume is disabled (#2930) * Changed the behavior of custom passes when the Custom Pass Volume component is disabled * Updated changelog * Fixed display of LOD Bias and maximum level in frame settings when using Quality Levels (#2921) * Fixed display of LOD Bias and maximum level in frame settings when using Quality Levels * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue when trying to open a look dev env library when Look Dev is not supported. (#2929) * Fixed an issue when trying to open a look dev env library when Look Dev is not supported. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable Reflector for Spotlight by default * - Fixed shader graph not supporting indirectdxr multibounce (case 1294694). (#2933) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed the planar depth texture not being properly created and rendered to (case 1299617). (#2926) * Fixed the planar depth texture not being properly created and rendered to (case 1299617). * adding comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue with the frame count management for the volumetric fog (case 1299251). * Update CHANGELOG.md Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Frédéric Vauchelles <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * - Changed the convergance time of ssgi to 16 frames. (#2912) - Changed the preset values for ssgi. - Fixed an issue with half res ssgi upscale. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix BakeCloudShadows warning * Cleanup CubeToPanoMaterial not used * Update 5001_Fog_FogFallBack scene to correct bad behavior * Updating screenshots * Increase waitFrames from 0 to 4 for test scene 5001 * update vulkan screenshots Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Alex Kerfoot <alexk@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: John Parsaie <johnpa@unity3d.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Frédéric Vauchelles <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Fabien Houlmann <fabien@unity3d.com>

alelievr and others added 30 commits December 15, 2020 13:46

[HDRP] Fix coat normal space (#2888)

259c344

* Fix coat normal space * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>

Merge branch 'master' into hd/bugfix

e5e7c25

Merge branch 'master' into hd/bugfix

9cf8ac1

Fix volumetric fog with XR single-pass (#2823)

7339d48

* fix volumetric fog with XR single-pass rendering * update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Update 5001_Fog_FogFallback.png

2653b9c

Revert "Update 5001_Fog_FogFallback.png"

95eb52e

This reverts commit 2653b9c.

Update 5001_Fog_FogFallback.unity

33e6948

Fix AOV API for render graph (#2909)

fcd7472

* Fix AOV api in rendergraph # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs * Update changelog

Fix a small discrepancy in the marker placement in light intensity sl…

94f3898

…iders (#2924)

Merge branch 'master' into hd/bugfix

7767a31

Update CHANGELOG.md

fb1ec50

Fix issue with VT spewing errors when transparent and opaque are disa…

abb5bb5

…bled (#2925) * Fix * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed a bug in the sphere-aabb light cluster (case 1294767). (#2920)

6a47be7

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Move EndCameraRendering callback out of the profiling scope (#2917)

4b1ac9c

* Move EndCameraRendering callback out of the profiling scope * added a comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed baked light being included into the ray tracing light cluster (…

980307b

…case 1296203). (#2915) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Handle all enums the same way for UI (#2913)

f738893

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Changed the message when the graphics device doesn't support ray trac…

a20e885

…ing (case 1287355). (#2916)

[HDRP] Fix default blocks for Hair and Eye shader graphs (#2919)

2784ac6

* Fixed default eye shader blocks * Fix missing emission block in hair shader * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Init scene camera debug framesettings (#2931)

b42cae6

[HDRP] Change the behavior of custom passes when the volume is disabl…

2fccfa9

…ed (#2930) * Changed the behavior of custom passes when the Custom Pass Volume component is disabled * Updated changelog

Fixed display of LOD Bias and maximum level in frame settings when us…

4befd38

…ing Quality Levels (#2921) * Fixed display of LOD Bias and maximum level in frame settings when using Quality Levels * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed an issue when trying to open a look dev env library when Look D…

1d8d6c5

…ev is not supported. (#2929) * Fixed an issue when trying to open a look dev env library when Look Dev is not supported. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Enable Reflector for Spotlight by default

f0ae90b

- Fixed shader graph not supporting indirectdxr multibounce (case 129…

c4ea601

…4694). (#2933) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed the planar depth texture not being properly created and rendere…

7276431

…d to (case 1299617). (#2926) * Fixed the planar depth texture not being properly created and rendered to (case 1299617). * adding comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

Fixed an issue with the frame count management for the volumetric fog…

53e40c6

… (case 1299251).

anisunity added the HDRP label Dec 18, 2020

anisunity requested review from sebastienlagarde and JulienIgnace-Unity December 18, 2020 10:23

anisunity self-assigned this Dec 18, 2020

sebastienlagarde requested a review from adrien-de-tocqueville December 18, 2020 10:55

sebastienlagarde reviewed Dec 18, 2020

View reviewed changes

adrien-de-tocqueville approved these changes Dec 18, 2020

View reviewed changes

sebastienlagarde requested a review from a team December 18, 2020 16:40

TomasKiniulis approved these changes Dec 21, 2020

View reviewed changes

Base automatically changed from hd/bugfix to master December 21, 2020 13:53

sebastienlagarde changed the base branch from master to hd/bugfix December 21, 2020 17:44

sebastienlagarde marked this pull request as ready for review December 21, 2020 17:44

sebastienlagarde added 2 commits December 21, 2020 18:45

Merge branch 'hd/bugfix' into HDRP/fix-volumetric-framecount

c671ebb

Update CHANGELOG.md

817f588

sebastienlagarde approved these changes Dec 21, 2020

View reviewed changes

sebastienlagarde merged commit 5e99f9b into hd/bugfix Dec 21, 2020

sebastienlagarde deleted the HDRP/fix-volumetric-framecount branch December 21, 2020 17:47

sebastienlagarde mentioned this pull request Dec 21, 2020

Merge Hd/bugfix #2973

Merged

sebastienlagarde added need-backport-2021.1 needs-backport-10.x labels Dec 21, 2020

sebastienlagarde added a commit that referenced this pull request Dec 24, 2020

Revert: Fixed an issue with the frame count management for the volume…

37755e5

…tric fog (case 1299251). #2947

sebastienlagarde added backported-10.x and removed needs-backport-10.x backported-10.x needs-backport-2021.1 labels Jan 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed an issue with the frame count management for the volumetric fog (case 1299251). #2947

Fixed an issue with the frame count management for the volumetric fog (case 1299251). #2947

Uh oh!

anisunity commented Dec 18, 2020

Uh oh!

sebastienlagarde Dec 18, 2020

Uh oh!

anisunity Dec 18, 2020

Uh oh!

adrien-de-tocqueville left a comment

Uh oh!

TomasKiniulis left a comment

Uh oh!

Uh oh!

Fixed an issue with the frame count management for the volumetric fog (case 1299251). #2947

Fixed an issue with the frame count management for the volumetric fog (case 1299251). #2947

Uh oh!

Conversation

anisunity commented Dec 18, 2020

Uh oh!

sebastienlagarde Dec 18, 2020

Choose a reason for hiding this comment

Uh oh!

anisunity Dec 18, 2020

Choose a reason for hiding this comment

Uh oh!

adrien-de-tocqueville left a comment

Choose a reason for hiding this comment

Uh oh!

TomasKiniulis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!