Avoid issues causing faulty transitions in shadows (resulting in no shadows with unconventional aspect ratio) #2776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
remi-chapelain
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Fix validated with @FrancescoC-unity before making the PR ! ✔️
* [HDRP] Update HDRP menu in shader graph * Update CHANGELOG.md
…ckage (#2783) * Fix typo * Remove last version checker from wizard and add link to package manager instead * Update CHANGELOG.md * Update documentation * Update Render-Pipeline-Wizard.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
…-shadow # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md # com.unity.render-pipelines.high-definition/Editor/Lighting/Reflection/HDScreenSpaceReflectionEditor.cs # com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Raytracing/GlobalIlluminationEditor.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue in https://fogbugz.unity3d.com/f/cases/1292295/
The issue is due to how the cascade spheres are and how the border is computed. As a result sometimes we try to transition when we shouldn't; this PR fixes the issue to a certain extent (with ludicrous transition percentages, usually >=90% of the full split).
This also fixes another bug due to the precision of the dither transition that showed with small dots like this
We already went through it with @remi-chapelain