Fix issue with VT spewing errors when transparent and opaque are disabled #2925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoC-unity
requested review from
sebastienlagarde and
JulienIgnace-Unity
|
It appears that you made a non-draft PR! |
sebastienlagarde
added
need-backport-2021.1
needs-backport-10.x
and removed
needs-backport-10.x
labels
JulienIgnace-Unity
approved these changes
Dec 17, 2020
sebastienlagarde
approved these changes
Dec 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the pass is not culled explicitly, we need to have the input valid and therefore we fallback to a black texture for the VT buffer just to make RG happy.
Fix for https://fogbugz.unity3d.com/f/cases/1297710