Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.24.0 (please TEST!) #8890

Closed
8 of 9 tasks
Stypox opened this issue Aug 27, 2022 · 43 comments
Closed
8 of 9 tasks

Release v0.24.0 (please TEST!) #8890

Stypox opened this issue Aug 27, 2022 · 43 comments

Comments

@Stypox
Copy link
Member

Stypox commented Aug 27, 2022

Testing for regressions

Debug APK (built by our CI in #8889): NewPipe_v0.24.0_RC3_debug.zip
Release APK (built and signed by @Stypox): NewPipe_v0.24.0_RC3_release.zip
Please report only regressions (i.e. new issues) here, not issues that were already present in previous releases!

TODO

NewPipeExtractor version

This version of NewPipe will ship with NewPipe Extractor commit TeamNewPipe/NewPipeExtractor@5c710da.
-> we are going to change the exposed extractor API again soon, so no official release will be done until then ;-)

App changelog

New

Improved

Fixed

Localization

Development

@Stypox Stypox pinned this issue Aug 27, 2022
@ktprograms
Copy link
Contributor

Not a regression, but the long press hint for the "Show future videos" button in the subscription feed doesn't change to indicate whether the left-pointing or right-pointing icon is show/don't show.

@jirafey

This comment was marked as off-topic.

@Stypox

This comment was marked as resolved.

@PrinceRaj53
Copy link

Finally. This release fixed my fullscreen issue #8774. Thanks .

If this will be the final release then I should be able to use regular newpipe builds again instead of debug builds.

@Stypox
Copy link
Member Author

Stypox commented Aug 28, 2022

Somebody reported on reddit that still sometimes the wrong notification thumbnail is shown when switching videos. After some testing it seems like this is reproducible only on Android 13 (and maybe 12). Here are the full reproduction steps:

  • search for "playlist", while filtering only for playlists
  • open a playlist having as first two items two videos you have NEVER seen before (to make sure video thumbnails are not cached)
  • tap on the "Background" button in the playlist header
  • from the notification, press next

=> The second video will start playing, but the shown thumbnail will be that of the first video. The strange thing is that the color of the thumbnail actually adapts to the thumbnail of the second video, which implies the OS must receive the correct thumbnail somewhere, since it's up to the OS to decide the notification color. I could also confirm that the correct thumbnail is set in the media session by using https://github.com/googlesamples/android-media-controller/. I will investigate a little more and give updates here.

@opusforlife2
Copy link
Collaborator

Android 12 (CalyxOS): The thumbnail gets updated correctly.

@AudricV
Copy link
Member

AudricV commented Aug 28, 2022

still has throttling with this and 0.23.3 for some reason.

@eladkarako On playback, on download, on all formats? Could you explain your issue a bit, please?

Also it seems you blocked all the TeamNewPipe organization members since a while.

@njmdietrich
Copy link

still has throttling with this and 0.23.3 for some reason. 25kbps top.. :..(

Is this the same issue as #8906?

@SameenAhnaf
Copy link
Collaborator

Tapping on either Remove watched or Show future videos icon always show New feed items toast if a livestream is going on.

Screenrecorder-2022-08-29-20-20-12-230.mp4

@Stypox
Copy link
Member Author

Stypox commented Aug 29, 2022

@SameenAhnaf I think that bug is present also in 0.23.3, so it's not a regression, though I agree it looks strange

@SameenAhnaf
Copy link
Collaborator

The Show future videos icon behavior is not present in 0.23.3 though. At least, that should be solved.

@SC1040-TS2
Copy link

SC1040-TS2 commented Sep 1, 2022

still has throttling with this and 0.23.3 for some reason.

On playback, on download, on all formats? Could you explain your issue a bit, please?

Also it seems you blocked all the TeamNewPipe organization members since a while.

Is this the same issue as #8906?

Close, but not quite.

The WebM video format appears to experience the throttling issue during playback, and even then only with certain channels and videos. Not sure if the MP4 format playback can replicate it so easily.

Sometimes power cycling home networking equipment solves the issue, but not for long and not with every video example.

Cloudflare 1.1.1.1 and corresponding IPv6 addresses are being used in the router settings, and DNS-over-TLS is not being used/does not affect this problem. Will test with ISP DNS addresses later. DNS address usage does not matter here.

Using mobile data can handle the affected video format more easily, somehow.

Background playback of a WebM video proceeds as normal with minimal issue, but foreground playback and rendering of the WebM video is where the problem occurs.

@SC1040-TS2
Copy link

Small update on my prior comment. Removing the 2 secondary RF antennae on my NETGEAR XR500 router (it comes with 4) appears to have solved the issue for Youtube-encoded WebM video playback.

The strange thing is why this worked, when other apps seemed to maintain typical connectivity with all 4 antennae connected. Maybe they were interfering with each other?

@Elmo2218

This comment was marked as off-topic.

@SC1040-TS2

This comment was marked as off-topic.

@Locorock
Copy link

Locorock commented Sep 5, 2022

Thumbnails in the feed tab are incorrectly resized, this only happens in the feed tab.

Screenshot_2022-09-05-10-35-03-66_6497fb3ae9f5f2799f187f75bac0fe78

Opening a video updates the thumbnail correctly:

Screenshot_2022-09-05-10-38-29-25_6497fb3ae9f5f2799f187f75bac0fe78

Thumbnails in channel and trending tabs are resized correctly:

Screenshot_2022-09-05-10-34-13-05_6497fb3ae9f5f2799f187f75bac0fe78

Using a OnePlus Nord 2, with Android 12

@opusforlife2
Copy link
Collaborator

Thumbnails in the feed tab are incorrectly resized, this only happens in the feed tab.

Strange. They show fine on Android 12 Calyx.

@Locorock
Copy link

Locorock commented Sep 5, 2022

Yeah i've been trying out a few things and it seems like the problem only appears after importing both database and configs from my 0.23.1 instance of newpipe

@Stypox
Copy link
Member Author

Stypox commented Sep 5, 2022

I can confirm, using fast feed. This is not a problem in the UI, but rather in the extractor, since it seems to provide thumbnails with black bars at the top and at the bottom. It should be solvable easily, I think.

@Pentaphon
Copy link

No more RCs for this one?

@SameenAhnaf
Copy link
Collaborator

Steps to reproduce an app crash

  1. Go to Subscriptions
  2. Go to channel details of any of the subscriptions.
  3. Start any media on the background.
  4. Close mini player before the buffering ends.
  5. UI crashes.

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: US
  • Content Language: en
  • App Language: en_GB
  • Service: none
  • Version: 0.24.0
  • OS: Linux Android 11 - 30
Crash log

android.app.RemoteServiceException: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{2d5f03b u0 org.schabi.newpipe.v0_24_0/org.schabi.newpipe.player.PlayerService}
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2126)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:236)
	at android.app.ActivityThread.main(ActivityThread.java:8057)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:620)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1011)


@swarupbc

This comment was marked as spam.

@Stypox
Copy link
Member Author

Stypox commented Sep 13, 2022

@Locorock could you test the apk provided in TeamNewPipe/NewPipeExtractor#927? It should fix the thumbnail issue in the feed

@Stypox
Copy link
Member Author

Stypox commented Sep 13, 2022

@SameenAhnaf regarding #8890 (comment), I tried to implement it but unfortunately it is not a good solution. The button in the top bar is actually a checkbox, so showing "hide future videos" when the button is checked and showing "show future videos" when the button is unchecked is confusing and non-standard behavior. So I think we will not change this, and at least not during the release process.
image

@ktprograms
Copy link
Contributor

Can't the hint be changed independently of the item text?

@Locorock
Copy link

Locorock commented Sep 13, 2022

Comment, crash log and screenshot for thumbnails not loading

Still getting the wrong size after importing last version's settings. I feel like this is more of a problem with the imported settings.

Exception

com.squareup.picasso.NetworkRequestHandler$ResponseException: HTTP 404
	at com.squareup.picasso.NetworkRequestHandler.load(NetworkRequestHandler.java:51)
	at com.squareup.picasso.BitmapHunter.hunt(BitmapHunter.java:219)
	at com.squareup.picasso.BitmapHunter.run(BitmapHunter.java:175)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:463)
	at java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
	at java.lang.Thread.run(Thread.java:1012)
	at com.squareup.picasso.Utils$PicassoThread.run(Utils.java:354)

Honestly no idea about what is going on, but this showed upon opening a video with the wrong thumbnail

Screenshot_2022-09-13-12-07-57-31_6ad24ba22a3388112ec0c779a3703e96 And now this

@Stypox
Copy link
Member Author

Stypox commented Sep 13, 2022

@Locorock thank you for testing. Let's try with another method. I updated the APK in TeamNewPipe/NewPipeExtractor#927, please check if this one works ;-)

@ktprograms you are right, I'm stupid 😂, I opened #8966 which should add tooltips.

@Locorock
Copy link

Locorock commented Sep 13, 2022

Screenshot, crash log and heap dump of (unrelated) Embedded info did not provide YouTube player js url

This happens as i open any video with no thumbnail
Screenshot_2022-09-13-16-00-22-01_6ad24ba22a3388112ec0c779a3703e96

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: IT
  • Content Language: it-IT
  • App Language: en
  • Service: none
  • Version: 0.24.0
  • OS: Linux Android 12 - 31
org.schabi.newpipe.extractor.exceptions.ParsingException: Could not store JavaScript player
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.storePlayerJs(YoutubeStreamExtractor.java:1104)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.initStsFromPlayerJsIfNeeded(YoutubeStreamExtractor.java:1172)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.onFetchPage(YoutubeStreamExtractor.java:826)
	at org.schabi.newpipe.extractor.Extractor.fetchPage(Extractor.java:60)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:78)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:73)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getStreamInfo$3(ExtractorHelper.java:118)
	at org.schabi.newpipe.util.ExtractorHelper$$ExternalSyntheticLambda12.call(Unknown Source:4)
	at io.reactivex.rxjava3.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:43)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.rxjava3.core.Maybe.subscribe(Maybe.java:5330)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.rxjava3.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.rxjava3.core.Flowable.subscribe(Flowable.java:15868)
	at io.reactivex.rxjava3.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.rxjava3.core.Maybe.subscribe(Maybe.java:5330)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.rxjava3.core.Scheduler$DisposeTask.run(Scheduler.java:644)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:65)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:56)
	at java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:307)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: org.schabi.newpipe.extractor.exceptions.ParsingException: Embedded info did not provide YouTube player js url
	at org.schabi.newpipe.extractor.services.youtube.YoutubeJavaScriptExtractor.extractJavaScriptUrl(YoutubeJavaScriptExtractor.java:116)
	at org.schabi.newpipe.extractor.services.youtube.YoutubeJavaScriptExtractor.extractJavaScriptCode(YoutubeJavaScriptExtractor.java:46)
	at org.schabi.newpipe.extractor.services.youtube.YoutubeJavaScriptExtractor.extractJavaScriptCode(YoutubeJavaScriptExtractor.java:65)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.storePlayerJs(YoutubeStreamExtractor.java:1102)
	... 31 more

┬───
│ GC Root: System class

├─ com.mediatek.boostfwk.identify.scroll.ScrollDispatcher class
│ Leaking: NO (a class is never leaking)
│ ↓ static ScrollDispatcher.sScrollScenario
│ ~~~~~~~~~~~~~~~
├─ com.mediatek.boostfwk.identify.scroll.ScrollIdentify instance
│ Leaking: UNKNOWN
│ Retaining 255033 bytes in 4527 objects
│ mContext instance of org.schabi.newpipe.error.ErrorActivity with
│ mDestroyed = true
│ ↓ ScrollIdentify.mContext
│ ~~~~~~~~
╰→ org.schabi.newpipe.error.ErrorActivity instance
​ Leaking: YES (ObjectWatcher was watching this because org.schabi.newpipe.
​ error.ErrorActivity received Activity#onDestroy() callback and
​ Activity#mDestroyed is true)
​ Retaining 254779 bytes in 4520 objects
​ key = 1d122c38-b757-4e2b-8f6e-568f07a01230
​ watchDurationMillis = 10165
​ retainedDurationMillis = 155
​ mApplication instance of org.schabi.newpipe.DebugApp
​ mBase instance of androidx.appcompat.view.ContextThemeWrapper, not
​ wrapping known Android context

METADATA

Build.VERSION.SDK_INT: 31
Build.MANUFACTURER: OnePlus
LeakCanary version: 2.5
App process name: org.schabi.newpipe.debug.release0240
Stats: LruCache[maxSize=3000,hits=1248,misses=154217,hitRate=0%]
RandomAccess[bytes=7282077,reads=154217,travel=111375804850,range=45919168,size=
56720354]
Analysis duration: 7212 ms
Also got this heap dump from the crash

@Stypox
Copy link
Member Author

Stypox commented Sep 13, 2022

Uhm, that's a different issue and has nothing to do with thumbnails. Try to import an old database (i.e. where the feed has not been updated in a while), reload the feed and see if the new videos's thumbnails load correctly (the thumbnails of videos that were already in the feed before reloading won't change).

@Locorock
Copy link

Locorock commented Sep 13, 2022

Yeah, seems to be working fine for the new videos

@TeamNewPipe TeamNewPipe deleted a comment from Locorock Sep 13, 2022
@TeamNewPipe TeamNewPipe deleted a comment from Locorock Sep 13, 2022
@TeamNewPipe TeamNewPipe deleted a comment from Locorock Sep 13, 2022
@Stypox
Copy link
Member Author

Stypox commented Sep 13, 2022

Thank you again for testing. Now that the issue is solved I compressed some of your comments into single comments so that they are not "in mezzo" ;-)

@Stypox
Copy link
Member Author

Stypox commented Sep 14, 2022

@AudricV and others: please check if #8972 fixes the various issues with the search suggestions list

@ktprograms
Copy link
Contributor

The Show/Hide future items long-press tooltip still doesn't change.

@Stypox
Copy link
Member Author

Stypox commented Sep 19, 2022

As explained in the PR, Android behaves in a buggy way, but if you switch tab and go back to that tab the label will be the correct one <- false

@ktprograms
Copy link
Contributor

Even when I go out and back in, or even close (and kill from the switcher) the app, it doesn't change.

@Stypox
Copy link
Member Author

Stypox commented Sep 19, 2022

Wooops you are right ;-)
I pushed a commit directly to the release-0.24.0 branch. I made a silly copy-paste mistake. See the RC3 apk.

@xz-dev
Copy link

xz-dev commented Sep 22, 2022

Small update on my prior comment. Removing the 2 secondary RF antennae on my NETGEAR XR500 router (it comes with 4) appears to have solved the issue for Youtube-encoded WebM video playback.

The strange thing is why this worked, when other apps seemed to maintain typical connectivity with all 4 antennae connected. Maybe they were interfering with each other?

I guess it's about network speed, more antennae faster speed.

@SC1040-TS2
Copy link

SC1040-TS2 commented Sep 22, 2022 via email

@anoraktrend
Copy link

Crashes when too many downloads are going at once. (More than 10.)

@opusforlife2
Copy link
Collaborator

@anoraktrend No crash on 0.23.3 with so many downloads?

@Pentaphon
Copy link

Crashes when too many downloads are going at once. (More than 10.)

That probably depends on your phone specs. Who downloads 10 videos at a time?

@n-buna404
Copy link

Newpipe by default enable limit download queue, if it happens with it enabled that is something to be investigated. If not that just the hardware being pushed to limit

@Stypox Stypox closed this as completed Sep 25, 2022
@Stypox Stypox unpinned this issue Sep 25, 2022
@opusforlife2 opusforlife2 mentioned this issue Oct 22, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests