Remove uses of setBottomSheetCallback(). #8669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
the
codequality
Stypox
requested changes
Jul 23, 2022
| @@ -208,6 +208,8 @@ | |||
| private Player player; | |||
| private final PlayerHolder playerHolder = PlayerHolder.getInstance(); | |||
|
|
|||
| private BottomSheetBehavior.BottomSheetCallback bottomSheetCallback; | |||
There was a problem hiding this comment.
Mmmh, I would put this field near setBottomSheetCallback, I think it makes more sense
There was a problem hiding this comment.
Sure, I'll make that change.
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Show resolved
Hide resolved
Isira-Seneviratne
force-pushed
the
Remove_setBottomSheetCallback
branch
from
1568f0e
to
81fb44c
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
setBottomSheetCallback()method.Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence