Fix ListHelperTest failure caused by immutable list being used #8679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
force-pushed
the
fix-listhelpertest
branch
from
0e88447
to
66048e0
Compare
Stypox
force-pushed
the
fix-listhelpertest
branch
from
66048e0
to
f4fe5fc
Compare
|
@Stypox Sorry about that. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Don't worry, it's just that the function makes a strange use of the list and did not document it. |
AudricV
approved these changes
Jul 22, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
#8631 replaced list creation with
List.of(), which creates an immutable list, but for this test we need a mutable list. I added a comment in the javadoc to explain this. This fixes the CI failing everywhere (my fault with merging #8631 once I saw it built fine on my PC, before waiting for the CI to finish). @Isira-SeneviratneDue diligence