Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide future videos in feed #8545

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

carmebar
Copy link
Contributor

@carmebar carmebar commented Jun 24, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Allows to hide videos that are not yet released. Some accounts schedule videos to be released in the future and sorting by release date makes those videos to be always on top.

Before/After Screenshots/Screen Record

Before After
Notice video release date saying "dentro de x meses" which means "in x months".

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@opusforlife2 opusforlife2 added the feed Issue is related to the feed label Jun 25, 2022
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Works well and code looks good. Thanks :-)
I pushed myself a commit for that small thing I noticed

app/src/main/res/menu/menu_feed_fragment.xml Outdated Show resolved Hide resolved
The search menu item gets added in first place when the feed fragment is added as a tab to the main fragment. So the main fragment's menu items' orderInCategory should start from 2.
@Stypox Stypox merged commit b96c8a0 into TeamNewPipe:dev Jul 13, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feed Issue is related to the feed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants