Fix various issues in the search suggestions list #8972
Conversation
The diff util wrongly considered as equal two items with the same text but with different `fromHistory` value
The animations were just in the way and did not help in choosing items, since the suggestion items keep changing too much.
Before if the list before updating contained item 'test' at position 0 and after updating that value went to the bottom, the list would incorrectly scroll to the bottom to follow that item. Now the scrolling is done after the list is updated.
Stypox
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
|
@Stypox Thanks for the improvements for my changes, I'll be checking soon. Update: It seems to be working fine, I didn't encounter any issues while testing using a couple of searches. |
|
I'm not sure if this is related or i should open a new issue but there are bugs when you trying to edit the wording of a search sentence in the search field. the other one is if you try to select multiple words using swipe select (by long pressing a certain word to activate select, then moving right and left while holding) it will work but in a broken way.. the swipe select will work but the point of activation would jump from the word you long pressed to the first word of the search sentence Update: |
|
off topic by a little but since the title says fix various issues in the search suggestion list, if suggestqueries.google.com is blocked, if we type something in the search box, there will be multiple warnings at the bottom of the screen, "Sorry, Something went wrong" Report. can we not show this? edit:missing words |
Why not turn off search suggestions if you don't want them? |
|
didn't know it was there. thanks. but shouldn't the error be more specific like search suggestion error or something. |
|
You could open a new issue for that. |
What is it?
Description of the changes in your PR
This PR fixes the various issues that arose after upgrading the search suggestions list code in #8719: inconsistent item icons on the left sometimes (e.g. history icon when the item is not from history), strange item movements when changing the list, strange scrolling behavior when the suggestions change (i.e. not scrolling always to the top on change). See the three commits' messages for more information. @Isira-Seneviratne could you review?
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence