[pull] main from apache:main

[pull]

See Commits and Changes for more details.

---

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Enhance DataFusion's support for ordered-set aggregate functions by introducing a WITHIN GROUP clause for functions like approx_percentile_cont

New Features:

• Add support for WITHIN GROUP clause in aggregate functions
• Implement ordered-set aggregate function semantics

Enhancements:

• Modify approx_percentile_cont to support sorting and percentile calculation
• Update function argument parsing to handle WITHIN GROUP clause
• Improve aggregate function documentation to reflect new syntax

Documentation:

• Update documentation for approx_percentile_cont and approx_median to show new WITHIN GROUP syntax
• Add explanations for ordered-set aggregate function behavior

[gitstream-cm]

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 8014/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors the approx_percentile_cont and approx_percentile_cont_with_weight aggregate functions to use the SQL standard's WITHIN GROUP (ORDER BY) clause. It also adds validation to ensure that ORDER BY clause is only permitted in WITHIN GROUP clause when a WITHIN GROUP is used, OVER and WITHIN GROUP clause cannot be used together, and WITHIN GROUP clause is required when calling ordered set aggregate function.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Refactors approx_percentile_cont and approx_percentile_cont_with_weight to align with the SQL standard's WITHIN GROUP (ORDER BY) clause.	Updates the function signatures to accept ordering expressions. Modifies the function calls to use the WITHIN GROUP (ORDER BY) syntax. Adjusts the internal logic to handle the ordering within the aggregation. Updates documentation and examples to reflect the new syntax.	datafusion/core/tests/dataframe/dataframe_functions.rs datafusion/sql/src/expr/function.rs datafusion/functions-aggregate/src/approx_percentile_cont.rs datafusion/expr/src/udaf.rs docs/source/user-guide/sql/aggregate_functions.md datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs datafusion/sql/src/unparser/expr.rs datafusion/core/benches/aggregate_query_sql.rs datafusion/proto/tests/cases/roundtrip_logical_plan.rs datafusion/functions-aggregate/src/approx_median.rs datafusion/proto/tests/cases/roundtrip_physical_plan.rs datafusion/sqllogictest/test_files/aggregate.slt
Implements is_ordered_set_aggregate to indicate if a function is an ordered-set aggregate function.	Adds a new trait method is_ordered_set_aggregate to the AggregateUDFImpl trait. Implements the new trait method for ApproxPercentileCont and ApproxPercentileContWithWeight to return true. Updates the schema name generation to include the WITHIN GROUP clause for ordered-set aggregate functions.	datafusion/sql/src/expr/function.rs datafusion/functions-aggregate/src/approx_percentile_cont.rs datafusion/expr/src/udaf.rs datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs
Adds validation to ensure that ORDER BY clause is only permitted in WITHIN GROUP clause when a WITHIN GROUP is used.	Adds a check to ensure that ORDER BY clause is only permitted in WITHIN GROUP clause when a WITHIN GROUP is used.	datafusion/sql/src/expr/function.rs
Adds validation to ensure that OVER and WITHIN GROUP clause cannot be used together.	Adds a check to ensure that OVER and WITHIN GROUP clause cannot be used together.	datafusion/sql/src/expr/function.rs
Adds validation to ensure that WITHIN GROUP clause is required when calling ordered set aggregate function.	Adds a check to ensure that WITHIN GROUP clause is required when calling ordered set aggregate function.	datafusion/sql/src/expr/function.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.