Update Upgrade Guide for 48.0.1 #16699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
alamb
commented
Jul 7, 2025
| :caption: Library User Guide | ||
|
|
||
| library-user-guide/index | ||
| library-user-guide/upgrading |
Contributor
Author
There was a problem hiding this comment.
I moved the upgrade link up higher in the index so it was easier to find
comphead
reviewed
Jul 7, 2025
Comment on lines
+135
to
+139
| # /* comment to avoid running | ||
| ListingOptions::new(Arc::new(ParquetFormat::default())) | ||
| .with_collect_stat(false) | ||
| // other options | ||
| # */ |
Contributor
There was a problem hiding this comment.
Suggested change
| # /* comment to avoid running | |
| ListingOptions::new(Arc::new(ParquetFormat::default())) | |
| .with_collect_stat(false) | |
| // other options | |
| # */ | |
| /* comment to avoid running | |
| ListingOptions::new(Arc::new(ParquetFormat::default())) | |
| .with_collect_stat(false) | |
| // other options | |
| */ |
Not sure why those hashes were needed
Contributor
Author
There was a problem hiding this comment.
The # hides the comments from the docs (so /* comment to avoid running doesn't show up in the docs)
comphead
approved these changes
Jul 7, 2025
Contributor
Author
|
Thank you for the review @comphead -- i am going to merge this in ASAP as we have already released 48.0.1 and it would be nice to have this doc in place |
Contributor
Author
|
I am happy to make any other suggested changes as a follow on PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
48.0.1#16486Rationale for this change
We back ported the default setting for statistics
datafusion.execution.collect_statisticsto 48.0.1 so we should update the upgrade guide to reflect thatWhat changes are included in this PR?
Are these changes tested?
by CI
Are there any user-facing changes?
Upgrade guide