Clarify the generality of the embedded parquet index#16692
Merged
alamb merged 1 commit intoapache:mainfrom Jul 7, 2025
Merged
Conversation
zhuqi-lucas
approved these changes
Jul 6, 2025
Contributor
zhuqi-lucas
left a comment
zhuqi-lucas
left a comment
There was a problem hiding this comment.
LGTM Thank you @alamb !
xudong963
approved these changes
Jul 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
@JigaoLuo notes in #16374 (comment) that it may not be clear this approach can be used for any type of index, so let's try and make that clearer in the comments
What changes are included in this PR?
datafusion-examples/examples/parquet_embedded_index.rsclarifying the scope of the available indexesAre these changes tested?
By CI
Are there any user-facing changes?
Just docs