Skip to content

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Aug 16, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Issue mentioned here

Steps to test or reproduce

Further comments

Note: this PR was built on top of #26147 to fix the issue raised by QA

@murtaza98 murtaza98 requested a review from a team as a code owner August 16, 2022 12:03
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #26575 (924ff1a) into develop (f0ad004) will increase coverage by 0.66%.
The diff coverage is n/a.

❗ Current head 924ff1a differs from pull request most recent head c5c9f8d. Consider uploading reports for the commit c5c9f8d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26575      +/-   ##
===========================================
+ Coverage    37.97%   38.64%   +0.66%     
===========================================
  Files          778      751      -27     
  Lines        18854    18670     -184     
  Branches      1932     1453     -479     
===========================================
+ Hits          7160     7215      +55     
+ Misses       11400    11237     -163     
+ Partials       294      218      -76     
Flag Coverage Δ
e2e 38.64% <ø> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 requested a review from a team as a code owner August 16, 2022 14:08
@murtaza98 murtaza98 changed the title [FIX] Agents (with user status offline & omni-status as available) not able to take chat [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat Aug 16, 2022
@murtaza98 murtaza98 changed the title [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat Regression: Agents (with user status offline & omni-status as available) not able to take or forward chat Aug 16, 2022
@murtaza98 murtaza98 added this to the 5.1.0 milestone Aug 16, 2022
KevLehman
KevLehman previously approved these changes Aug 16, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 16, 2022
@ggazzo
Copy link
Member

ggazzo commented Aug 17, 2022

three things,

  • I dont like the condition way we use on autocomplete, but ok we are already using (just be prepared to create a new endpoint to perform this action properly).
  • second, can we test this case? :x
  • is this actually a regression?

@KevLehman KevLehman changed the title Regression: Agents (with user status offline & omni-status as available) not able to take or forward chat [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat Aug 17, 2022
@KevLehman
Copy link
Member

Lol, no, this is not a regression. Changed the title.

The other 2 points, @murtaza98 :trollface:

@murtaza98
Copy link
Contributor Author

murtaza98 commented Aug 18, 2022

  1. Yeah, I wasn't proud of that either, however since we're still using the generic UserAutoComplete component here which accepts raw conditions, I had to follow the same approach 😓 This seems like a good task for eng days so let me add it to that roadmap.
  2. Sure, let me try to add some tests here
  3. Yeah these were fixes indeed 🙈 but they were found by the QA team while reviewing the other PR.

ggazzo
ggazzo previously requested changes Aug 19, 2022
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a special test waiting the agent number 2 get online to transfer

	await test.step('Expect to connect as agent 2', async () => {
			agent2 = await createAuxContext(browser, 'user2-session.json'); <---- HERE
		

please create a second test trying to assign to a offline agent as well

thanks

@murtaza98
Copy link
Contributor Author

we have a special test waiting the agent number 2 get online to transfer

	await test.step('Expect to connect as agent 2', async () => {
			agent2 = await createAuxContext(browser, 'user2-session.json'); <---- HERE
		

please create a second test trying to assign to a offline agent as well

thanks

Added this test case as well here ✔️

@murtaza98 murtaza98 dismissed stale reviews from sampaiodiego and ggazzo August 23, 2022 12:04

Changes done

@kodiakhq kodiakhq bot merged commit 34bd266 into develop Aug 23, 2022
@kodiakhq kodiakhq bot deleted the omni/offline-agents-allowed-1 branch August 23, 2022 13:05
gabriellsh added a commit that referenced this pull request Aug 24, 2022
…ove/otr-message

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  [FIX] Slack User CSV importer not working (#26629)
  Chore: Importer rest types, meteor methods to TS and API unit tests (#26284)
  [NEW] Adding oauth crud on the rocket.chat side (#26220)
  [NEW] allow ephemeral messages to receive a specific id (#26118)
  [FIX] MDM content alignment (#26665)
  Chore: Permissions check per endpoint/method (#26419)
  Regression: CI (#26658)
  [FIX] Not allowed error in discussion room with a private parent channel (#26394)
  Chore: Fix grammatical typo when only one message is pruned (#21902)
  [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575)
  i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645)
  Chore: Add license env var to ee tests (#26650)
  Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653)
  Regression: Custom status loading forever in Usercard (#26656)
  [FIX] Current Chat Custom Field Filter (#26200)
  Chore: Migrate modules related to `room` template to TypeScript (#25881)
  Chore: Create teams management tests (#26578)
csuadev pushed a commit that referenced this pull request Aug 26, 2022
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants