-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Chore: Permissions check per endpoint/method #26419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request introduces 1 alert when merging 3ccbcc2 into 133aa10 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 99f892e into 133aa10 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging c621332 into f555889 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 2224425 into f555889 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## develop #26419 +/- ##
===========================================
+ Coverage 38.46% 38.49% +0.02%
===========================================
Files 794 794
Lines 19002 19002
Branches 1937 1937
===========================================
+ Hits 7310 7315 +5
+ Misses 11400 11395 -5
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This pull request introduces 1 alert when merging f93d50a into 0343424 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 272ce1b into 0343424 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 7ddd888 into 0343424 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 62fc70a into 2ebd463 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging b025cc9 into 37d8f59 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 4caff1e into 37d8f59 - view on LGTM.com new alerts:
|
…et.Chat into chore/permissions-on-api
sampaiodiego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR ended up adding a lot of other omnichannel changes, right? should the title be changed?
…ove/otr-message * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) [FIX] Slack User CSV importer not working (#26629) Chore: Importer rest types, meteor methods to TS and API unit tests (#26284) [NEW] Adding oauth crud on the rocket.chat side (#26220) [NEW] allow ephemeral messages to receive a specific id (#26118) [FIX] MDM content alignment (#26665) Chore: Permissions check per endpoint/method (#26419) Regression: CI (#26658) [FIX] Not allowed error in discussion room with a private parent channel (#26394) Chore: Fix grammatical typo when only one message is pruned (#21902) [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575) i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645) Chore: Add license env var to ee tests (#26650) Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653) Regression: Custom status loading forever in Usercard (#26656) [FIX] Current Chat Custom Field Filter (#26200) Chore: Migrate modules related to `room` template to TypeScript (#25881) Chore: Create teams management tests (#26578)
Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
Note: most files changed are conversions to use the implemented permissions param 👀 so don't worry to see 40 files.
The idea:
operation: hasAll | hasAnyprop to signal how permissions should be evaluated, if inclusively or exclusively.:)
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments