Skip to content

Conversation

@souzaramon
Copy link
Contributor

@souzaramon souzaramon commented Aug 16, 2022

Proposed changes (including videos or screenshots)

  • add tests for team management

@souzaramon souzaramon force-pushed the test/teams-management branch from 479429b to a588772 Compare August 17, 2022 14:00
@souzaramon souzaramon force-pushed the test/teams-management branch from a588772 to 73ee657 Compare August 17, 2022 14:01
@souzaramon souzaramon force-pushed the test/teams-management branch from 4a0aa4b to 148d37f Compare August 22, 2022 12:37
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #26578 (cfe258e) into develop (6e3306b) will increase coverage by 0.34%.
The diff coverage is n/a.

❗ Current head cfe258e differs from pull request most recent head 6fc864d. Consider uploading reports for the commit 6fc864d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26578      +/-   ##
===========================================
+ Coverage    38.71%   39.05%   +0.34%     
===========================================
  Files          751      764      +13     
  Lines        18670    18911     +241     
  Branches      1453     1459       +6     
===========================================
+ Hits          7228     7386     +158     
- Misses       11225    11302      +77     
- Partials       217      223       +6     
Flag Coverage Δ
e2e 39.05% <ø> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@souzaramon souzaramon marked this pull request as ready for review August 22, 2022 14:36
@souzaramon souzaramon requested a review from a team as a code owner August 22, 2022 14:36
@ggazzo ggazzo changed the title Chore: create teams management tests Chore: Create teams management tests Aug 22, 2022
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 22, 2022
@kodiakhq kodiakhq bot merged commit 5be9725 into develop Aug 22, 2022
@kodiakhq kodiakhq bot deleted the test/teams-management branch August 22, 2022 16:58
gabriellsh added a commit that referenced this pull request Aug 22, 2022
…/room

* 'fix/room' of github.com:RocketChat/Rocket.Chat:
  Chore: Create teams management tests (#26578)
gabriellsh added a commit that referenced this pull request Aug 24, 2022
…ove/otr-message

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  [FIX] Slack User CSV importer not working (#26629)
  Chore: Importer rest types, meteor methods to TS and API unit tests (#26284)
  [NEW] Adding oauth crud on the rocket.chat side (#26220)
  [NEW] allow ephemeral messages to receive a specific id (#26118)
  [FIX] MDM content alignment (#26665)
  Chore: Permissions check per endpoint/method (#26419)
  Regression: CI (#26658)
  [FIX] Not allowed error in discussion room with a private parent channel (#26394)
  Chore: Fix grammatical typo when only one message is pruned (#21902)
  [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575)
  i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645)
  Chore: Add license env var to ee tests (#26650)
  Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653)
  Regression: Custom status loading forever in Usercard (#26656)
  [FIX] Current Chat Custom Field Filter (#26200)
  Chore: Migrate modules related to `room` template to TypeScript (#25881)
  Chore: Create teams management tests (#26578)
csuadev pushed a commit that referenced this pull request Aug 26, 2022
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants