Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 22, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #26650 (b74dbb8) into develop (f0ad004) will increase coverage by 0.69%.
The diff coverage is n/a.

❗ Current head b74dbb8 differs from pull request most recent head 050aa61. Consider uploading reports for the commit 050aa61 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26650      +/-   ##
===========================================
+ Coverage    37.97%   38.67%   +0.69%     
===========================================
  Files          778      751      -27     
  Lines        18854    18668     -186     
  Branches      1932     1453     -479     
===========================================
+ Hits          7160     7220      +60     
+ Misses       11400    11232     -168     
+ Partials       294      216      -78     
Flag Coverage Δ
e2e 38.67% <ø> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review August 22, 2022 15:51
@ggazzo ggazzo requested a review from a team as a code owner August 22, 2022 15:51
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to set the env var in the compose file

@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 22, 2022
@kodiakhq kodiakhq bot merged commit 4c412cd into develop Aug 23, 2022
@kodiakhq kodiakhq bot deleted the chore/ee-license branch August 23, 2022 02:04
gabriellsh added a commit that referenced this pull request Aug 24, 2022
…ove/otr-message

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  [FIX] Slack User CSV importer not working (#26629)
  Chore: Importer rest types, meteor methods to TS and API unit tests (#26284)
  [NEW] Adding oauth crud on the rocket.chat side (#26220)
  [NEW] allow ephemeral messages to receive a specific id (#26118)
  [FIX] MDM content alignment (#26665)
  Chore: Permissions check per endpoint/method (#26419)
  Regression: CI (#26658)
  [FIX] Not allowed error in discussion room with a private parent channel (#26394)
  Chore: Fix grammatical typo when only one message is pruned (#21902)
  [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575)
  i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645)
  Chore: Add license env var to ee tests (#26650)
  Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653)
  Regression: Custom status loading forever in Usercard (#26656)
  [FIX] Current Chat Custom Field Filter (#26200)
  Chore: Migrate modules related to `room` template to TypeScript (#25881)
  Chore: Create teams management tests (#26578)
csuadev pushed a commit that referenced this pull request Aug 26, 2022
Co-authored-by: Diego Sampaio <8591547+sampaiodiego@users.noreply.github.com>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants