[features] Better indices and looping #3447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
commented
Oct 30, 2019
|
This pull request has been automatically marked as stale because it hasn't had Come back whenever you have time. We look forward to your contribution. |
kunaltyagi
force-pushed
the
std_size_features
branch
from
bde7913
to
c7c779c
Compare
|
@taketwo This is nearly complete. Should I organize commits by file since that seems the best way to ingest the large changes? |
kunaltyagi
force-pushed
the
std_size_features
branch
5 times, most recently
from
bc1e908
to
224a6a8
Compare
|
Ideally, split this into multiple PRs. I'm afraid I won't have a free chunk of time long enough to click through 45 commits at once. |
|
Most commits are a few lines. I'll create a PR from the first commit (which is the meatiest and sort-of makes more sense). The rest, I might group arbitrarily. |
kunaltyagi
force-pushed
the
std_size_features
branch
from
224a6a8
to
bd1fd3b
Compare
kunaltyagi
force-pushed
the
std_size_features
branch
2 times, most recently
from
950be79
to
ee3bd9b
Compare
…ons for better code
kunaltyagi
force-pushed
the
std_size_features
branch
from
ee3bd9b
to
d7fd8b0
Compare
|
Closing since other PR supersede this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting internal indices to
std::size_tor smarter loops