Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better indices in loops #3543

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Better indices in loops #3543

merged 2 commits into from
Jan 13, 2020

Conversation

kunaltyagi
Copy link
Member

Converting internal indices to std::size_t.

Part 1 of N, as advised in #3447 (comment)

@kunaltyagi kunaltyagi changed the title [features] Better indices and looping [features] Better indices in loops Jan 11, 2020
@taketwo
Copy link
Member

taketwo commented Jan 11, 2020

First and third LGTM, but can you please explain the second commit?

@kunaltyagi
Copy link
Member Author

OpenMP loop indices need to be signed. The compiler will throw a huff otherwise

taketwo
taketwo approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe squash the first two?

@kunaltyagi
[int, size_t] -> std::size_t with minimal changes
693ed60 
Using std::ptrdiff_t for OpenMP
Pretty nice since that will the future index (IMO)
@kunaltyagi
Converting one loop to algo for compilation
f57e624
@kunaltyagi kunaltyagi merged commit 41a1f1b into PointCloudLibrary:master Jan 13, 2020
@kunaltyagi kunaltyagi deleted the std_size_feature_part1 branch January 13, 2020 03:03
@taketwo taketwo changed the title [features] Better indices in loops Better indices in loops Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunaltyagi @taketwo