Skip to content

Add parsing support for arcane surge and implement non gem arcane surge #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 1, 2023
Merged

Add parsing support for arcane surge and implement non gem arcane surge #4541

merged 19 commits into from
Apr 1, 2023

Conversation

@QuickStick123
Copy link
Contributor

@QuickStick123 QuickStick123 commented Jul 9, 2022 •
edited
Loading

["^([%+%-]?%d+)%% chance to gain "] = "FLAG",
This lets chance mods to be passed as giving the mod.

Fixes #384.

Description of the problem being solved:

Arcane surge is not passed very well and the base effect variant is not supported. Other buff conditionals aren't supported as well.

Steps taken to verify a working solution:

  • Arcane surge is now apply on conditional as well as other buffs at 10% more damage and 30% mana regen which is the scaled accordingly this is only added if gem arcane surge is not present as checked after gem buff passes.
  • Didn't fix "Your Raised Spectres also gain Arcane Surge when you do" as wasn't sure how to.

Link to a build that showcases this PR:

https://pastebin.com/L2AC33Lp

Before screenshot:

image
image
image
image

After screenshot:

image
image
image
image

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Jul 9, 2022
@QuickStick123 QuickStick123 changed the title Fix all sources of arcane surge passing also improve passing of other buffs Add passing support to all sources of arcane surge and implement non gem arcane surge Jul 9, 2022
Wires77
Wires77 requested changes Jul 11, 2022
View reviewed changes
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few changes I noted, also a lot of the ailment code changed with recent PRs, so you'll want to fix those conflicts

src/Modules/ConfigOptions.lua
Comment on lines 1037 to 1102
{ var = "DetonatedMinesRecently", type = "check", label = "Have you Detonated a Mine Recently", ifCond = "DetonatedMinesRecently", apply = function(val, modList, enemyModList)
modList:NewMod("Condition:DetonatedMinesRecently", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
end },
{ var = "multiplierMineDetonatedRecently", type = "count", label = "# of Mines Detonated Recently:", ifMult = "MineDetonatedRecently", implyCond = "DetonatedMinesRecently", apply = function(val, modList, enemyModList)
modList:NewMod("Multiplier:MineDetonatedRecently", "BASE", val, "Config", { type = "Condition", var = "Combat" })
end },
{ var = "multiplierTrapTriggeredRecently", type = "count", label = "# of Traps Triggered Recently:", ifMult = "TrapTriggeredRecently", apply = function(val, modList, enemyModList)
{ var = "TriggeredTrapRecently", type = "check", label = "Have you Triggered a Trap Recently?", ifCond = "TriggeredTrapRecently", apply = function(val, modList, enemyModList)
modList:NewMod("Condition:TriggeredTrapRecently", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
end },
{ var = "multiplierTrapTriggeredRecently", type = "count", label = "# of Traps Triggered Recently:", ifMult = "TrapTriggeredRecently", implyCond = "TriggeredTrapRecently", apply = function(val, modList, enemyModList)
Copy link
Member

@Wires77 Wires77 Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just check for values > 0 for these config options instead of adding new checkboxes?

Copy link
Contributor Author

@QuickStick123 QuickStick123 Jul 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DetonatedMinesRecently was already a condition used for this but was only set when the main skill was a mine skill. This adds a checkbox for it and adds a trap one as well then uses it to implement the new mods. As someone might like to enables these buffs when they are using mines/traps to trigger a buff or similar.

@QuickStick123 QuickStick123 changed the title Add passing support to all sources of arcane surge and implement non gem arcane surge Add passing support for arcane surge and implement non gem arcane surge Jul 15, 2022
@QuickStick123 QuickStick123 mentioned this pull request Aug 12, 2022
Merged
@QuickStick123 QuickStick123 mentioned this pull request Aug 12, 2022
Merged
@QuickStick123
Fix all sources of arcane surge passing also improve passing of other…
08220f8 
… buffs.
@QuickStick123
Address most requested changes.
7f43b91
@QuickStick123
clean up some white spaces.
8227e46
@QuickStick123
fix non-damaging ailment effect and add types to data.
45c619e
@QuickStick123
fix merge mistakes
36a13e1
@QuickStick123
Switch channelling to time
f28ba17
@QuickStick123
Squashed commit of the following:
3345c74 
commit a449985
Author: Nostrademous <nostrademous@hotmail.com>
Date:   Sat Aug 13 23:32:53 2022 -0400

    Add support for negative levels to gems (PathOfBuildingCommunity#4756)

commit fa4aa64
Author: Nostrademous <nostrademous@hotmail.com>
Date:   Sat Aug 13 23:25:51 2022 -0400

    Fix Thrusting swords were not a base subType (PathOfBuildingCommunity#4720)

    * Fix: Thrusting should be a base subType

    * Same changes but with less diff

    Co-authored-by: Wires77 <Wires77@users.noreply.github.com>

commit 9eddc38
Author: Tomas Slusny <slusnucky@gmail.com>
Date:   Sun Aug 14 05:11:25 2022 +0200

    Fix crash when deleting the current skill set (PathOfBuildingCommunity#4772)

    When removing it from table this causes crash when rebuilding skill set
    dropdown.

    Closes PathOfBuildingCommunity#4771

    Signed-off-by: Tomas Slusny <ts6234@intl.att.com>

    Signed-off-by: Tomas Slusny <ts6234@intl.att.com>
    Co-authored-by: Tomas Slusny <ts6234@intl.att.com>

commit f8298d7
Author: Lexy <learn2draw@live.nl>
Date:   Sun Aug 14 04:41:45 2022 +0200

    [Kalandra] Update Bitterdream (PathOfBuildingCommunity#4702)

    * update bitterdream

    * Remove legacy bitterdream variants

commit bc0da55
Author: Paliak <91493239+Paliak@users.noreply.github.com>
Date:   Sun Aug 14 04:38:17 2022 +0200

    FEAT: Add parsing for triple damage mods (PathOfBuildingCommunity#4727)

commit 37e8867
Author: Nostrademous <nostrademous@hotmail.com>
Date:   Sat Aug 13 22:37:51 2022 -0400

    [Kalandra] Add support for counting Mastery Type allocations (PathOfBuildingCommunity#4746)

    * Feat: Add support for counting Mastery Type allocations

    * added support for on kill portion of ascendancy node

    * Fix spacing

commit f61b17a
Author: Nightblade <Nightblade@users.noreply.github.com>
Date:   Sun Aug 14 12:36:57 2022 +1000

    [Kalandra] Update Ngamahu's Sign (PathOfBuildingCommunity#4755)

    * Update ring.lua

    Ngamahu's Sign - Perfect
    (My first one someone check it please!)

    * remove {variant:1,2,3} not needed

commit 14151f8
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 12:34:18 2022 +1000

    [Kalandra] Add new uniques (PathOfBuildingCommunity#4774)

    * add new uniques

    * Add new Grand Spectrum Jewels

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 2dd0cde
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 11:15:06 2022 +1000

    Update replica bitterdream(PathOfBuildingCommunity#4775)

commit 9b9c49f
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 11:12:56 2022 +1000

    Add support for Arrow Dancing (PathOfBuildingCommunity#4779)

commit f468faa
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 11:06:59 2022 +1000

    [Kalandra] Update batch 4 of uniques. (PathOfBuildingCommunity#4757)

    * update uniques

    * added movement on throwing a trap.

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 54d1740
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:57:50 2022 +1000

    Update sources of longer obtainable uniques (PathOfBuildingCommunity#4748)

    * No longer obtainable

    * Cameria's Avarice now obtainable from vendor recipe.

commit 0961142
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:54:36 2022 +1000

    update uniques (PathOfBuildingCommunity#4754)

commit 3052165
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:49:46 2022 +1000

    [Kalandra] Update batch 2 of uniques. (PathOfBuildingCommunity#4751)

    * set2 update uniques.

    * Fix bug with wording.

    * Change to use PercentStat

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit fe51e95
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:43:59 2022 +1000

    Update Manastorm and Kongming's Stratagem to new bases (PathOfBuildingCommunity#4783)

commit 456c70d
Author: LocalIdentity <localidentity2@gmail.com>
Date:   Sun Aug 14 10:25:33 2022 +1000

    Fix Suppression mastery

commit 49dd720
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:20:12 2022 +1000

    [Kalandra] Update batch 1 of uniques. (PathOfBuildingCommunity#4747)

    * update

    * Update ModParser.lua

    * Update boots.lua

    * Update ModParser.lua

    * support

    * Remove Covered in Ash mod parsing

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 54c24b5
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 09:53:41 2022 +1000

    Add support for minions have Unholy Might (PathOfBuildingCommunity#4780)

commit c65c194
Author: Lexy <learn2draw@live.nl>
Date:   Sun Aug 14 01:23:47 2022 +0200

    Update brittle values (PathOfBuildingCommunity#4696)

commit 6cc2124
Author: Lexy <learn2draw@live.nl>
Date:   Sat Aug 13 23:14:54 2022 +0200

    Update ward recharge speed (PathOfBuildingCommunity#4697)

commit dd240b9
Author: Nightblade <Nightblade@users.noreply.github.com>
Date:   Sat Aug 13 11:58:36 2022 +1000

    Update ring.lua (PathOfBuildingCommunity#4773)

    spelling

commit 1fa9ab4
Author: LocalIdentity <localidentity2@gmail.com>
Date:   Sat Aug 13 11:18:25 2022 +1000

    Compact parsing of weapon types for multistrike

commit c1903af
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 02:53:33 2022 +0200

    Fix: Multistrike damage calculation with skills which have bow and melee Tag (PathOfBuildingCommunity#4740)

    * wording of blood of karui fixed

    * undo messy work

    * damage and atk increase only applies to melee weapons and unarmed

    * added less attack damage modifier to also apply to bows

    * adding ModFlag.Attack Condition with bit.bor

    * Add lines to export files

    Co-authored-by: Sinured <githubmm@use.startmail.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 5d94436
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 01:51:28 2022 +0200

    Fix: Blood of the Karui Life recovered and wording  (PathOfBuildingCommunity#4729)

    * wording of blood of karui fixed

    * Fix: increased life recovered of current version

    * changed wording for Blood of the karui and Lavianga's Spirit

    * fixed order and wording

    * Capitalised Flask Effect

    Co-authored-by: Sinured <githubmm@use.startmail.com>

commit e5ddd8e
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 01:47:56 2022 +0200

    [Kalandra] Batch of uniques update. All missing starting with S (PathOfBuildingCommunity#4753)

    * all missing uniques starting with S

    * minions deal no non damage & minions convert phys to xyz

    * testcommit to check busted

    * Fix mod parsing format

    Co-authored-by: Sinured <githubmm@use.startmail.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 701e719
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 01:22:08 2022 +0200

    Batch of uniques update. All missingfrom D to L (PathOfBuildingCommunity#4769)

    Co-authored-by: Sinured <githubmm@use.startmail.com>

commit f17690d
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 00:52:07 2022 +0200

    [Kalandra] Lifetap & Blessing interaction (PathOfBuildingCommunity#4752)

    * wording of blood of karui fixed

    * undo messy work

    * lifetap cant support skills with blessing tag

    * testcommit to check busted

    Co-authored-by: Sinured <githubmm@use.startmail.com>

commit d7d91f9
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 00:49:26 2022 +0200

    [Kalandra]Batch of uniques update. All missing starting with R (PathOfBuildingCommunity#4760)

    * item variants for R added

    * implements Ralakesh's Impatience unique affix

    * Add parsing for always Freeze, Shock and Ignite

    Co-authored-by: Sinured <githubmm@use.startmail.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 0bfc259
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 00:28:25 2022 +0200

    uniques variants added (PathOfBuildingCommunity#4763)

    Co-authored-by: Sinured <githubmm@use.startmail.com>

commit 4c8127c
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 00:14:26 2022 +0200

    [Kalandra] Batch of unique update. All remaining from M to O (PathOfBuildingCommunity#4767)

    * adds remaining unique batch from M to O

    * Fix Ondar's Clasp variant

    Co-authored-by: Sinured <githubmm@use.startmail.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit c855506
Author: Regisle <49933620+Regisle@users.noreply.github.com>
Date:   Sat Aug 13 07:31:06 2022 +0930

    Add 3.19 Tree (PathOfBuildingCommunity#4744)

    * add Initial support for adding non-Tree nodes to Tree (Nine lives)

    * update positions and add other dummy nodes

    * separate stats and reminder text and add new nodes

    * rest of nodes

    * Fix comma

    * fix spelling of sapped

    * update spec.lua for passiveSkills

    * remove unrelated spec

    * update file to hardcode group and node IDs, and correct ascendency

    * update to new tree

    * add initial 3_19 tree

    * spelling fix

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 78d1390
Author: Nostrademous <nostrademous@hotmail.com>
Date:   Fri Aug 12 13:47:50 2022 -0400

    Fix: when upconverting between trees, if a Mastery lost a mod from its pool that was allocated it would error (PathOfBuildingCommunity#4765)

commit c819a68
Author: Regisle <49933620+Regisle@users.noreply.github.com>
Date:   Sat Aug 13 01:24:04 2022 +0930

    Update fix_ascendancy_positions.py to support new extra tree nodes (PathOfBuildingCommunity#4357)

    * add Initial support for adding non-Tree nodes to Tree (Nine lives)

    * update positions and add other dummy nodes

    * separate stats and reminder text and add new nodes

    * rest of nodes

    * Fix comma

    * fix spelling of sapped

    * update spec.lua for passiveSkills

    * remove unrelated spec

    * update file to hardcode group and node IDs, and correct ascendency

    * update to new tree

    * spelling fix

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 872d4e2
Author: Regisle <49933620+Regisle@users.noreply.github.com>
Date:   Fri Aug 12 18:42:10 2022 +0930

    Jugg armour applies to ele damage (PathOfBuildingCommunity#4673)

    * Add support for % of armour applies to elemental damage

    * add mod parser change

    * cap percent of armour

    * fix merge conflict

    * add breakdown and fix phys not apply

    * add to main breakdown
@QuickStick123
Revert "Squashed commit of the following:"
b0ebcd7 
This reverts commit 1d7c641.
@QuickStick123 QuickStick123 changed the title Add passing support for arcane surge and implement non gem arcane surge Add parsing support for arcane surge and implement non gem arcane surge Jan 2, 2023
@QuickStick123 QuickStick123 mentioned this pull request Jan 7, 2023
Merged
@QuickStick123
Copy link
Contributor Author

QuickStick123 commented Mar 31, 2023

Added a commit to update the arcane surge implementation to 3.21 the arcane surge more damage on the gem is currently just treated as equivalent cast speed and will need to be fixed once gem data gets exported.

@Wires77 Wires77 merged commit 30662db into PathOfBuildingCommunity:dev Apr 1, 2023
@QuickStick123 QuickStick123 deleted the arcane-surge-fix- branch April 6, 2023 01:50
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
@QuickStick123 @Dullson
Add parsing support for arcane surge and implement non gem arcane sur…
4d45dae 
…ge (PathOfBuildingCommunity#4541)

* Fix all sources of arcane surge passing also improve passing of other buffs.

* Address most requested changes.

* clean up some white spaces.

* fix non-damaging ailment effect and add types to data.

* fix merge mistakes

* Switch channelling to time

* Squashed commit of the following:

commit a449985
Author: Nostrademous <nostrademous@hotmail.com>
Date:   Sat Aug 13 23:32:53 2022 -0400

    Add support for negative levels to gems (PathOfBuildingCommunity#4756)

commit fa4aa64
Author: Nostrademous <nostrademous@hotmail.com>
Date:   Sat Aug 13 23:25:51 2022 -0400

    Fix Thrusting swords were not a base subType (PathOfBuildingCommunity#4720)

    * Fix: Thrusting should be a base subType

    * Same changes but with less diff

    Co-authored-by: Wires77 <Wires77@users.noreply.github.com>

commit 9eddc38
Author: Tomas Slusny <slusnucky@gmail.com>
Date:   Sun Aug 14 05:11:25 2022 +0200

    Fix crash when deleting the current skill set (PathOfBuildingCommunity#4772)

    When removing it from table this causes crash when rebuilding skill set
    dropdown.

    Closes PathOfBuildingCommunity#4771

    Signed-off-by: Tomas Slusny <ts6234@intl.att.com>

    Signed-off-by: Tomas Slusny <ts6234@intl.att.com>
    Co-authored-by: Tomas Slusny <ts6234@intl.att.com>

commit f8298d7
Author: Lexy <learn2draw@live.nl>
Date:   Sun Aug 14 04:41:45 2022 +0200

    [Kalandra] Update Bitterdream (PathOfBuildingCommunity#4702)

    * update bitterdream

    * Remove legacy bitterdream variants

commit bc0da55
Author: Paliak <91493239+Paliak@users.noreply.github.com>
Date:   Sun Aug 14 04:38:17 2022 +0200

    FEAT: Add parsing for triple damage mods (PathOfBuildingCommunity#4727)

commit 37e8867
Author: Nostrademous <nostrademous@hotmail.com>
Date:   Sat Aug 13 22:37:51 2022 -0400

    [Kalandra] Add support for counting Mastery Type allocations (PathOfBuildingCommunity#4746)

    * Feat: Add support for counting Mastery Type allocations

    * added support for on kill portion of ascendancy node

    * Fix spacing

commit f61b17a
Author: Nightblade <Nightblade@users.noreply.github.com>
Date:   Sun Aug 14 12:36:57 2022 +1000

    [Kalandra] Update Ngamahu's Sign (PathOfBuildingCommunity#4755)

    * Update ring.lua

    Ngamahu's Sign - Perfect
    (My first one someone check it please!)

    * remove {variant:1,2,3} not needed

commit 14151f8
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 12:34:18 2022 +1000

    [Kalandra] Add new uniques (PathOfBuildingCommunity#4774)

    * add new uniques

    * Add new Grand Spectrum Jewels

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 2dd0cde
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 11:15:06 2022 +1000

    Update replica bitterdream(PathOfBuildingCommunity#4775)

commit 9b9c49f
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 11:12:56 2022 +1000

    Add support for Arrow Dancing (PathOfBuildingCommunity#4779)

commit f468faa
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 11:06:59 2022 +1000

    [Kalandra] Update batch 4 of uniques. (PathOfBuildingCommunity#4757)

    * update uniques

    * added movement on throwing a trap.

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 54d1740
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:57:50 2022 +1000

    Update sources of longer obtainable uniques (PathOfBuildingCommunity#4748)

    * No longer obtainable

    * Cameria's Avarice now obtainable from vendor recipe.

commit 0961142
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:54:36 2022 +1000

    update uniques (PathOfBuildingCommunity#4754)

commit 3052165
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:49:46 2022 +1000

    [Kalandra] Update batch 2 of uniques. (PathOfBuildingCommunity#4751)

    * set2 update uniques.

    * Fix bug with wording.

    * Change to use PercentStat

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit fe51e95
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:43:59 2022 +1000

    Update Manastorm and Kongming's Stratagem to new bases (PathOfBuildingCommunity#4783)

commit 456c70d
Author: LocalIdentity <localidentity2@gmail.com>
Date:   Sun Aug 14 10:25:33 2022 +1000

    Fix Suppression mastery

commit 49dd720
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 10:20:12 2022 +1000

    [Kalandra] Update batch 1 of uniques. (PathOfBuildingCommunity#4747)

    * update

    * Update ModParser.lua

    * Update boots.lua

    * Update ModParser.lua

    * support

    * Remove Covered in Ash mod parsing

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 54c24b5
Author: QuickStick <31533893+QuickStick123@users.noreply.github.com>
Date:   Sun Aug 14 09:53:41 2022 +1000

    Add support for minions have Unholy Might (PathOfBuildingCommunity#4780)

commit c65c194
Author: Lexy <learn2draw@live.nl>
Date:   Sun Aug 14 01:23:47 2022 +0200

    Update brittle values (PathOfBuildingCommunity#4696)

commit 6cc2124
Author: Lexy <learn2draw@live.nl>
Date:   Sat Aug 13 23:14:54 2022 +0200

    Update ward recharge speed (PathOfBuildingCommunity#4697)

commit dd240b9
Author: Nightblade <Nightblade@users.noreply.github.com>
Date:   Sat Aug 13 11:58:36 2022 +1000

    Update ring.lua (PathOfBuildingCommunity#4773)

    spelling

commit 1fa9ab4
Author: LocalIdentity <localidentity2@gmail.com>
Date:   Sat Aug 13 11:18:25 2022 +1000

    Compact parsing of weapon types for multistrike

commit c1903af
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 02:53:33 2022 +0200

    Fix: Multistrike damage calculation with skills which have bow and melee Tag (PathOfBuildingCommunity#4740)

    * wording of blood of karui fixed

    * undo messy work

    * damage and atk increase only applies to melee weapons and unarmed

    * added less attack damage modifier to also apply to bows

    * adding ModFlag.Attack Condition with bit.bor

    * Add lines to export files

    Co-authored-by: Sinured <githubmm@use.startmail.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 5d94436
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 01:51:28 2022 +0200

    Fix: Blood of the Karui Life recovered and wording  (PathOfBuildingCommunity#4729)

    * wording of blood of karui fixed

    * Fix: increased life recovered of current version

    * changed wording for Blood of the karui and Lavianga's Spirit

    * fixed order and wording

    * Capitalised Flask Effect

    Co-authored-by: Sinured <githubmm@use.startmail.com>

commit e5ddd8e
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 01:47:56 2022 +0200

    [Kalandra] Batch of uniques update. All missing starting with S (PathOfBuildingCommunity#4753)

    * all missing uniques starting with S

    * minions deal no non damage & minions convert phys to xyz

    * testcommit to check busted

    * Fix mod parsing format

    Co-authored-by: Sinured <githubmm@use.startmail.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 701e719
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 01:22:08 2022 +0200

    Batch of uniques update. All missingfrom D to L (PathOfBuildingCommunity#4769)

    Co-authored-by: Sinured <githubmm@use.startmail.com>

commit f17690d
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 00:52:07 2022 +0200

    [Kalandra] Lifetap & Blessing interaction (PathOfBuildingCommunity#4752)

    * wording of blood of karui fixed

    * undo messy work

    * lifetap cant support skills with blessing tag

    * testcommit to check busted

    Co-authored-by: Sinured <githubmm@use.startmail.com>

commit d7d91f9
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 00:49:26 2022 +0200

    [Kalandra]Batch of uniques update. All missing starting with R (PathOfBuildingCommunity#4760)

    * item variants for R added

    * implements Ralakesh's Impatience unique affix

    * Add parsing for always Freeze, Shock and Ignite

    Co-authored-by: Sinured <githubmm@use.startmail.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 0bfc259
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 00:28:25 2022 +0200

    uniques variants added (PathOfBuildingCommunity#4763)

    Co-authored-by: Sinured <githubmm@use.startmail.com>

commit 4c8127c
Author: Sinured <100538010+Sinured@users.noreply.github.com>
Date:   Sat Aug 13 00:14:26 2022 +0200

    [Kalandra] Batch of unique update. All remaining from M to O (PathOfBuildingCommunity#4767)

    * adds remaining unique batch from M to O

    * Fix Ondar's Clasp variant

    Co-authored-by: Sinured <githubmm@use.startmail.com>
    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit c855506
Author: Regisle <49933620+Regisle@users.noreply.github.com>
Date:   Sat Aug 13 07:31:06 2022 +0930

    Add 3.19 Tree (PathOfBuildingCommunity#4744)

    * add Initial support for adding non-Tree nodes to Tree (Nine lives)

    * update positions and add other dummy nodes

    * separate stats and reminder text and add new nodes

    * rest of nodes

    * Fix comma

    * fix spelling of sapped

    * update spec.lua for passiveSkills

    * remove unrelated spec

    * update file to hardcode group and node IDs, and correct ascendency

    * update to new tree

    * add initial 3_19 tree

    * spelling fix

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 78d1390
Author: Nostrademous <nostrademous@hotmail.com>
Date:   Fri Aug 12 13:47:50 2022 -0400

    Fix: when upconverting between trees, if a Mastery lost a mod from its pool that was allocated it would error (PathOfBuildingCommunity#4765)

commit c819a68
Author: Regisle <49933620+Regisle@users.noreply.github.com>
Date:   Sat Aug 13 01:24:04 2022 +0930

    Update fix_ascendancy_positions.py to support new extra tree nodes (PathOfBuildingCommunity#4357)

    * add Initial support for adding non-Tree nodes to Tree (Nine lives)

    * update positions and add other dummy nodes

    * separate stats and reminder text and add new nodes

    * rest of nodes

    * Fix comma

    * fix spelling of sapped

    * update spec.lua for passiveSkills

    * remove unrelated spec

    * update file to hardcode group and node IDs, and correct ascendency

    * update to new tree

    * spelling fix

    Co-authored-by: LocalIdentity <localidentity2@gmail.com>

commit 872d4e2
Author: Regisle <49933620+Regisle@users.noreply.github.com>
Date:   Fri Aug 12 18:42:10 2022 +0930

    Jugg armour applies to ele damage (PathOfBuildingCommunity#4673)

    * Add support for % of armour applies to elemental damage

    * add mod parser change

    * cap percent of armour

    * fix merge conflict

    * add breakdown and fix phys not apply

    * add to main breakdown

* Revert "Squashed commit of the following:"

This reverts commit 1d7c641.

* Revert "Revert "Squashed commit of the following:""

This reverts commit b0ebcd7.

* fix merge issues.

* fix typo

* Fix redundant stuff on hits with spells

* Fix missing bracket

* Update arcane surge
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wires77 Wires77 Wires77 approved these changes

Assignees

No one assigned

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Arcane Surge buff is not granted from Tree skills

2 participants

@QuickStick123 @Wires77