Skip to content

Commit 2d65aa3

Browse files
committed
Address most requested changes.
1 parent 48450c8 commit 2d65aa3

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

src/Modules/CalcPerform.lua

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -487,15 +487,20 @@ local function doActorAttribsPoolsConditions(env, actor)
487487
end
488488
if actor.mainSkill.skillFlags.totem then
489489
condList["HaveTotem"] = true
490-
condList["TotemsHitRecently"] = true
491490
condList["SummonedTotemRecently"] = true
492-
if actor.mainSkill.skillFlags.spell then
493-
condList["TotemsSpellHitRecently"] = true
491+
if actor.mainSkill.skillFlags.hit then
492+
condList["TotemsHitRecently"] = true
493+
if actor.mainSkill.skillFlags.spell then
494+
condList["TotemsSpellHitRecently"] = true
495+
end
494496
end
495497
end
496498
if actor.mainSkill.skillFlags.mine then
497499
condList["DetonatedMinesRecently"] = true
498500
end
501+
if actor.mainSkill.skillFlags.trap then
502+
condList["TriggeredTrapsRecently"] = true
503+
end
499504
if modDB:Sum("BASE", nil, "EnemyScorchChance") > 0 or modDB:Flag(nil, "CritAlwaysAltAilments") and not modDB:Flag(nil, "NeverCrit") then
500505
condList["CanInflictScorch"] = true
501506
end

src/Modules/ConfigOptions.lua

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -869,7 +869,7 @@ return {
869869
{ var = "conditionKilledPosionedLast2Seconds", type = "check", label = "Killed a poisoned enemy in the last 2 Seconds?", ifCond = "KilledPosionedLast2Seconds", implyCond = "KilledRecently", tooltip = "This also implies that you have Killed Recently.", apply = function(val, modList, enemyModList)
870870
modList:NewMod("Condition:KilledPosionedLast2Seconds", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
871871
end },
872-
{ var = "conditionKilledTauntedEnemyRecently", type = "check", label = "Killed a taunted enemey recently?", ifCond = "KilledTauntedEnemyRecently", implyCondList = {"KilledRecently", "TauntedEnemyRecently" }, tooltip = "This also implies that you have Killed and taunted recently.", apply = function(val, modList, enemyModList)
872+
{ var = "conditionKilledTauntedEnemyRecently", type = "check", label = "Killed a taunted enemy recently?", ifCond = "KilledTauntedEnemyRecently", implyCondList = {"KilledRecently", "TauntedEnemyRecently" }, tooltip = "This also implies that you have killed and taunted recently.", apply = function(val, modList, enemyModList)
873873
modList:NewMod("Condition:KilledTauntedEnemyRecently", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
874874
end },
875875
{ var = "conditionTotemsNotSummonedInPastTwoSeconds", type = "check", label = "No summoned Totems in the past 2 seconds?", ifCond = "NoSummonedTotemsInPastTwoSeconds", apply = function(val, modList, enemyModList)
@@ -1097,8 +1097,8 @@ return {
10971097
{ var = "multiplierMineDetonatedRecently", type = "count", label = "# of Mines Detonated Recently:", ifMult = "MineDetonatedRecently", implyCond = "DetonatedMinesRecently", apply = function(val, modList, enemyModList)
10981098
modList:NewMod("Multiplier:MineDetonatedRecently", "BASE", val, "Config", { type = "Condition", var = "Combat" })
10991099
end },
1100-
{ var = "TriggeredTrapRecently", type = "check", label = "Have you Triggered a Trap Recently?", ifCond = "TriggeredTrapRecently", apply = function(val, modList, enemyModList)
1101-
modList:NewMod("Condition:TriggeredTrapRecently", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
1100+
{ var = "TriggeredTrapsRecently", type = "check", label = "Have you Triggered a Trap Recently?", ifCond = "TriggeredTrapsRecently", apply = function(val, modList, enemyModList)
1101+
modList:NewMod("Condition:TriggeredTrapsRecently", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
11021102
end },
11031103
{ var = "multiplierTrapTriggeredRecently", type = "count", label = "# of Traps Triggered Recently:", ifMult = "TrapTriggeredRecently", implyCond = "TriggeredTrapRecently", apply = function(val, modList, enemyModList)
11041104
modList:NewMod("Multiplier:TrapTriggeredRecently", "BASE", val, "Config", { type = "Condition", var = "Combat" })

src/Modules/ModParser.lua

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1217,7 +1217,7 @@ local modTagList = {
12171217
["while moving"] = { tag = { type = "Condition", var = "Moving" } },
12181218
["while channelling"] = { tag = { type = "Condition", var = "Channelling" } },
12191219
["after channelling for (%d+) seconds?"] = { tag = { type = "Condition", var = "Channelling" } },
1220-
["if you've been channelling for at least (%d+) second"] = { tag = { type = "Condition", var = "Channelling" } },
1220+
["if you've been channelling for at least (%d+) seconds?"] = { tag = { type = "Condition", var = "Channelling" } },
12211221
["if you've inflicted exposure recently"] = { tag = { type = "Condition", var = "AppliedExposureRecently" } },
12221222
["while you have no power charges"] = { tag = { type = "StatThreshold", stat = "PowerCharges", threshold = 0, upper = true } },
12231223
["while you have no frenzy charges"] = { tag = { type = "StatThreshold", stat = "FrenzyCharges", threshold = 0, upper = true } },
@@ -1409,7 +1409,7 @@ local modTagList = {
14091409
["if you detonated a mine recently"] = { tag = { type = "Condition", var = "DetonatedMinesRecently" } },
14101410
["if you[' ]h?a?ve detonated a mine recently"] = { tag = { type = "Condition", var = "DetonatedMinesRecently" } },
14111411
["when your mine is detonated targeting an enemy"] = { tag = { type = "Condition", var = "DetonatedMinesRecently" } },
1412-
["when your trap is triggered by an enemy"] = { tag = { type = "Condition", var = "TriggeredTrapRecently" } },
1412+
["when your trap is triggered by an enemy"] = { tag = { type = "Condition", var = "TriggeredTrapsRecently" } },
14131413
["if energy shield recharge has started recently"] = { tag = { type = "Condition", var = "EnergyShieldRechargeRecently" } },
14141414
["when cast on frostbolt"] = { tag = { type = "Condition", var = "CastOnFrostbolt" } },
14151415
["branded enemy's"] = { tag = { type = "MultiplierThreshold", var = "BrandsAttachedToEnemy", threshold = 1 } },
@@ -2620,7 +2620,7 @@ local specialModList = {
26202620
["when you warcry, you and nearby allies gain onslaught for 4 seconds"] = { mod("ExtraAura", "LIST", { mod = flag("Onslaught") }, { type = "Condition", var = "UsedWarcryRecently" }) },
26212621
["warcries grant arcane surge to you and allies, with (%d+)%% increased effect per (%d+) power, up to (%d+)%%"] = function(num, _, div, limit) return {
26222622
flag("Condition:ArcaneSurge", { type = "Condition", var = "UsedWarcryRecently" }),
2623-
mod("ArcaneSurgeEffect", "INC", num, { type = "PerStat", stat = "WarcryPower", div = tonumber(div), globalLimit = tonumber(limit), globalLimitKey = "Brinerot Flag"}, { type = "Condition", var = "UsedWarcryRecently" }),
2623+
mod("ArcaneSurgeEffect", "INC", num, { type = "PerStat", stat = "WarcryPower", div = tonumber(div), globalLimit = tonumber(limit), globalLimitKey = "Brinerot Flag"}, { type = "Condition", var = "UsedWarcryRecently" }),
26242624
} end,
26252625
["enemies in your chilling areas take (%d+)%% increased lightning damage"] = function(num) return { mod("EnemyModifier", "LIST", { mod = mod("LightningDamageTaken", "INC", num) }, { type = "ActorCondition", actor = "enemy", var = "InChillingArea" }) } end,
26262626
["(%d+)%% chance to sap enemies in chilling areas"] = function(num) return { mod("EnemySapChance", "BASE", num, { type = "ActorCondition", actor = "enemy", var = "InChillingArea" } ) } end,

0 commit comments

Comments
 (0)