Skip to content

Commit fa4aa64

Browse files
Fix Thrusting swords were not a base subType (PathOfBuildingCommunity#4720)
* Fix: Thrusting should be a base subType * Same changes but with less diff Co-authored-by: Wires77 <Wires77@users.noreply.github.com>
1 parent 9eddc38 commit fa4aa64

File tree

2 files changed

+54
-27
lines changed

2 files changed

+54
-27
lines changed

src/Data/Bases/sword.lua

Lines changed: 50 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,8 @@ itemBases["Energy Blade One Handed"] = {
277277
}
278278

279279
itemBases["Rusted Spike"] = {
280-
type = "Thrusting One Handed Sword",
280+
type = "One Handed Sword",
281+
subType = "Thrusting",
281282
socketLimit = 3,
282283
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
283284
implicit = "+25% to Global Critical Strike Multiplier",
@@ -286,7 +287,8 @@ itemBases["Rusted Spike"] = {
286287
req = { dex = 20, },
287288
}
288289
itemBases["Whalebone Rapier"] = {
289-
type = "Thrusting One Handed Sword",
290+
type = "One Handed Sword",
291+
subType = "Thrusting",
290292
socketLimit = 3,
291293
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
292294
implicit = "+25% to Global Critical Strike Multiplier",
@@ -295,7 +297,8 @@ itemBases["Whalebone Rapier"] = {
295297
req = { level = 7, dex = 32, },
296298
}
297299
itemBases["Battered Foil"] = {
298-
type = "Thrusting One Handed Sword",
300+
type = "One Handed Sword",
301+
subType = "Thrusting",
299302
socketLimit = 3,
300303
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
301304
implicit = "+25% to Global Critical Strike Multiplier",
@@ -304,7 +307,8 @@ itemBases["Battered Foil"] = {
304307
req = { level = 12, dex = 47, },
305308
}
306309
itemBases["Basket Rapier"] = {
307-
type = "Thrusting One Handed Sword",
310+
type = "One Handed Sword",
311+
subType = "Thrusting",
308312
socketLimit = 3,
309313
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
310314
implicit = "+25% to Global Critical Strike Multiplier",
@@ -313,7 +317,8 @@ itemBases["Basket Rapier"] = {
313317
req = { level = 17, dex = 62, },
314318
}
315319
itemBases["Jagged Foil"] = {
316-
type = "Thrusting One Handed Sword",
320+
type = "One Handed Sword",
321+
subType = "Thrusting",
317322
socketLimit = 3,
318323
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
319324
implicit = "+25% to Global Critical Strike Multiplier",
@@ -322,7 +327,8 @@ itemBases["Jagged Foil"] = {
322327
req = { level = 22, dex = 77, },
323328
}
324329
itemBases["Antique Rapier"] = {
325-
type = "Thrusting One Handed Sword",
330+
type = "One Handed Sword",
331+
subType = "Thrusting",
326332
socketLimit = 3,
327333
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
328334
implicit = "+25% to Global Critical Strike Multiplier",
@@ -331,7 +337,8 @@ itemBases["Antique Rapier"] = {
331337
req = { level = 26, dex = 89, },
332338
}
333339
itemBases["Elegant Foil"] = {
334-
type = "Thrusting One Handed Sword",
340+
type = "One Handed Sword",
341+
subType = "Thrusting",
335342
socketLimit = 3,
336343
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
337344
implicit = "+25% to Global Critical Strike Multiplier",
@@ -340,7 +347,8 @@ itemBases["Elegant Foil"] = {
340347
req = { level = 30, dex = 101, },
341348
}
342349
itemBases["Thorn Rapier"] = {
343-
type = "Thrusting One Handed Sword",
350+
type = "One Handed Sword",
351+
subType = "Thrusting",
344352
socketLimit = 3,
345353
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
346354
implicit = "+35% to Global Critical Strike Multiplier",
@@ -349,7 +357,8 @@ itemBases["Thorn Rapier"] = {
349357
req = { level = 34, dex = 113, },
350358
}
351359
itemBases["Smallsword"] = {
352-
type = "Thrusting One Handed Sword",
360+
type = "One Handed Sword",
361+
subType = "Thrusting",
353362
socketLimit = 3,
354363
tags = { maraketh = true, rapier = true, onehand = true, not_for_sale = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
355364
implicit = "15% chance to cause Bleeding on Hit",
@@ -358,7 +367,8 @@ itemBases["Smallsword"] = {
358367
req = { level = 36, dex = 124, },
359368
}
360369
itemBases["Wyrmbone Rapier"] = {
361-
type = "Thrusting One Handed Sword",
370+
type = "One Handed Sword",
371+
subType = "Thrusting",
362372
socketLimit = 3,
363373
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
364374
implicit = "+25% to Global Critical Strike Multiplier",
@@ -367,7 +377,8 @@ itemBases["Wyrmbone Rapier"] = {
367377
req = { level = 37, dex = 122, },
368378
}
369379
itemBases["Burnished Foil"] = {
370-
type = "Thrusting One Handed Sword",
380+
type = "One Handed Sword",
381+
subType = "Thrusting",
371382
socketLimit = 3,
372383
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
373384
implicit = "+25% to Global Critical Strike Multiplier",
@@ -376,7 +387,8 @@ itemBases["Burnished Foil"] = {
376387
req = { level = 40, dex = 131, },
377388
}
378389
itemBases["Estoc"] = {
379-
type = "Thrusting One Handed Sword",
390+
type = "One Handed Sword",
391+
subType = "Thrusting",
380392
socketLimit = 3,
381393
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
382394
implicit = "+25% to Global Critical Strike Multiplier",
@@ -385,7 +397,8 @@ itemBases["Estoc"] = {
385397
req = { level = 43, dex = 140, },
386398
}
387399
itemBases["Serrated Foil"] = {
388-
type = "Thrusting One Handed Sword",
400+
type = "One Handed Sword",
401+
subType = "Thrusting",
389402
socketLimit = 3,
390403
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
391404
implicit = "+25% to Global Critical Strike Multiplier",
@@ -394,7 +407,8 @@ itemBases["Serrated Foil"] = {
394407
req = { level = 46, dex = 149, },
395408
}
396409
itemBases["Primeval Rapier"] = {
397-
type = "Thrusting One Handed Sword",
410+
type = "One Handed Sword",
411+
subType = "Thrusting",
398412
socketLimit = 3,
399413
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
400414
implicit = "+25% to Global Critical Strike Multiplier",
@@ -403,7 +417,8 @@ itemBases["Primeval Rapier"] = {
403417
req = { level = 49, dex = 158, },
404418
}
405419
itemBases["Fancy Foil"] = {
406-
type = "Thrusting One Handed Sword",
420+
type = "One Handed Sword",
421+
subType = "Thrusting",
407422
socketLimit = 3,
408423
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
409424
implicit = "+25% to Global Critical Strike Multiplier",
@@ -412,7 +427,8 @@ itemBases["Fancy Foil"] = {
412427
req = { level = 52, dex = 167, },
413428
}
414429
itemBases["Apex Rapier"] = {
415-
type = "Thrusting One Handed Sword",
430+
type = "One Handed Sword",
431+
subType = "Thrusting",
416432
socketLimit = 3,
417433
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
418434
implicit = "+35% to Global Critical Strike Multiplier",
@@ -421,7 +437,8 @@ itemBases["Apex Rapier"] = {
421437
req = { level = 55, dex = 176, },
422438
}
423439
itemBases["Courtesan Sword"] = {
424-
type = "Thrusting One Handed Sword",
440+
type = "One Handed Sword",
441+
subType = "Thrusting",
425442
socketLimit = 3,
426443
tags = { maraketh = true, rapier = true, onehand = true, not_for_sale = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
427444
implicit = "15% chance to cause Bleeding on Hit",
@@ -430,7 +447,8 @@ itemBases["Courtesan Sword"] = {
430447
req = { level = 57, dex = 190, },
431448
}
432449
itemBases["Dragonbone Rapier"] = {
433-
type = "Thrusting One Handed Sword",
450+
type = "One Handed Sword",
451+
subType = "Thrusting",
434452
socketLimit = 3,
435453
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
436454
implicit = "+25% to Global Critical Strike Multiplier",
@@ -439,7 +457,8 @@ itemBases["Dragonbone Rapier"] = {
439457
req = { level = 58, dex = 185, },
440458
}
441459
itemBases["Tempered Foil"] = {
442-
type = "Thrusting One Handed Sword",
460+
type = "One Handed Sword",
461+
subType = "Thrusting",
443462
socketLimit = 3,
444463
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
445464
implicit = "+25% to Global Critical Strike Multiplier",
@@ -448,7 +467,8 @@ itemBases["Tempered Foil"] = {
448467
req = { level = 60, dex = 212, },
449468
}
450469
itemBases["Pecoraro"] = {
451-
type = "Thrusting One Handed Sword",
470+
type = "One Handed Sword",
471+
subType = "Thrusting",
452472
socketLimit = 3,
453473
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
454474
implicit = "+25% to Global Critical Strike Multiplier",
@@ -457,7 +477,8 @@ itemBases["Pecoraro"] = {
457477
req = { level = 62, dex = 212, },
458478
}
459479
itemBases["Spiraled Foil"] = {
460-
type = "Thrusting One Handed Sword",
480+
type = "One Handed Sword",
481+
subType = "Thrusting",
461482
socketLimit = 3,
462483
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
463484
implicit = "+25% to Global Critical Strike Multiplier",
@@ -466,7 +487,8 @@ itemBases["Spiraled Foil"] = {
466487
req = { level = 64, dex = 212, },
467488
}
468489
itemBases["Vaal Rapier"] = {
469-
type = "Thrusting One Handed Sword",
490+
type = "One Handed Sword",
491+
subType = "Thrusting",
470492
socketLimit = 3,
471493
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
472494
implicit = "+25% to Global Critical Strike Multiplier",
@@ -475,7 +497,8 @@ itemBases["Vaal Rapier"] = {
475497
req = { level = 66, dex = 212, },
476498
}
477499
itemBases["Jewelled Foil"] = {
478-
type = "Thrusting One Handed Sword",
500+
type = "One Handed Sword",
501+
subType = "Thrusting",
479502
socketLimit = 3,
480503
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
481504
implicit = "+25% to Global Critical Strike Multiplier",
@@ -484,7 +507,8 @@ itemBases["Jewelled Foil"] = {
484507
req = { level = 68, dex = 212, },
485508
}
486509
itemBases["Harpy Rapier"] = {
487-
type = "Thrusting One Handed Sword",
510+
type = "One Handed Sword",
511+
subType = "Thrusting",
488512
socketLimit = 3,
489513
tags = { onehand = true, rapier = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
490514
implicit = "+35% to Global Critical Strike Multiplier",
@@ -493,7 +517,8 @@ itemBases["Harpy Rapier"] = {
493517
req = { level = 70, dex = 212, },
494518
}
495519
itemBases["Dragoon Sword"] = {
496-
type = "Thrusting One Handed Sword",
520+
type = "One Handed Sword",
521+
subType = "Thrusting",
497522
socketLimit = 3,
498523
tags = { maraketh = true, rapier = true, onehand = true, not_for_sale = true, weapon = true, sword = true, one_hand_weapon = true, default = true, },
499524
implicit = "20% chance to cause Bleeding on Hit",

src/Export/Bases/sword.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,16 @@ local itemBases = ...
1313
#base Metadata/Items/Weapons/OneHandWeapons/OneHandSwords/StormBladeOneHand
1414
#forceHide false
1515

16-
#type Thrusting One Handed Sword
16+
#type One Handed Sword
17+
#subType Thrusting
1718
#baseMatch Metadata/Items/Weapons/OneHandWeapons/OneHandThrustingSwords/Rapier
1819

1920
#type Two Handed Sword
21+
#subType
2022
#socketLimit 6
2123
#baseTags weapon twohand sword two_hand_weapon
2224
#baseMatch Metadata/Items/Weapons/TwoHandWeapons/TwoHandSwords/TwoHandSword
2325

2426
#forceHide true
2527
#base Metadata/Items/Weapons/TwoHandWeapons/TwoHandSwords/StormBladeTwoHand
26-
#forceHide false
28+
#forceHide false

0 commit comments

Comments
 (0)