-
Notifications
You must be signed in to change notification settings - Fork 7
Release 0.3.0 #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 0.3.0 #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of black and isort, run ruff as pre-commit hook. Enable pyupgrade and additional rules. Applied safe auto-fixes, but validation currently fails. Will be addressed in a follow-up PR (PEtab-dev#252). Relevant changes: `.pre-commit-config.yaml`, `pyproject.toml`
Follow-up to PEtab-dev#251 * Manual changes for compatibility with selected ruff rules * run pre-commit hooks on GHA instead of flake8 * run tests on python3.12
Allow changing the default style for line plots.
Require python>=3.10 according to [NEP-0029](https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule).
Centralize sympification of PEtab and SBML math expressions. Simplifies incorporating PEtab-dev#260 Also fixes likely collisions of SBML model entities with sympy entities.
So far, sympy 1.11 was used due to pysb, but this is incompatible with numpy>=2.0
dilpath
approved these changes
Jun 24, 2024
Member
dilpath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
m-philipps
approved these changes
Jun 25, 2024
Collaborator
m-philipps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.