Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jun 24, 2024

No description provided.

PaulJonasJost and others added 14 commits March 12, 2024 17:19
Instead of black and isort, run ruff as pre-commit hook. Enable pyupgrade and additional rules.

Applied safe auto-fixes, but validation currently fails. Will be addressed in a follow-up PR (PEtab-dev#252).

Relevant changes: `.pre-commit-config.yaml`, `pyproject.toml`
Follow-up to PEtab-dev#251 

* Manual changes for compatibility with selected ruff rules
* run pre-commit hooks on GHA instead of flake8
* run tests on python3.12
Allow changing the default style for line plots.
Centralize sympification of PEtab and SBML math expressions.

Simplifies incorporating PEtab-dev#260

Also fixes likely collisions of SBML model entities with sympy entities.
So far, sympy 1.11 was used due to pysb, but this is incompatible with numpy>=2.0
@dweindl dweindl requested review from a team, dilpath and m-philipps as code owners June 24, 2024 17:36
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@m-philipps m-philipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this.

@dweindl dweindl merged commit c427340 into PEtab-dev:main Jun 25, 2024
@dweindl dweindl deleted the release_0.3.0 branch June 25, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants