-
Notifications
You must be signed in to change notification settings - Fork 7
Add PEtab math parser and sympy converter #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Centralize sympification of PEtab and SBML math expressions. Simplifies incorporating PEtab-dev#260 Also fixes likely collisions of model entities with sympy entities.
Centralize sympification of PEtab and SBML math expressions. Simplifies incorporating #260 Also fixes likely collisions of SBML model entities with sympy entities.
Related to PEtab-dev/PEtab#579 * ANTLR grammar for PEtab math expressions + derived lexer/parser/visitor * Test cases * PEtab -> SymPy converter
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #260 +/- ##
===========================================
- Coverage 76.12% 75.68% -0.45%
===========================================
Files 36 40 +4
Lines 3238 4137 +899
Branches 785 891 +106
===========================================
+ Hits 2465 3131 +666
- Misses 568 744 +176
- Partials 205 262 +57 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks like a nice design, thanks for setting this up. I didn't check _generated
much.
This math parsing code is generally unfamiliar to me, but I didn't see anything obviously wrong, and I'm happy with the tests.
Good. That's auto-generated and not really meant to be read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Related to PEtab-dev/PEtab#579
Note: All sympy symbols in PEtab match expressions now have
real=True
.