maint: fix code style, check on gha #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
===========================================
+ Coverage 76.20% 76.24% +0.03%
===========================================
Files 34 34
Lines 3215 3216 +1
Branches 780 780
===========================================
+ Hits 2450 2452 +2
+ Misses 561 560 -1
Partials 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
dweindl
added a commit
that referenced
this pull request
Apr 16, 2024
Instead of black and isort, run ruff as pre-commit hook. Enable pyupgrade and additional rules. Applied safe auto-fixes, but validation currently fails. Will be addressed in a follow-up PR (#252). Relevant changes: `.pre-commit-config.yaml`, `pyproject.toml`
dilpath
approved these changes
Apr 16, 2024
Comment on lines
55
to
+58
| except KeyError: | ||
| raise KeyError( | ||
| f"Observable table missing mandatory field {OBSERVABLE_ID}." | ||
| ) | ||
| ) from None |
Member
Author
There was a problem hiding this comment.
I'd prefer from None. We only want this simple message here without the pandas error on top.
Comment on lines
47
to
+50
| except KeyError: | ||
| raise KeyError( | ||
| f"Condition table missing mandatory field {CONDITION_ID}." | ||
| ) | ||
| ) from None |
| ], | ||
| "quality": [ | ||
| "flake8>=3.8.3", | ||
| "pre-commit", |
Member
There was a problem hiding this comment.
Is the ruff dependency somehow managed by pre-commit and the ruff-pre-commit repo?
Comment on lines
+387
to
+392
| f"observableParameter1_{obs1_1_1_1}" | ||
| f" + observableParameter2_{obs1_1_1_1}", | ||
| f"observableParameter1_{obs1_2_1_1}" | ||
| f" + observableParameter2_{obs1_2_1_1}", | ||
| f"observableParameter1_{obs1_2_2_1}" | ||
| f" + observableParameter2_{obs1_2_2_1}", |
Member
Author
There was a problem hiding this comment.
we should have thought of something shorter than "observableParameter1_" 😅 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #251